Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Bara <bbara93@gmail.com>
To:     dmitry.osipenko@collabora.com, konstantin@linuxfoundation.org
Cc:     bbara93@gmail.com, benjamin.bara@skidata.com, jonathanh@nvidia.com,
        lee@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        peterz@infradead.org, rafael.j.wysocki@intel.com,
        richard.leitner@linux.dev, treding@nvidia.com,
        wsa+renesas@sang-engineering.com, wsa@kernel.org
Subject: Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler
Date:   Wed, 19 Jul 2023 10:22:51 +0200
Message-Id: <20230719082251.3501424-1-bbara93@gmail.com>
In-Reply-To: <215679f1-a866-1e92-1bab-9c80918927a6@collabora.com>
References: <215679f1-a866-1e92-1bab-9c80918927a6@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Dmitry,

thanks for the feedback!

On Tue, 18 Jul 2023 at 06:46, Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote:
> 15.07.2023 10:53, Benjamin Bara пишет:
> >
> > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > Acked-for-MFD-by: Lee Jones <lee@kernel.org>
>
> Acked-for-MFD-by isn't a valid tag, scripts/checkpatch.pl should tell
> you about it.
>
> In general you may add a comment to a tag, like this:
>
>   Acked-by: Lee Jones <lee@kernel.org> # for MFD
>
> In this particular case, the comment is unnecessary because Lee is the
> MFD maintainer, hence his ack itself implies the MFD subsys.

I saw the warning, but Lee requested to add it like this [1].

@Konstantin:
Do you think it makes sense to print a warning when adding "non-standard
trailers" during running "b4 trailers -u", maybe around the
find_trailers() checks? I could provide a RFC, if considered useful.

Best regards,
Benjamin

[1] https://lore.kernel.org/all/20230518094434.GD404509@google.com/