Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b8cc0229-d663-3527-b320-51a48b4af5b5@postmarketos.org>
Date:   Wed, 19 Jul 2023 11:36:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] arm64: dts: qcom: sdm630: remove refs to nonexistent
 clocks
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
References: <20230719073520.2644966-1-alexeymin@postmarketos.org>
 <9e38d2f5-6da4-089e-1c70-a89069708909@linaro.org>
Content-Language: en-US
From:   Alexey Minnekhanov <alexeymin@postmarketos.org>
In-Reply-To: <9e38d2f5-6da4-089e-1c70-a89069708909@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19.07.2023 10:39, Krzysztof Kozlowski wrote:
> On 19/07/2023 09:35, Alexey Minnekhanov wrote:
>> Since commit d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out
>> interconnect bus clocks") rpmcc-sdm660 no longer provides
>> RPM_SMD_AGGR2_NOC_CLK and RPM_SMD_AGGR2_NOC_A_CLK clocks.
>> Remove them to fix various probe failures and get devices
>> booting again.
> 
> So that commit broke DTS?
> 

Yes, this is my understanding of the situation.
The commit in subject [1] is only in linux-next for a few days, so it 
broke booting only on 6.5-rc (rc2 currently). Konrad said: "these clocks 
references were API abuses; referencing the bus clocks was circumventing 
the interconnect layer. That loophole is now gone and the abusers are 
now apparent"

> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check`
> 

If DT schema for interconnect requires bus clocks to be specified, I 
don't even know what to put there now. Can we change schema?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d6edc31f3a68d8d0636e0cfcd9eced7460ad32f4

-- 
Regards,
Alexey Minnekhanov
postmarketOS developer