Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <88c8e146-a0da-161a-fc03-5bda103aff12@linaro.org>
Date:   Wed, 19 Jul 2023 10:57:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
To:     Alina Yu <alina_yu@richtek.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <1689740741-29244-1-git-send-email-alina_yu@richtek.com>
 <1689740741-29244-2-git-send-email-alina_yu@richtek.com>
 <860fffab-3c48-027d-aa2e-b15fc8f7a760@linaro.org>
 <20230719084619.GA10314@linuxcarl2.richtek.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230719084619.GA10314@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/07/2023 10:46, Alina Yu wrote:
> Hi,
> Krzysztof,
> 
> On Wed, Jul 19, 2023 at 09:43:03AM +0200, Krzysztof Kozlowski wrote:
>> On 19/07/2023 06:25, alina_yu@richtek.com wrote:
>>> From: alinayu <alina_yu@richtek.com>
>>>
>>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>>>
>>> Signed-off-by: Alina Yu <alina_yu@richtek.com>
>>> ---
>>> v3
>>> - Fix some typos
>>> - Modify the descriptions for "richtek,mtp-sel"
>>> - Modify the node name to lowercase and remove underscore
>>> - Remove '|' from description
>>> - Remove "regulator-compatible" from property
>>> - Remove "regulator-state-mem" from pattern
>>> - Modify node name to generic one
>>> ---
>>>  .../regulator/richtek,rtq2208-regulator.yaml       | 206 +++++++++++++++++++++
>>>  1 file changed, 206 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>> new file mode 100644
>>> index 0000000..2fc92e5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>
>> No improvements here.
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>> Best regards,
>> Krzysztof
>>
> 
> 
> Sorry, I missed this one "Filename like compatible".
> If I modify the filename to "richtek,rtq2208.yaml", is it unlike a compatible ?

Yes.

Best regards,
Krzysztof