Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7928126rwp; Wed, 19 Jul 2023 02:30:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlEufOKuDt0uT4Buoy8T6Vh7ub+l1q7P+37RGfbAnVWcjiUCP7RLDLasZQIirMBcSUp2HpE4 X-Received: by 2002:a05:6a20:13da:b0:131:6464:2179 with SMTP id ho26-20020a056a2013da00b0013164642179mr14819687pzc.25.1689759016329; Wed, 19 Jul 2023 02:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689759016; cv=none; d=google.com; s=arc-20160816; b=StGWyAsdY4EdudnggTYmdy4l9sVVyueohOuYR1rpn+F+zZlmW6ZPJrjLX1uJVnGvpB KlaOYimW1gqDO+rJGUPxr02yyavS9kInUD8nO0AwlsLrI5+7MNJTTiUQ4m6JeF4RiKwB Hghtbkj/uMf7sS8E2EmV2CVbMgdb7gkJC8UPdH8Ow0cnWrg7uExFIsfzCN5z9dPy2/s0 Hp08WVxgX7268dlTChk+N4V0CgXbevO6Q/uAoyfRDTrSX1hm7p6+95Zx9CHechSbkdSg pQQ/cIJrkPCeokcO4WNfaMrl8AV3W3biHkEIEF9ooN6r1cIa/FAzk/iOkeCVBBzDamN3 u+mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=5CSZoGMDI/hdekR/J4YdepX1Y51Vo4MjT2QEGc3hFhk=; fh=iqcd9ZRqW5k9WoIQ8wIhnKMm/TDrwypyiRafJPPfAGs=; b=dyU+eqZ6soQoKgVUKKD7umjl8ozEqD2on/YFQE5As7zkFwvkH/t+0RPRxKogB+QSXD F0+1BZ3W8LCo+yNvZCVkKFNLEi2c6eZR1ayUlyx2gOR/GQFunjjEqsdYLi8MS7cFoRFR T1hVT5CT7KXiRs21JJ1wYRDMunS4UqBf+B6FuplIkC88M6wufk32fqMS4750nI6660Gd HhsQ7bgN59NMkcL8CwLA35ktvA6pgjFFLD01SDMMEm5P3/HyMkCiH26fKm+qbcp8OlNH 6JyhfR3GtUuqsdwnO19sFmcA9fjQkvcZe9MqbpCVYpFi3lU8rfDtL6A4Q/bE6OP7ykKJ jCeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w17-20020a63c111000000b0054f73ee92basi3030640pgf.8.2023.07.19.02.30.04; Wed, 19 Jul 2023 02:30:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbjGSJSt (ORCPT + 99 others); Wed, 19 Jul 2023 05:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbjGSJSs (ORCPT ); Wed, 19 Jul 2023 05:18:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 368EC9D for ; Wed, 19 Jul 2023 02:18:47 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qM3KN-0003zm-MY; Wed, 19 Jul 2023 11:18:35 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qM3KM-00083D-QN; Wed, 19 Jul 2023 11:18:34 +0200 Date: Wed, 19 Jul 2023 11:18:34 +0200 From: Marco Felsch To: Shawn Guo Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/4] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O Board support Message-ID: <20230719091834.amfmakhwcp6562wu@pengutronix.de> References: <20230717165127.2882535-1-m.felsch@pengutronix.de> <20230717165127.2882535-4-m.felsch@pengutronix.de> <20230719081615.GQ151430@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719081615.GQ151430@dragon> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 23-07-19, Shawn Guo wrote: > On Mon, Jul 17, 2023 at 06:51:27PM +0200, Marco Felsch wrote: ... > > + reg_baseboard_vdd3v3: regulator-baseboard-vdd3v3 { > > + compatible = "regulator-fixed"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "BB_VDD3V3"; > > + gpio = <&expander0 10 GPIO_ACTIVE_HIGH>; > > + /* Required timings for ethernet phy's */ > > + startup-delay-us = <50000>; > > + off-on-delay-us = <110000>; > > + enable-active-high; > > Can we place this right after the line below? > > gpio = <&expander0 10 GPIO_ACTIVE_HIGH>; Sure. > > + regulator-always-on; > > + }; ... > > +&i2c4 { > > + expander0: gpio@20 { > > + compatible = "nxp,pca9535"; > > + reg = <0x20>; > > + gpio-controller; > > + #gpio-cells = <0x02>; > > + }; > > + > > + expander1: gpio@23 { > > + compatible = "nxp,pca9535"; > > + reg = <0x23>; > > + gpio-controller; > > + #gpio-cells = <0x02>; > > + > > + /* > > + * Since USB1 is bound to peripheral mode we need to ensure > > + * that VBUS is turned off. > > + */ > > + usb30-otg-hog { > > + gpio-hog; > > + gpios = <13 GPIO_ACTIVE_HIGH>; > > + output-low; > > + line-name = "USB30_OTG_EN"; > > + }; > > + }; > > + > > + eeprom@52 { > > + compatible = "atmel,24c02"; > > + reg = <0x52>; > > + pagesize = <16>; > > + }; > > + > > + rtc@51 { > > Sort them in order of unit-address. Of course, thanks. > > + compatible = "haoyu,hym8563"; > > + reg = <0x51>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rtc>; > > + interrupt-parent = <&gpio4>; > > + interrupts = <3 IRQ_TYPE_EDGE_FALLING>; > > + #clock-cells = <0>; > > + }; > > +}; > > +&i2c4 { > > + clock-frequency = <400000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c4>; > > + status = "okay"; > > + > > + adc@48 { > > + compatible = "ti,ads1115"; > > + reg = <0x48>; > > + > > Unnecessary newline. Dropped it, thanks. > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + channel@4 { > > + reg = <4>; > > + ti,gain = <1>; > > + ti,datarate = <7>; > > + }; > > Have a newline between nodes. Sure. Regards, Marco