Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 12:44:21 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Kemeng Shi <shikemeng@huaweicloud.com>
Cc:     akpm@linux-foundation.org, pasha.tatashin@soleen.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext
Message-ID: <20230719094421.GI1901145@kernel.org>
References: <20230718145812.1991717-1-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718145812.1991717-1-shikemeng@huaweicloud.com>
Precedence: bulk

On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote:
> Current client get data from page_ext by adding offset which is auto
> generated in page_ext core and expose the data layout design insdie
> page_ext core. This series adds a page_ext_data to hide offset from
> client. Thanks!

Implementers of page_ext_operations are anyway intimately related to
page_ext, so I'm not convinced this has any value.
 
> Kemeng Shi (3):
>   mm/page_ext: add common function to get client data from page_ext
>   mm/page_ext: use page_ext_data helper in page_table_check
>   mm/page_ext: use page_ext_data helper in page_owner
> 
>  include/linux/page_ext.h | 6 ++++++
>  mm/page_owner.c          | 2 +-
>  mm/page_table_check.c    | 2 +-
>  3 files changed, 8 insertions(+), 2 deletions(-)
> 
> -- 
> 2.30.0
> 
> 

-- 
Sincerely yours,
Mike.