Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <231b4e0c-bc58-1f4f-ac26-30fc0036887f@kernel.org>
Date:   Wed, 19 Jul 2023 18:43:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] ata: pata_serverworks: "foo * bar" should be "foo *bar"
Content-Language: en-US
To:     hanyu001@208suo.com
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <tencent_FAA8D636BA8369FE01896CB144F12E543905@qq.com>
 <fee05ac48ee8c60b0843a7d63260ba1d@208suo.com>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <fee05ac48ee8c60b0843a7d63260ba1d@208suo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/19/23 10:54, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo
> *bar"
> 
> Signed-off-by:     Yu Han <hanyu001@208suo.com>

Please stop sending patches like this. I will not apply such patch
unless you actually fix a bug or a compilation warning.

> ---
>  drivers/ata/pata_serverworks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_serverworks.c
> b/drivers/ata/pata_serverworks.c
> index b348784..549ff24 100644
> --- a/drivers/ata/pata_serverworks.c
> +++ b/drivers/ata/pata_serverworks.c
> @@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev *pdev)
> 
>      /* Third Channel Test */
>      if (!(PCI_FUNC(pdev->devfn) & 1)) {
> -        struct pci_dev *findev = NULL;
> +        struct pci_dev * findev = NULL;
>          u32 reg4c = 0;
>          findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
>              PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);

-- 
Damien Le Moal
Western Digital Research