Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alistair Popple <apopple@nvidia.com>
To:     akpm@linux-foundation.org
Cc:     ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com,
        iommu@lists.linux.dev, jgg@ziepe.ca, jhubbard@nvidia.com,
        kevin.tian@intel.com, kvm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
        mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com,
        robin.murphy@arm.com, seanjc@google.com, will@kernel.org,
        x86@kernel.org, zhi.wang.linux@gmail.com,
        Alistair Popple <apopple@nvidia.com>
Subject: [PATCH v2 2/5] mmu_notifiers: Fixup comment in mmu_interval_read_begin()
Date:   Wed, 19 Jul 2023 22:18:43 +1000
Message-Id: <06fa82756e4d6458895962a7743cc7f162658a54.1689768831.git-series.apopple@nvidia.com>
In-Reply-To: <cover.de78568883814904b78add6317c263bf5bc20234.1689768831.git-series.apopple@nvidia.com>
References: <cover.de78568883814904b78add6317c263bf5bc20234.1689768831.git-series.apopple@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I8Hp/XEt1php+k0PQt8VT07oZc/s69qy3zImfldRciLIoGjCKG/xIEnCP9UN?=
 =?us-ascii?Q?mmn0WSw9gDx6uZomtAGZpPP1qCYRA1GZSo6i5UHujo8VDqNbFcSnm5N8ZU+Y?=
 =?us-ascii?Q?1JE9+30sW8w0y8GZ0xxkwhI6u6jPGK6+gNvLzqQjJ8GfIIMKZMWsEYubErwp?=
 =?us-ascii?Q?Wi/6iBd77F9NYL9hPxzvfJmOZejAH4thW2wGyLZvCAz85aKcH07CYWbfN+FA?=
 =?us-ascii?Q?rp469VbccRU6i2bMUfA1pxITOh/o/31YqzeYzTNskRweJVtEJv45WHGHLIeC?=
 =?us-ascii?Q?keIRj/Fyvy+4lHwQ4aSjMpc74woH6N9CZULd3P533Gf5a79HOz7lgldCDHNj?=
 =?us-ascii?Q?Ps8ZAhWvwqNVgbFRtx3ojhAP6CTtv+3bsvhQP2uaisgO1pesvHqeXHNEi4GW?=
 =?us-ascii?Q?5u2EbN4L5e1G8IeYahLhTzZmy8qayzonkp1oVDF9FkDrGIHWr8qksh9jK06z?=
 =?us-ascii?Q?YvT4MutaJ4fNes5OFzWyJRYjwczNSUedy1UC5DVS7mItwFZgwEiKxmqI9NQT?=
 =?us-ascii?Q?yH3vgCAwo/q7zyzjD6fjA/eeZolsi/qskohHazkkkLfOj92wUQc1Wyc2SOsD?=
 =?us-ascii?Q?YrpReRHpLYGXUsiClD1F9s5CHsTJT+hgb2BhIL2FYhemWboEwqhUAXUbScPI?=
 =?us-ascii?Q?id+GnpCSvyNO47gkECSAlMfz6m98d9p2C2yLXbU0Sr1Bzkpr1XW0DDguIsXg?=
 =?us-ascii?Q?fS0eM/WO2tb+IMmDtMPuZkE3LBrt26WWVyO74FN+PaeM2kgADTJjPqjWIbIS?=
 =?us-ascii?Q?CBEJot7wdlTu7Wbhsm5itxs2/f+eMfl/0sb/WnGjxk1Mz1nwRoVMuncBe01P?=
 =?us-ascii?Q?AYfBJnmEuktIDSkoR3SDFw/6cKFHBSIwoZPQfWqwqSHaDv4VjCdIbNFt2q1Z?=
 =?us-ascii?Q?ePaB22M2fS9qHwv7Jv8jqwe4AW8qKNGK+Ll0pnnYqiyHJZvV45DdJrt040an?=
 =?us-ascii?Q?S1dhVmPQUo1DQyr+20OQShN9xyxpv6Gq6jaD6i8Ddn23wHBR5u5vsXvYTVUR?=
 =?us-ascii?Q?eDST3jPZEV60JxGoDBagg6FWwZqQ6H1zY9IwE+NmP4vL2xXY5VJ4P+QpYBQA?=
 =?us-ascii?Q?Ykkgia02txlm7dgblWunX/fkPsslB1rod5v2DBDgwwbrhPA9CF8jZh72O3Ov?=
 =?us-ascii?Q?G9koikX1gKsCiG4mBOvZliRFR0Jx77eTrq+zgVVWiBDX0W0TD1+R7+pNJ5ot?=
 =?us-ascii?Q?Ou0kCFd5zHZChR7fjUQfcxymuzuZQI9hABotddF10IpjtfmSQG6xJnxnZOGH?=
 =?us-ascii?Q?c5dCEZc2cre7d/RyTuPme1DvFeHmcxn+tQEvbvFCJMqSCuypjsweWGzgyGWw?=
 =?us-ascii?Q?2BVOjWxxWB1WJ5rDPKsB87EdpqB1Kd3gEHPnO3KyFUmGLjBUo3iTuM8NFGUu?=
 =?us-ascii?Q?F59RfenU0kvElvaWdOBSu/KrL1ETHimtBShgSvkWjExH3NdjVqDeszZ3ovEQ?=
 =?us-ascii?Q?oGIgic45+zUzqcd2P6ko5lHlEUbP2MASni7OUUm181LCiM0vbmR/i6QSnJEX?=
 =?us-ascii?Q?ZcYXT7Hx8moPOpvOoUqxwx8OL2tbNdE/WffUnYAXBl4onp6Vo+9XR252HlR6?=
 =?us-ascii?Q?MdBcluv1AG0gIYlu/wSyQUJmnnkICDsPwQHwaQo1?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cef8a73-7383-4906-8c12-08db88526460
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 12:19:25.7060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gwgSOklKX1mT7jpeoxQbtLqLIWiAzXuIO60vK6dEAeLZ57Hm/zrJM1sUAr4Gcgw9dwzjM6+vKuwzBF2wz6YABw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5359
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The comment in mmu_interval_read_begin() refers to a function that
doesn't exist and uses the wrong call-back name. The op for mmu
interval notifiers is mmu_interval_notifier_ops->invalidate() so fix
the comment up to reflect that.

Signed-off-by: Alistair Popple <apopple@nvidia.com>
---
 mm/mmu_notifier.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 50c0dde..b7ad155 100644
--- a/mm/mmu_notifier.c
+++ b/mm/mmu_notifier.c
@@ -199,7 +199,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub)
 	 * invalidate_start/end and is colliding.
 	 *
 	 * The locking looks broadly like this:
-	 *   mn_tree_invalidate_start():          mmu_interval_read_begin():
+	 *   mn_itree_inv_start():                 mmu_interval_read_begin():
 	 *                                         spin_lock
 	 *                                          seq = READ_ONCE(interval_sub->invalidate_seq);
 	 *                                          seq == subs->invalidate_seq
@@ -207,7 +207,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub)
 	 *    spin_lock
 	 *     seq = ++subscriptions->invalidate_seq
 	 *    spin_unlock
-	 *     op->invalidate_range():
+	 *     op->invalidate():
 	 *       user_lock
 	 *        mmu_interval_set_seq()
 	 *         interval_sub->invalidate_seq = seq
-- 
git-series 0.9.1