Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230712091241.3668454-1-Naresh.Solanki@9elements.com> <c1988d23-c19c-0ec0-9f61-01cbb00ead3a@molgen.mpg.de>
In-Reply-To: <c1988d23-c19c-0ec0-9f61-01cbb00ead3a@molgen.mpg.de>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Wed, 19 Jul 2023 17:47:41 +0530
Message-ID: <CABqG17i9T5e7Foy7L1D=OdPo8uHfQ2xfvEPmxLB6hQY42Yq3Xw@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] peci: cpu: Add Intel Sapphire Rapids support
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
        iwona.winiarska@intel.com, linux@roeck-us.net, jdelvare@suse.com,
        openbmc@lists.ozlabs.org,
        Patrick Rudolph <patrick.rudolph@9elements.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Paul,

On Wed, 19 Jul 2023 at 16:50, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Naresh,
>
>
> Thank you for the patch.
>
> Am 12.07.23 um 11:12 schrieb Naresh Solanki:
> > Add support for detection of Intel Sapphire Rapids processor based on
> > CPU family & model.
> >
> > Sapphire Rapids Xeon processors with the family set to 6 and the
> > model set to INTEL_FAM6_SAPPHIRERAPIDS_X. The data field for this entry
> > is "spr".
>
> Please add, how you tested this.
Yeah, sure. Missed adding that. Will update the same in next revision.
>
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> > ---
> > Changes in V2:
> > - Refactored from previous patchset as seperate patch based on subsyste=
m.
> > ---
> >   drivers/peci/cpu.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
> > index de4a7b3e5966..3668a908d259 100644
> > --- a/drivers/peci/cpu.c
> > +++ b/drivers/peci/cpu.c
> > @@ -318,6 +318,11 @@ static const struct peci_device_id peci_cpu_device=
_ids[] =3D {
> >               .model  =3D INTEL_FAM6_ICELAKE_X,
> >               .data   =3D "icx",
> >       },
> > +     { /* Sapphire Rapids Xeon */
> > +             .family =3D 6,
> > +             .model  =3D INTEL_FAM6_SAPPHIRERAPIDS_X,
> > +             .data   =3D "spr",
> > +     },
> >       { /* Icelake Xeon D */
> >               .family =3D 6,
> >               .model  =3D INTEL_FAM6_ICELAKE_D,
>
> It looks like it=E2=80=99s incorrectly sorted, probably due to merge conf=
lict
> resolution?
Will move it to after Xeon D in next revision.

Thanks,
Naresh
>
>
> Kind regards,
>
> Paul