Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758308AbXJZEPq (ORCPT ); Fri, 26 Oct 2007 00:15:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750778AbXJZEPj (ORCPT ); Fri, 26 Oct 2007 00:15:39 -0400 Received: from terminus.zytor.com ([198.137.202.10]:48510 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbXJZEPi (ORCPT ); Fri, 26 Oct 2007 00:15:38 -0400 Message-ID: <47216905.2030207@zytor.com> Date: Thu, 25 Oct 2007 21:11:49 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: "Huang, Ying" CC: Thomas Gleixner , Andrew Morton , Ingo Molnar , Andi Kleen , "Eric W. Biederman" , Chandramouli Narayanan , LKML , Arjan van de Ven Subject: Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support References: <1193295473.23935.202.camel@caritas-dev.intel.com> <1193369792.23935.283.camel@caritas-dev.intel.com> In-Reply-To: <1193369792.23935.283.camel@caritas-dev.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 15 Huang, Ying wrote: > > - 3 files: efi.c, efi_32.c, efi_64.c, common code goes in efi.c, EFI > 32/64 specific code goes in efi_32/64.c. This will make some variable, > function external instead of static. > This is preferred. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/