Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230719114101.55051-1-brgl@bgdev.pl>
In-Reply-To: <20230719114101.55051-1-brgl@bgdev.pl>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 19 Jul 2023 16:02:39 +0300
Message-ID: <CAHp75VfdCsAE8dGfTe2PsT5kxvoT84nChNptwgaA4Q5jf5oJvQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: mvebu: fix irq domain leak
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>, linux-pwm@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 19, 2023 at 2:41=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.pl>=
 wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Uwe Kleine-K=C3=B6nig pointed out we still have one resource leak in the =
mvebu
> driver triggered on driver detach. Let's address it with a custom devm
> action.

One nit-pick below, in either case
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Fixes: 812d47889a8e ("gpio/mvebu: Use irq_domain_add_linear")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/gpio/gpio-mvebu.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index a35958e7adf6..67497116ce27 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -1112,6 +1112,13 @@ static int mvebu_gpio_probe_syscon(struct platform=
_device *pdev,
>         return 0;
>  }
>
> +static void mvebu_gpio_remove_irq_domain(void *data)
> +{
> +       struct irq_domain *domain =3D data;
> +
> +       irq_domain_remove(domain);

The from/to void * doesn't need an explicit casting in C. This can be
a one liner

static void mvebu_gpio_remove_irq_domain(void *domain)
{
      irq_domain_remove(domain);
}

> +}
> +
>  static int mvebu_gpio_probe(struct platform_device *pdev)
>  {
>         struct mvebu_gpio_chip *mvchip;
> @@ -1246,13 +1253,18 @@ static int mvebu_gpio_probe(struct platform_devic=
e *pdev)
>                 return -ENODEV;
>         }
>
> +       err =3D devm_add_action_or_reset(&pdev->dev, mvebu_gpio_remove_ir=
q_domain,
> +                                      mvchip->domain);
> +       if (err)
> +               return err;
> +
>         err =3D irq_alloc_domain_generic_chips(
>             mvchip->domain, ngpios, 2, np->name, handle_level_irq,
>             IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_LEVEL, 0, 0);
>         if (err) {
>                 dev_err(&pdev->dev, "couldn't allocate irq chips %s (DT).=
\n",
>                         mvchip->chip.label);
> -               goto err_domain;
> +               return err;
>         }
>
>         /*
> @@ -1292,10 +1304,6 @@ static int mvebu_gpio_probe(struct platform_device=
 *pdev)
>         }
>
>         return 0;
> -
> -err_domain:
> -       irq_domain_remove(mvchip->domain);
> -       return err;
>  }


--=20
With Best Regards,
Andy Shevchenko