Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff2b6098-17fa-1a99-137e-c4f7c7176f10@linaro.org>
Date:   Wed, 19 Jul 2023 16:03:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] media: venus: Fix firmware path for sm8250
Content-Language: en-GB
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Patrick Whewell <patrick.whewell@sightlineapplications.com>
Cc:     William Gray <william.gray@linaro.org>,
        Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
        Vikash Garodia <quic_vgarodia@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230711185330.10106-1-patrick.whewell@sightlineapplications.com>
 <2abbae30-f92e-33e4-5509-8979129da665@linaro.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <2abbae30-f92e-33e4-5509-8979129da665@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/07/2023 12:50, Bryan O'Donoghue wrote:
> On 11/07/2023 19:53, Patrick Whewell wrote:
>> The firmware path for the sm8250 resources is incorrect. This fixes the
>> path to address the firmware correctly.
>>
>> Signed-off-by: Patrick Whewell 
>> <patrick.whewell@sightlineapplications.com>
>> ---
>>   drivers/media/platform/qcom/venus/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/venus/core.c 
>> b/drivers/media/platform/qcom/venus/core.c
>> index 2ae867cb4c48..348085f8fc9c 100644
>> --- a/drivers/media/platform/qcom/venus/core.c
>> +++ b/drivers/media/platform/qcom/venus/core.c
>> @@ -814,7 +814,7 @@ static const struct venus_resources sm8250_res = {
>>       .vmem_size = 0,
>>       .vmem_addr = 0,
>>       .dma_mask = 0xe0000000 - 1,
>> -    .fwname = "qcom/vpu-1.0/venus.mdt",
>> +    .fwname = "qcom/vpu-1.0/venus.mbn",
>>   };
>>   static const struct freq_tbl sc7280_freq_table[] = {
> 
> Is the policy not to stick with .mdt for existing platforms but use .mbn 
> for new platforms.

This was slightly different for venus, where it was suggested to use 
.mdt for all the platforms. However last year when Chrome team was 
updating sc7280/sc7180 Venus firmware, Rob Clark and yours truly have 
persuaded them to (finally) switch to .mbn and provide compatibility 
.mdt symlinks.

Then we have similarly converted all the rest of the venus firmware files.

See:

https://lore.kernel.org/linux-arm-msm/CANHAJhG-aoOBgTzirGu-1uqCFUJd+AnenMSkoUqnG3mhraCRfw@mail.gmail.com/t/#u

https://lore.kernel.org/linux-arm-msm/CANHAJhEWXf8U-FJJbOUpRV1gCXsd++H8kzbiBP1Z7iryaOCoYQ@mail.gmail.com/t/#u

> 
> https://lore.kernel.org/all/CALAqxLU1gjTY95+phBt=WksyguZuKpNKa6aYaJTe0GeCAg6WrA@mail.gmail.com/T/
> 
> Its a symlink for me but, is it a symlink for everybody ?
> 
> root@linaro-gnome:~# ls /lib/firmware/qcom/vpu-1.0/ -l
> lrwxrwxrwx 1 root root       9 Dec  2  2022 venus.mdt -> venus.mbn

Yes, it is a symlink for everybody:

$ grep Link.*qcom.v linux-firmware/WHENCE
Link: qcom/venus-1.8/venus.mdt -> venus.mbn
Link: qcom/venus-4.2/venus.mdt -> venus.mbn
Link: qcom/venus-5.2/venus.mdt -> venus.mbn
Link: qcom/venus-5.4/venus.mdt -> venus.mbn
Link: qcom/vpu-1.0/venus.mdt -> venus.mbn

So, long story short, I think this patch makes sense (and we should 
update other entries in this file too).

Patrick, maybe you can do it as well?

-- 
With best wishes
Dmitry