Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8214417rwp; Wed, 19 Jul 2023 06:55:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlH77onOMl2PcgEsJk7vwfuULxST8u+RPbS/lmK9SwNrDez9hEYAe4dWqO67aPHsOavxiZYG X-Received: by 2002:a17:90a:16c9:b0:263:5c6a:1956 with SMTP id y9-20020a17090a16c900b002635c6a1956mr1805887pje.25.1689774946546; Wed, 19 Jul 2023 06:55:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689774946; cv=none; d=google.com; s=arc-20160816; b=nPfcBALsjEFmztEaQVBIUP2stWdQatFwMMuQAPXUwVXWvDKhFoA9q8rrtJ6ZEb11jg IPv+R8xcnzfZ6wSgGlGOpqa/FRFfIMXJqqbmmqxAglmbIrGZ9ihikHqtqYQsQbBd0/ZE YzvFCq09J97fKn0gN+vwyS5tglIkLu4/tfz+B2JTdC8kNyNTbdobXXgnb/G93YkdORnW /Dj3Usiqtx+xaazgXHzjmimmv38Sd6Xf5688+5RE4M7LywagK1+LUQ74VkNX6U6Tk5ma 1EK55qrE9B7vlgcNOqirI6gkAXGB1cXyVH3elrnVlDgzUI+pNseGwt2THA9sLbRRSD0s tnpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:to:from:subject:cc :message-id:date:content-transfer-encoding:mime-version :dkim-signature; bh=G8TAD6Msm31xfw2I6Ike7pT5Jie2K2DojfPgBuPefWM=; fh=AV9nCEKj5/35oS+5kU9eTAJHKU9rp7xDGhJ1ZZz3+2w=; b=Js7R/tJP8aZYzb42iiHemNNwDSXayzCjm1G33UdfbPJR5qAgq5i/wEGMzi/ctQG6ic /ThLu1NscJb1ET6kIKkHm07ErEJ6tuI5nX5K1YoeIQE1KgiO5hjg8KI6gbzrPz89AP24 thbC+o3Hp69xlMheo3lVe/ZDCqI+nRxkfIy7sDGPL2C0L6hEKUqiM52sgvhptRX16RAe 9dJe+syYaKHPVD/PxmlogHbLudxxknPnW+poACXnKamacd5FXe97WgjhA7WKEE1p8Z6X 5l+6nqayBHDs+9tToFjQDxpR0fT3vBwZLoro1LoBpC3LnaRocNmxtC09Uy9zUrJplbVv PtMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gaqxW45k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi12-20020a17090b1e4c00b00262ef440ed4si1515228pjb.27.2023.07.19.06.55.34; Wed, 19 Jul 2023 06:55:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gaqxW45k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231415AbjGSNjn (ORCPT + 99 others); Wed, 19 Jul 2023 09:39:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbjGSNjm (ORCPT ); Wed, 19 Jul 2023 09:39:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B91B811C; Wed, 19 Jul 2023 06:39:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 432BB61638; Wed, 19 Jul 2023 13:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 507F6C433C8; Wed, 19 Jul 2023 13:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689773980; bh=KIb7q+NtNE+KBfEiNJ0Q3nOHxWMm45lA4WVZ9SwBWF8=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=gaqxW45kGtoKFnDNNv629brjH/mey+u1zrY+JTYF+Xct1aygG1J4Cf6N5TAdbyf95 2UQ3DpMsJY9gZ/ErtakGGWIqjwaqOwsKcm2y3YVSYVrxM+2RWzCuF6bzEjT83PpAcr AGyWDI+pJBXz2XJ1m2wYil5ZnC85al8khQ/W4g+oUVReQT1yoreruC76NRb0RMublg +no2nvv+RqXbaCJv3KQVstHdVnFLcEEYeY1VCIjZ704OwGCykRUyhgj3tGnEgItJBD Kzs/75HMkiwCdVcTz9jVBoTVjf+xmRrTVbvZXW9OTzSwRub4koHl/Aq6fKSbtpIb+H H1gh8r1VAddMg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 19 Jul 2023 16:39:23 +0300 Message-Id: Cc: , , , , , , , , , , , "Chao Peng" , "Fuad Tabba" , "Yu Zhang" , "Vishal Annapurve" , "Ackerley Tng" , "Maciej Szmigiero" , "Vlastimil Babka" , "David Hildenbrand" , "Quentin Perret" , "Michael Roth" , "Wang" , "Liam Merwick" , "Isaku Yamahata" , "Kirill A . Shutemov" Subject: Re: [RFC PATCH v11 01/29] KVM: Wrap kvm_gfn_range.pte in a per-action union From: "Jarkko Sakkinen" To: "Sean Christopherson" , "Paolo Bonzini" , "Marc Zyngier" , "Oliver Upton" , "Huacai Chen" , "Michael Ellerman" , "Anup Patel" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Matthew Wilcox (Oracle)" , "Andrew Morton" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" X-Mailer: aerc 0.14.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-2-seanjc@google.com> In-Reply-To: <20230718234512.1690985-2-seanjc@google.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed Jul 19, 2023 at 2:44 AM EEST, Sean Christopherson wrote: > /* Huge pages aren't expected to be modified without first being zapped= . */ > - WARN_ON(pte_huge(range->pte) || range->start + 1 !=3D range->end); > + WARN_ON(pte_huge(range->arg.pte) || range->start + 1 !=3D range->end); Not familiar with this code. Just checking whether whether instead pr_{warn,err}() combined with return false would be a more graceful option? BR, Jarkko