Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 15:40:36 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Thierry Reding <thierry.reding@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>, linux-pwm@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpio: mvebu: fix irq domain leak
Message-ID: <20230719134036.w5lsqxcg6u3v3ynm@pengutronix.de>
References: <20230719114101.55051-1-brgl@bgdev.pl>
 <CAHp75VfdCsAE8dGfTe2PsT5kxvoT84nChNptwgaA4Q5jf5oJvQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ujodkpnhmenu4mny"
Content-Disposition: inline
In-Reply-To: <CAHp75VfdCsAE8dGfTe2PsT5kxvoT84nChNptwgaA4Q5jf5oJvQ@mail.gmail.com>
Precedence: bulk


--ujodkpnhmenu4mny
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 19, 2023 at 04:02:39PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 19, 2023 at 2:41=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.p=
l> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Uwe Kleine-K=C3=B6nig pointed out we still have one resource leak in th=
e mvebu
> > driver triggered on driver detach. Let's address it with a custom devm
> > action.
>=20
> One nit-pick below, in either case
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>=20
> > Fixes: 812d47889a8e ("gpio/mvebu: Use irq_domain_add_linear")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  drivers/gpio/gpio-mvebu.c | 18 +++++++++++++-----
> >  1 file changed, 13 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> > index a35958e7adf6..67497116ce27 100644
> > --- a/drivers/gpio/gpio-mvebu.c
> > +++ b/drivers/gpio/gpio-mvebu.c
> > @@ -1112,6 +1112,13 @@ static int mvebu_gpio_probe_syscon(struct platfo=
rm_device *pdev,
> >         return 0;
> >  }
> >
> > +static void mvebu_gpio_remove_irq_domain(void *data)
> > +{
> > +       struct irq_domain *domain =3D data;
> > +
> > +       irq_domain_remove(domain);
>=20
> The from/to void * doesn't need an explicit casting in C. This can be
> a one liner
>=20
> static void mvebu_gpio_remove_irq_domain(void *domain)
> {
>       irq_domain_remove(domain);
> }

I slightly prefer Bartosz's version, but wouldn't get sleepless nights
=66rom that one.

Reviewed-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

for whatever variant you pick.

Best regards and thanks for acting on my report,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--ujodkpnhmenu4mny
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmS359QACgkQj4D7WH0S
/k4e9Af8CqmHYpZTvAibrO7NUTwH5Wv9wPOjn08hjFMA9+EVEq0IZWC04rJdNXxK
Q9N+jeCJoAWVQNL73ZVUlIzK1CjcJnppEsn92O0G4b4PybMCQGqd+UPyR1naMW7d
ieNq857UHMYaUUBt1Y+yDNTahs5EsTXXV7uEmlgyHAQXzIGc+4KHzCSF9umSYxyq
foaTpnOe3llRQGh3TtZVDDsRdDy5HK/wbAwG0Hn9mgYKK0UOJ0P2dpxJncKl2Hgx
LlNUmXQ4SoF3PlEXBYc7pCSEHF62Qm0agQke4dQHP+af/cBk1QSQQT51UJAzBw3X
j81qfIKaAF02tBPKvuPlKdWXMNQaaQ==
=uUOV
-----END PGP SIGNATURE-----

--ujodkpnhmenu4mny--