Date: Thu, 25 Oct 2007 21:59:50 -0700
From: Greg KH <gregkh@suse.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [RFC] full suspend/resume support for i915 DRM driver
Message-ID: <20071026045950.GA22920@suse.de>
References: <200710181401.50470.jbarnes@virtuousgeek.org> <200710240818.31128.jbarnes@virtuousgeek.org> <200710242322.36291.rjw@sisk.pl> <200710251653.19978.jbarnes@virtuousgeek.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200710251653.19978.jbarnes@virtuousgeek.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1343
Lines: 31

On Thu, Oct 25, 2007 at 04:53:18PM -0700, Jesse Barnes wrote:
> Ok, here's yet another version that uses the device model for the
> suspend/resume, rather than pci hooks.
> 
> Greg, DRM desperately needs review of its device model usage, can you
> take a look at this patch and the current drm_sysfs.c code?  Right now,
> we're mixing class_devices and regular devices (the latter seem to be
> required for suspend/resume to work correctly), but this seems wrong.
> Any ideas?  Should we just rip out the class_device stuff and create
> full-on DRM device nodes?

The class_device stuff is already ripped out in the latest -mm trees and
I will be forwarding that change on for 2.6.25 after 2.6.24 is out.  So
yes, it should be taken away :)

But converting from class_device to struct device does not mean you use
a "device node".  But you could if you want to :)

Other than that, the driver model usage isn't the best, but I think the
majority of the major issues are fixed up now, especially with the
removal of class_device.  Is there anything specific you are curious
about?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/