Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 22:22:35 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        "Mel Gorman" <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Tim Chen <tim.c.chen@intel.com>,
        Nitin Tekchandani <nitin.tekchandani@intel.com>,
        Yu Chen <yu.c.chen@intel.com>,
        Waiman Long <longman@redhat.com>,
        <linux-kernel@vger.kernel.org>, <yury.norov@gmail.com>,
        <andriy.shevchenko@linux.intel.com>, <linux@rasmusvillemoes.dk>,
        <rppt@kernel.org>
Subject: Re: [RFC PATCH 2/4] sched/fair: Make tg->load_avg per node
Message-ID: <20230719142235.GA94215@ziqianlu-dell>
References: <20230718134120.81199-1-aaron.lu@intel.com>
 <20230718134120.81199-3-aaron.lu@intel.com>
 <20230719115358.GB3529734@hirez.programming.kicks-ass.net>
 <20230719134500.GB91858@ziqianlu-dell>
 <20230719135305.GC3529734@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230719135305.GC3529734@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lb9D98PKflKjJ0gTyukuBNUwHW2jb1yWlYrJbLP1RmZ9M8cMnMepCUB/GNuc?=
 =?us-ascii?Q?f39GLKl67HrKHDevf9HgFV86/u9UbnETnLqbUpb7myM+t0s4epvzezLt3DxK?=
 =?us-ascii?Q?M34JHckBPi0O5NOz5yhx0+MdsnDSa9/FhahJTY+zTGYKcU8X+ORdis/FBzng?=
 =?us-ascii?Q?1zfDsIj5lxc5t3xiWeHEnDQpQu/07Am4FnqXDKlDm72wZ39y18OLOFr7icIB?=
 =?us-ascii?Q?qjqoN72JD+PTcu7pgb0mrG5biWBI0u58FoMf1TA/p+tlU+VuTe/BC8AtZe3w?=
 =?us-ascii?Q?ddGx4Exod9v2NgO5DlobEfDjVpEkzBnjqcSKXHM1VGc+Kb8GIOD6YZrF5NM7?=
 =?us-ascii?Q?jVd3wxrom4C63OeHPmK5t6/dC049SBqnnBXIpvrPBDrf5yGYMa9h0LrdnWfF?=
 =?us-ascii?Q?PtTuc+41PsSbOOY+d4PWc3HcmxX0ZpLb3Qv6Gzmkp/nD12r2w+T8gp1TAylo?=
 =?us-ascii?Q?VceyRYl87tgO0qdIaoDpKNibP6gHy0mmxT0vYEY1q7/ilV/QERLUYMauHLbY?=
 =?us-ascii?Q?J6b2H2MYQA+KHbgPy+BH8j1ltpLsDXOvNlPmgpWX47rmcC8uI7KRpHnGTdqa?=
 =?us-ascii?Q?kQXIvjvMM+9/M081HXds9AWpFINn8f2Si3ypwjPhlb05ZyeXuUqzfLaU4T8z?=
 =?us-ascii?Q?UbarNGqwzMdkfUbE9MxqoUwauC11w7VNtT+8fRnqpkIu0iElnllzNJwFYaqt?=
 =?us-ascii?Q?1JIOGyytJ2uxXZHxSzc41x+6VVw8qyETcl6gb9POE1+WRPF7uXa7EiGDEaW4?=
 =?us-ascii?Q?/JDnUqtzoR8B3IaqshZ9Gm1G0mTyxCzpq126wyS933u09b7mcxokxx1mDjf8?=
 =?us-ascii?Q?zlDeyTG1paL/I+w7U91iDdiHTuNPefNvnZiyAaxlMusZHPGoeei9WSobMdb4?=
 =?us-ascii?Q?C8uaZM/o4+hIUk5LT5TSpwVulpIiOwFaVea0h3qpw2qF3rPJgcIjKhTinRNg?=
 =?us-ascii?Q?gw6KxoYQfGXZmud3ewBmysDegCktfuKEF8/51zVA07zqQ/qBKXMeP1E94PGS?=
 =?us-ascii?Q?SMVUjYEsdgzFM3E5LS0tA9KbGeZ2qqAdlTfP6X+cACnssW8AwyM1XuZk4I75?=
 =?us-ascii?Q?Jx8kRhduVck+dVET2eHyDAKvq0F8jXW4Lf1ywSwO95IIo05Wv1epLuLVos88?=
 =?us-ascii?Q?2RQdXDrQgPKR86UFXU52YdZWtRebsgyEkQjqaFJEcl1nKXIIEmhwE8aG8vGa?=
 =?us-ascii?Q?U2GtZk7+Og3e9a5WM09PBAt4B/22wU44Nso+SBKMeL5spmHteSv0P9LgVFzV?=
 =?us-ascii?Q?Z2myd3XDjndbYI43+EUXNy0quevueBhkewripP8YT+IwUhklfETuQdN3vl8S?=
 =?us-ascii?Q?UyjueTkMoTn/Vdj76Ot96GI0Yc4hAhpaBIScGFKEszMfy0pQ547P9OAD/7q9?=
 =?us-ascii?Q?Vc3AGfR9vxStCC8KAengeNoXuq68JefxnAm/mkl5sNKhQVc6OYDx3qniU7YW?=
 =?us-ascii?Q?t6tm2fzaYsqKGvtQXrlbt/iuDpJGtmuP6EEBNejS/Vn6+pULYVYScl4j3dmr?=
 =?us-ascii?Q?PD+qOLv+f099wZbZvdVJFNexGcWl76ruaY+tf0U1tJe3SULT5Thvdbez0Lc3?=
 =?us-ascii?Q?WlqE5AfGyjRVrsESeHx/iJ8kMpKjR1XTL8QRrf78?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dee805bc-bc9c-4bfb-4471-08db8863a457
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3060.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 14:22:54.4795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zCAM/JbXliqwlOAwRHmMKhJRM8M0p90CcMA4hKgiq7Ni03y/DF5oxjdEjtQ9AK6QiXTzIbwpq98IihuKogeljg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6823
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 19, 2023 at 03:53:05PM +0200, Peter Zijlstra wrote:
> On Wed, Jul 19, 2023 at 09:45:00PM +0800, Aaron Lu wrote:
> > I'll rebase this per-node patch on top of below diff.
> 
> Oh, please double check I didn't wreck anything. I skipped 'converting'
> the find_*_bit() functions because the users of those iterators might be
> expecting NR_MAXNODES when not found.
>

Sounds more work than I had expected :)

> But perhaps there's more I overlooked.

Got it, will see if I can make it work.