Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
Mime-Version: 1.0
Message-Id: <3b047cd4-a61f-44b6-830b-b4e35bfccd72@app.fastmail.com>
In-Reply-To: <32595080-dd79-5cf0-46e7-b82d0df8f067@linaro.org>
References: <20230719123944.3438363-1-arnd@kernel.org>
 <20230719123944.3438363-6-arnd@kernel.org>
 <32595080-dd79-5cf0-46e7-b82d0df8f067@linaro.org>
Date:   Wed, 19 Jul 2023 16:38:57 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     =?UTF-8?Q?Phil_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
        "Arnd Bergmann" <arnd@kernel.org>, linux-fbdev@vger.kernel.org,
        "Thomas Zimmermann" <tzimmermann@suse.de>,
        "Helge Deller" <deller@gmx.de>,
        "Javier Martinez Canillas" <javierm@redhat.com>
Cc:     linux-hyperv@vger.kernel.org, x86@kernel.org,
        linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
        "Max Filippov" <jcmvbkbc@gmail.com>,
        "Will Deacon" <will@kernel.org>, linux-efi@vger.kernel.org,
        guoren <guoren@kernel.org>,
        "linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
        sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
        "WANG Xuerui" <kernel@xen0n.name>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        "Dave Airlie" <airlied@gmail.com>,
        "Ard Biesheuvel" <ardb@kernel.org>, "Wei Liu" <wei.liu@kernel.org>,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "Dexuan Cui" <decui@microsoft.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Deepak Rawat" <drawat.floss@gmail.com>,
        "Ingo Molnar" <mingo@redhat.com>,
        "Matt Turner" <mattst88@gmail.com>,
        "Haiyang Zhang" <haiyangz@microsoft.com>,
        "Nicholas Piggin" <npiggin@gmail.com>,
        "Borislav Petkov" <bp@alien8.de>, loongarch@lists.linux.dev,
        "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        linux-arm-kernel@lists.infradead.org,
        "Khalid Aziz" <khalid@gonehiking.org>,
        "Brian Cain" <bcain@quicinc.com>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, "Dinh Nguyen" <dinguyen@kernel.org>,
        linux-riscv@lists.infradead.org,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Daniel Vetter" <daniel@ffwll.ch>, linux-alpha@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 5/9] vgacon: remove screen_info dependency
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 19, 2023, at 15:49, Philippe Mathieu-Daud=C3=A9 wrote:
> On 19/7/23 14:39, Arnd Bergmann wrote:

>> @@ -1074,13 +1077,13 @@ static int vgacon_resize(struct vc_data *c, u=
nsigned int width,
>>   		 * Ho ho!  Someone (svgatextmode, eh?) may have reprogrammed
>>   		 * the video mode!  Set the new defaults then and go away.
>>   		 */
>> -		screen_info.orig_video_cols =3D width;
>> -		screen_info.orig_video_lines =3D height;
>> +		vga_si->orig_video_cols =3D width;
>> +		vga_si->orig_video_lines =3D height;
>>   		vga_default_font_height =3D c->vc_cell_height;
>>   		return 0;
>>   	}
>> -	if (width % 2 || width > screen_info.orig_video_cols ||
>> -	    height > (screen_info.orig_video_lines * vga_default_font_heigh=
t)/
>> +	if (width % 2 || width > vga_si->orig_video_cols ||
>> +	    height > (vga_si->orig_video_lines * vga_default_font_height)/
>>   	    c->vc_cell_height)
>>   		return -EINVAL;
>>  =20
>> @@ -1110,8 +1113,8 @@ static void vgacon_save_screen(struct vc_data *=
c)
>>   		 * console initialization routines.
>>   		 */
>>   		vga_bootup_console =3D 1;
>> -		c->state.x =3D screen_info.orig_x;
>> -		c->state.y =3D screen_info.orig_y;
>> +		c->state.x =3D vga_si->orig_x;
>> +		c->state.y =3D vga_si->orig_y;
>
> Not really my area, so bare with me if this is obviously not
> possible :) If using DUMMY_CONSOLE, can we trigger a save_screen
> / resize? If so, we'd reach here with vga_si=3DNULL.
>

I think it cannot happen because the only way that anything calls
into vgacon.c is through the "conswitchp =3D &vga_con;" that now happens
at the same time as the "vga_si =3D &screen_info;". It's definitely
possible that I'm missing something as well here.

     Arnd