Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77417a3a-597f-b503-acc0-9c6afcaac511@linux.dev>
Date:   Wed, 19 Jul 2023 22:53:40 +0800
MIME-Version: 1.0
Subject: Re: [PATCH] arm64/cpufeature: Use ARM64_CPUID_FIELD() to match EVT
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230718-arm64-evt-cpuid-helper-v1-1-68375d1e6b92@kernel.org>
From:   Zenghui Yu <zenghui.yu@linux.dev>
In-Reply-To: <20230718-arm64-evt-cpuid-helper-v1-1-68375d1e6b92@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/19 03:45, Mark Brown wrote:
> The recently added Enhanced Virtualization Traps cpufeature does not use
> the ARM64_CPUID_FIELDS() helper, convert it to do so. No functional
> change.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/kernel/cpufeature.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f9d456fe132d..bcb006390e55 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2708,12 +2708,8 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
>  		.desc = "Enhanced Virtualization Traps",
>  		.capability = ARM64_HAS_EVT,
>  		.type = ARM64_CPUCAP_SYSTEM_FEATURE,
> -		.sys_reg = SYS_ID_AA64MMFR2_EL1,
> -		.sign = FTR_UNSIGNED,
> -		.field_pos = ID_AA64MMFR2_EL1_EVT_SHIFT,
> -		.field_width = 4,
> -		.min_field_value = ID_AA64MMFR2_EL1_EVT_IMP,
>  		.matches = has_cpuid_feature,
> +		ARM64_CPUID_FIELDS(ID_AA64MMFR2_EL1, EVT, IMP)
>  	},
>  	{},
>  };

Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>