Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8351187rwp; Wed, 19 Jul 2023 08:38:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEbN1ygcN5Rhxq1DkYer3y1CsDjymMnPSTuanAf9Os+loFV2N0YZJGh7jp1PlI3QYnarm4h X-Received: by 2002:a05:6a20:54a7:b0:135:6ef6:171 with SMTP id i39-20020a056a2054a700b001356ef60171mr3626871pzk.39.1689781082512; Wed, 19 Jul 2023 08:38:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689781082; cv=none; d=google.com; s=arc-20160816; b=EUDOabGU3/R10UKq87B6vKtt4QsFoMJbO7BNOFS3oj3MXtrKhK1iQ6bSiqkKvkkSy8 GahxTQJ726tXwpNx/XzAyxg06q8bc5ptxnJzc7SAT6YqgVT9pEgWZTKLqOjJFNUbcszT n7jIJpCA/1PRisgiyOVSWzDWMOQyIPrK+12jIOnEkQYBxw6p7BTk7O5OeJ0pG1aoL38o aLJSGL6C/Hgt4oAQk13RMBJl6pPPnxtBv1aOkZKyNuU8By3OseDyyBvZTNSyuCifCQ1W T8teAt1wrbuRTOxNlfq/Ic9dXbVhosksw5T/NCYcwdftITKW7X8EUhMjz2ZjMYgtxOZr WEAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=kMVMrhx/FjYUJw0vZgrOI9LRMUrCIFLHaEfkk8MLseo=; fh=Z7z4FIZEbLpPM7Zj3Hn3kMBERHH2Dov3urUQ5ZIZntE=; b=eMKwpUd8b5YutAWVbyBA76i9rsBYP+iRUfJjRsDsGwld132nhS/Uh02bZdeTVCGq2a 7FTx3QwoS7wSc/Wai1SGkMtX/UyWvz95RWwM7N2Sx6lPqQiiGQ1wMwaGiK48/g9EwGhB XrnamoW5nKkCuL7qfG/hmvnml63G4BHSE5iwHR94fxsIfsd01jsdlEivaq96OykHeSHA SZoR5bg4AH+PrT5qbVzirA2oc+MpBTJTNEOd7l8ArE+oGej04crH3qd1pLWTm3mn9avx 36+XdNoAnb5zoIh4+CEzjbIN4Z5X9aMTwk4tmNbQOtFVsnkENu4To2R4WisbuQhP08Sh W+eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q28-20020a638c5c000000b0055380fbd9e1si3571470pgn.483.2023.07.19.08.37.49; Wed, 19 Jul 2023 08:38:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbjGSP36 (ORCPT + 99 others); Wed, 19 Jul 2023 11:29:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbjGSP34 (ORCPT ); Wed, 19 Jul 2023 11:29:56 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 64A96CC; Wed, 19 Jul 2023 08:29:55 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E4BF2F4; Wed, 19 Jul 2023 08:30:38 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 214B53F6C4; Wed, 19 Jul 2023 08:29:54 -0700 (PDT) Date: Wed, 19 Jul 2023 16:29:47 +0100 From: Cristian Marussi To: Krzysztof Kozlowski Cc: Sudeep Holla , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] firmware: arm_scmi: drop OF node reference in setup Message-ID: References: <20230719061652.8850-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719061652.8850-1-krzysztof.kozlowski@linaro.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2023 at 08:16:52AM +0200, Krzysztof Kozlowski wrote: > The OF node reference obtained from of_parse_phandle() should be dropped > if node is not compatible with arm,scmi-shmem. > > Fixes: 507cd4d2c5eb ("firmware: arm_scmi: Add compatibility checks for shmem node") > Cc: > Signed-off-by: Krzysztof Kozlowski > > --- > LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian