Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8375209rwp; Wed, 19 Jul 2023 08:58:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlFaxwncy2de5nYsgxiXrV9vdAYCK7U8ya/uv1GNa8KNx2Ocw6ROXdXt2c2VPc4E95Bq7L8G X-Received: by 2002:a17:903:110c:b0:1b8:a3e8:51d0 with SMTP id n12-20020a170903110c00b001b8a3e851d0mr1846038plh.45.1689782337841; Wed, 19 Jul 2023 08:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689782337; cv=none; d=google.com; s=arc-20160816; b=ws+qIAq3KbT3xCbAgAR2RvAzbu59KyHr+ggRoTmdHkzcc2Nq1zsu+p3nJtuzT+fsKg FjFTAOMP7UdixrjdbqJQNs5xVPwzkEsEFvdCNHuF+rg2isOiFpocsgByaG/in0BGwlhN QYouwmcoL0pyWN3BQPTYc+5D0wY99F48BN6UX8T+GX0EooLX9LhxQ3mKghFpjqNDvzUU VaUH2HA5lZAYDzrnl/o+TuazTmjcP3y2r5OlzSOMsv2NGPmrlEf4L15o7pzALGalH3so tu3uh+Nuql7tmkjFzYdtbzcQm86f4r1AAzl/NXSHVFRuSY/QYutHxCIcfrWem5VUcxUJ DS5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4BWN8ZvyEmnW0/QQJqKmkyQAUyaoQfIzj3XSQBtp+Bc=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=irsuPfsYsPyc0vMDWjhozTSU/6DOwW2BIQVqD2pLZmxQwJ4qccInUODSz0md6mmRxw N6E+QdCXIUvHwENf4Hqyr6o7USy2pZ0w1DbkEoBotCUc/xf6SQo5Xr9JGBizdD7hLqDJ v5mClSGtS0wjXTJ6J7coNV7vCqVg8U01P+PtJaDueLGy1os6xBeYJNYDa3489djF954d dL43tg6NBmue73w/AtqyGic+Ah7brjATKPElQLu9ZuVBPzTX5SDFqgZs9foll2eUvulv msoyAVauJVoTqBlPsRVzCRAuVjzHkhQrjSrlpTcqERXVI252lMSI/5/WLlEys9oljnJF QUBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lm16-20020a170903299000b001bb2093efb6si3732035plb.45.2023.07.19.08.58.44; Wed, 19 Jul 2023 08:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231725AbjGSPa5 (ORCPT + 99 others); Wed, 19 Jul 2023 11:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbjGSPa4 (ORCPT ); Wed, 19 Jul 2023 11:30:56 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBCA9E; Wed, 19 Jul 2023 08:30:55 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="346800912" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="346800912" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 08:30:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="727338892" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="727338892" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2023 08:30:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qM98W-00GGtl-0c; Wed, 19 Jul 2023 18:30:44 +0300 Date: Wed, 19 Jul 2023 18:30:43 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Message-ID: References: <20230719094803.17677-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719094803.17677-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2023 at 12:48:03PM +0300, Andrei Coardos wrote: > The platform_set_drvdata() isn't needed for anything. The function is a > simple setter that doesn't change anything in the code. That is because > there isn't a get function and since it has no dependencies it can be > removed. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko