Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8416249rwp; Wed, 19 Jul 2023 09:27:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlGBv4i5laOK84wQ0shS9532qGwSfk1qtMvSby0F91w7hpk/F/NtuYjbHHSwqRQFcaVh1qob X-Received: by 2002:a05:6512:2507:b0:4f8:46e9:9f19 with SMTP id be7-20020a056512250700b004f846e99f19mr398500lfb.1.1689784057064; Wed, 19 Jul 2023 09:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689784057; cv=none; d=google.com; s=arc-20160816; b=RNCSgtKDsTp3z+gLE1K/GheZy8VxUJFfNULayShg4MvL3p3MxWVpX8Jq8PZOwSuxQZ hy3cRUVgLVHvgDqOqamPAM8xQ5UTpg0ma8Vjm4DnfDSOrKkFKTyB+vPIMx3MMrKoUNt2 sdBUGSb2gJCQHFVvzNyi4NGJp7gxyAs/uA0tulH7Gki6qgSc/Ejbsuow8e3CV0MycEva VThXogRDS7QF0gT1UGXXkJxBTYNNCRgaou3W33gaRTKHkx5PYiwtN08iGzQ426/c92AV ORQMDtuCHaliEBH1jApRTk90qexcUqoZANifZYv9SAFDWBX1Qk+R54fZ0uLNL3Pl5uUj FIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jHmRjiOnuLh83e7gEQgBoaJ/Btb+HmGS7wWdBg8M6OA=; fh=+loLtEpGud53rChJCHgQm51N/6SRTsrBArK0sXI84eE=; b=JymAM0hstMm4cNTbvdpTGtp3ybAClVgmHgJkIXYWw3joIay49CwpLLdM15tB3HIZHd Q9H+ifCfq9YtLBMSm1VLHFsj7amOD21P5lQ5+GJYu9nyDeZPCqYVFv3KgeUhnFHaVGkH T6h+H5R4PXKFhzMdiF7OwRe1vIDk1krnSB1shPggMRRfAM1HlhCyptvkKc3i4qgPqDTx 7UoD2LjD4ynEYOPRO4TULOJRthvJJJALdo2RXGVwjoylLZVkg/6p2UMegF42W1OVEFhC 0uj6BlB0d42jXQ5FzyzeMpShYwiJ09ESW6pXOTuw5LxekN09DJ00yJ84is5v9XhORbAv E4/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Hk4FhDe1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z20-20020aa7d414000000b005149e1735bcsi3369568edq.33.2023.07.19.09.27.09; Wed, 19 Jul 2023 09:27:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Hk4FhDe1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbjGSPkN (ORCPT + 99 others); Wed, 19 Jul 2023 11:40:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbjGSPkL (ORCPT ); Wed, 19 Jul 2023 11:40:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B70DE47; Wed, 19 Jul 2023 08:40:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8EDFF61764; Wed, 19 Jul 2023 15:40:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20B56C433C7; Wed, 19 Jul 2023 15:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689781201; bh=zY5bS398x+p4X13200NMBqcTChbgpAxmHByrPgj4TII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hk4FhDe1b3I2vPMzMxGNqcd5gx6PRmoCsmsj7FAgkGbQc1cP2TeUs+21DCch8bcZh cW39BpMidA8vwqa0rXcNW/QhR7usOy21e++7GphbRvFDnKdTQLxxC41SuiGOqOxj9L /QNZJ0TlqJHbyZzVsMj8ef1xZLT8oE7w2LQFJUSQ= Date: Wed, 19 Jul 2023 17:39:58 +0200 From: Greg KH To: Eric Van Hensbergen Cc: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel Subject: Re: [PATCH v3 1/4] fs/9p: remove unnecessary and overrestrictive check Message-ID: <2023071940-aground-kilometer-ab18@gregkh> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> <20230716-fixes-overly-restrictive-mmap-v3-1-769791f474fd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-1-769791f474fd@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2023 at 03:17:05PM +0000, Eric Van Hensbergen wrote: > This eliminates a check for shared that was overrestrictive and > duplicated a check in generic_file_readonly_mmap. > > Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") > Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ > Reviewed-by: Dominique Martinet > Reviewed-by: Christian Schoenebeck > Signed-off-by: Eric Van Hensbergen > --- > fs/9p/vfs_file.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.