Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230607170724.2016988-1-tharvey@gateworks.com>
 <20230607170724.2016988-2-tharvey@gateworks.com> <20230717002717.GI9559@dragon>
 <CAJ+vNU2Wn0jf8QyZsGiw3f=XThZEfXajhGJTmZz2mnJXgprAhQ@mail.gmail.com> <20230719015750.GR9559@dragon>
In-Reply-To: <20230719015750.GR9559@dragon>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Wed, 19 Jul 2023 09:20:14 -0700
Message-ID: <CAJ+vNU0fvi5hD40PPEa_hQjZoDb0yzxJf=5+B=R2GZoRcs2GeA@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw71xx-2x
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 18, 2023 at 6:58=E2=80=AFPM Shawn Guo <shawnguo@kernel.org> wro=
te:
>
> On Tue, Jul 18, 2023 at 02:16:22PM -0700, Tim Harvey wrote:
> > On Sun, Jul 16, 2023 at 5:27=E2=80=AFPM Shawn Guo <shawnguo@kernel.org>=
 wrote:
> > >
> > > On Wed, Jun 07, 2023 at 10:07:24AM -0700, Tim Harvey wrote:
> > > > The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard=
.
> > > >
> > > > The GW702x SOM contains the following:
> > > >  - i.MX8M Plus SoC
> > > >  - LPDDR4 memory
> > > >  - eMMC Boot device
> > > >  - Gateworks System Controller (GSC) with integrated EEPROM, button
> > > >    controller, and ADC's
> > > >  - PMIC
> > > >  - SOM connector providing:
> > > >   - eQoS GbE MII
> > > >   - 1x SPI
> > > >   - 2x I2C
> > > >   - 4x UART
> > > >   - 2x USB 3.0
> > > >   - 1x PCI
> > > >   - 1x SDIO (4-bit 3.3V)
> > > >   - 1x SDIO (4-bit 3.3V/1.8V)
> > > >   - GPIO
> > > >
> > > > The GW71xx Baseboard contains the following:
> > > >  - GPS
> > > >  - RJ45 GbE (eQoS)
> > > >  - off-board I/O connector with UART, I2C, SPI, GPIO
> > > >  - EERPOM
> > > >  - PCIe clock generator
> > > >  - full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0
> > > >  - USB Type-C with USB 2.0 host and peripheral support
> > > >  - Wide range DC input supply
> > > >
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/Makefile        |   1 +
> > > >  .../dts/freescale/imx8mp-venice-gw71xx-2x.dts |  19 ++
> > > >  .../dts/freescale/imx8mp-venice-gw71xx.dtsi   | 236 ++++++++++++++=
++++
> > > >  3 files changed, 256 insertions(+)
> > > >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw7=
1xx-2x.dts
> > > >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw7=
1xx.dtsi
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/bo=
ot/dts/freescale/Makefile
> > > > index 62f22b77b38b..b3bb823d0168 100644
> > > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-icore-mx8mp-=
edimm2.2.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-msc-sm2s-ep1.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-phyboard-pollux-rdk.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-tqma8mpql-mba8mpxl.dtb
> > > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-venice-gw71xx-2x.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-venice-gw74xx.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-venice-gw7905-2x.dtb
> > > >  dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-verdin-nonwifi-dahlia.dtb
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.=
dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts
> > > > new file mode 100644
> > > > index 000000000000..53120fc9cd7f
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts
> > > > @@ -0,0 +1,19 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright 2023 Gateworks Corporation
> > > > + */
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "imx8mp.dtsi"
> > > > +#include "imx8mp-venice-gw702x.dtsi"
> > > > +#include "imx8mp-venice-gw71xx.dtsi"
> > > > +
> > > > +/ {
> > > > +     model =3D "Gateworks Venice GW71xx-2x i.MX8MP Development Kit=
";
> > > > +     compatible =3D "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp";
> > > > +
> > > > +     chosen {
> > > > +             stdout-path =3D &uart2;
> > > > +     };
> > > > +};
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dts=
i b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi
> > > > new file mode 100644
> > > > index 000000000000..86999f52d4b2
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi
> > > > @@ -0,0 +1,236 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright 2023 Gateworks Corporation
> > > > + */
> > > > +
> > > > +#include <dt-bindings/gpio/gpio.h>
> > > > +#include <dt-bindings/leds/common.h>
> > > > +#include <dt-bindings/phy/phy-imx8-pcie.h>
> > > > +
> > > > +/ {
> > > > +     led-controller {
> > > > +             compatible =3D "gpio-leds";
> > > > +             pinctrl-names =3D "default";
> > > > +             pinctrl-0 =3D <&pinctrl_gpio_leds>;
> > > > +
> > > > +             led-0 {
> > > > +                     function =3D LED_FUNCTION_STATUS;
> > > > +                     color =3D <LED_COLOR_ID_GREEN>;
> > > > +                     gpios =3D <&gpio4 1 GPIO_ACTIVE_HIGH>;
> > > > +                     default-state =3D "on";
> > > > +                     linux,default-trigger =3D "heartbeat";
> > > > +             };
> > > > +
> > > > +             led-1 {
> > > > +                     function =3D LED_FUNCTION_STATUS;
> > > > +                     color =3D <LED_COLOR_ID_RED>;
> > > > +                     gpios =3D <&gpio4 5 GPIO_ACTIVE_HIGH>;
> > > > +                     default-state =3D "off";
> > > > +             };
> > > > +     };
> > > > +
> > > > +     pcie0_refclk: pcie0-refclk {
> > >
> > > Can we name the node clock-xxx?
> > >
> > > > +             compatible =3D "fixed-clock";
> > > > +             #clock-cells =3D <0>;
> > > > +             clock-frequency =3D <100000000>;
> > > > +     };
> > > > +
> > > > +     pps {
> > > > +             compatible =3D "pps-gpio";
> > > > +             pinctrl-names =3D "default";
> > > > +             pinctrl-0 =3D <&pinctrl_pps>;
> > > > +             gpios =3D <&gpio4 3 GPIO_ACTIVE_HIGH>;
> > > > +             status =3D "okay";
> > > > +     };
> > > > +};
> > > > +
> > > > +/* off-board header */
> > > > +&ecspi2 {
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_spi2>;
> > > > +     cs-gpios =3D <&gpio5 13 GPIO_ACTIVE_LOW>;
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +&gpio4 {
> > > > +     gpio-line-names =3D
> > > > +             "", "", "", "",
> > > > +             "", "", "", "",
> > > > +             "dio1", "", "", "dio0",
> > > > +             "", "", "pci_usb_sel", "",
> > > > +             "", "", "", "",
> > > > +             "", "", "", "",
> > > > +             "dio3", "", "dio2", "",
> > > > +             "pci_wdis#", "", "", "";
> > > > +};
> > > > +
> > > > +&i2c2 {
> > > > +     clock-frequency =3D <400000>;
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_i2c2>;
> > > > +     status =3D "okay";
> > > > +
> > > > +     accelerometer@19 {
> > > > +             pinctrl-names =3D "default";
> > > > +             pinctrl-0 =3D <&pinctrl_accel>;
> > > > +             compatible =3D "st,lis2de12";
> > > > +             reg =3D <0x19>;
> > >
> > > Can we start the property list from these two?
> > >
> > > > +             st,drdy-int-pin =3D <1>;
> > > > +             interrupt-parent =3D <&gpio4>;
> > > > +             interrupts =3D <21 IRQ_TYPE_LEVEL_LOW>;
> > > > +             interrupt-names =3D "INT1";
> > > > +     };
> > > > +};
> > > > +
> > > > +&pcie_phy {
> > > > +     fsl,refclk-pad-mode =3D <IMX8_PCIE_REFCLK_PAD_INPUT>;
> > > > +     fsl,clkreq-unsupported;
> > > > +     clocks =3D <&pcie0_refclk>;
> > > > +     clock-names =3D "ref";
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +&pcie {
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_pcie0>;
> > > > +     reset-gpio =3D <&gpio4 29 GPIO_ACTIVE_LOW>;
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +/* GPS */
> > > > +&uart1 {
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_uart1>;
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +/* off-board header */
> > > > +&uart3 {
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_uart3>;
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +/* USB1 Type-C front panel */
> > > > +&usb3_0 {
> > > > +     pinctrl-names =3D "default";
> > > > +     pinctrl-0 =3D <&pinctrl_usb1>;
> > > > +     fsl,over-current-active-low;
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +&usb3_phy0 {
> > > > +     status =3D "okay";
> > > > +};
> > > > +
> > > > +&usb_dwc3_0 {
> > > > +     /* dual role is implemented but not a full featured OTG */
> > > > +     adp-disable;
> > > > +     hnp-disable;
> > > > +     srp-disable;
> > > > +     dr_mode =3D "otg";
> > > > +     usb-role-switch;
> > > > +     role-switch-default-mode =3D "peripheral";
> > > > +     status =3D "okay";
> > > > +
> > > > +     connector {
> > > > +             pinctrl-names =3D "default";
> > > > +             pinctrl-0 =3D <&pinctrl_usbcon1>;
> > > > +             compatible =3D "gpio-usb-b-connector", "usb-b-connect=
or";
> > >
> > > Start the properties from 'compatible'?
> > >
> > > Shawn
> > >
> >
> > Hi Shawn,
> >
> > My notes say that pinctrl should come first (if needed) followed by
> > compatible, reg, other props, and finally status (if needed). Assuming
> > I'm wrong about that where in the list should pinctrl be and is this
> > documented anywhere for future reference?
>
> It's more a recommended idiom than documented/hard rule.
>
> - compatible
> - reg
> - general properties
> - vendor specific properties
> - status
>

ok, thank you for the clarification.

I will submit a new version of:
arm64: dts: freescale: Add imx8mp-venice-gw73xx-2x
arm64: dts: freescale: Add imx8mp-venice-gw72xx-2x
arm64: dts: freescale: Add imx8mp-venice-gw71xx-2x
arm64: dts: freescale: Add imx8mm-venice-gw7905-0x

best regards,

Tim