Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 18:08:18 +0100
From:   Mark Brown <broonie@kernel.org>
To:     alina_yu@richtek.com
Cc:     lgirdwood@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC
 driver
Message-ID: <9eb5d3a3-ba26-4e68-9324-9f1ce24418b9@sirena.org.uk>
References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com>
 <1689758686-14409-3-git-send-email-alina_yu@richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s7Tf4Ty8R9yCnV/7"
Content-Disposition: inline
In-Reply-To: <1689758686-14409-3-git-send-email-alina_yu@richtek.com>
Precedence: bulk


--s7Tf4Ty8R9yCnV/7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 19, 2023 at 05:24:46PM +0800, alina_yu@richtek.com wrote:
> From: alinayu <alina_yu@richtek.com>
>=20

It'd be better to format this like you do in your e-mail and signoff so
that git doesn't generate the extra line and the logs look a bit neater
(there might also be some warnings about signoffs due to the mismatch).
'git commit --amend --author=3D' should help.

> Add support for the RTQ2208 SubPMIC
> This ic integrates with configurable, synchrnous buck converters and two =
ldos.

The driver looks good, just needs the bindings sorting.

--s7Tf4Ty8R9yCnV/7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS4GIEACgkQJNaLcl1U
h9DQVAf9H6OOnhoJVDIuI/nPwr5uD0s4hrJyHYT1gd/JIhhSGk6UQa16fgLqnDWr
YVjprM4X6yJ1TfFIN1DlJuyny2Vc1dO9b1qOfjS2iYPLIU9ZVYjPOwkIHIayR274
TBziDe+hNDP37YXdQ9oy1qFa6PSuH7lbXmHUBJ7G6bvZgiSuhVDBKJUdMwZTkF/B
XqvFPkJ9wERfNaje1XWTvh4RWLLf31gtducYqJO+Q8xLnRdKPmTUb3oRDvTQ1QYg
LVh//TNSQxYmtdlDNbr4vcUAJHxDTuGpRBcLbJkWud8fsMoj9a0XD+zYpaleNmas
fxHRyrRkO0JvspmiJPbOaICeyR04gQ==
=u7Uu
-----END PGP SIGNATURE-----

--s7Tf4Ty8R9yCnV/7--