Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8511542rwp; Wed, 19 Jul 2023 10:50:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlE4imR0g0p2/xO5hfD3mjhLnHnn7a6ycEn4t7Gf84Hgl+KmpvL6HiIoDr+O3O4smtplSLJC X-Received: by 2002:a05:6402:1486:b0:51b:c6d8:71b5 with SMTP id e6-20020a056402148600b0051bc6d871b5mr3105904edv.22.1689789019636; Wed, 19 Jul 2023 10:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689789019; cv=none; d=google.com; s=arc-20160816; b=DF3JtkRGdZOtrPgoLMYrfx5pTtZcAmhp2A8U3KkA8Qt5tsdTomR8OeX5uPcvU42b5i CfUSPCNb4wlrlN6zy1MfYdnfi2YyjrxUU6+UmOKqUKQ/LRKR8CHhvJlnTJUeYEd37sN3 +szN5WPQAjfJ1KEqux8+7G792b487GyeLiklCmzWsdVp3b1zGhN4bEodomtkUHxQGJgM f6Iw9vj0AFxcIxQ0TXQAgJ7hm/fLH6MB3kLUknYB7cX60dhaDzNyh1Ivq/ygwaGJK6Ur WB4orSd/4SmnZa/+znV58xTFD359vJzLE6iJP+nnrG1cSpcdOeSEJFbvUVxF91l9i30E UEGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yixFqSzT/c4E0mvGw1Uo9KfL2QY9NEvmj8leiEc3puY=; fh=40O4w1Qv5SjRVdXHJfSyVZf5Cz6HjM9O9AM/YEiUq8o=; b=Ri1awMat7jOZT4aRCdT15v2CPPYCUi9Ngigj/w6Wi9QOnxxYrPfzD0i6L0GDCfrJu5 ymZfjxZR7E3l7AjEgrWwwWFTQwlE8zSlt72WQUp+nCDWtfuzqIhAEjQUd3iAVir0asI6 ftVykC0833WBTKD6tAxIEOYetDoI4NCbLngKEzXBeKuuFn8dvV+2YrVD7heQXS2NEyoN p9MEAPWQrIM0/oKXzsi4hXW9lJGVt3i0cF0LbKvRdSA6WN5bDhLZcbDad4FazFsRdlbe F7Gd2QkuAm54iOjcny97K3Wn7E8PgCmSbpZYcYRo8+HfYRNaUbvMluJdN9KuHh/6kHtI bGSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Y0sBPXTz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p16-20020a056402075000b0051fee9567c0si3314775edy.312.2023.07.19.10.49.55; Wed, 19 Jul 2023 10:50:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Y0sBPXTz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbjGSQsZ (ORCPT + 99 others); Wed, 19 Jul 2023 12:48:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbjGSQsW (ORCPT ); Wed, 19 Jul 2023 12:48:22 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B22F01FD9 for ; Wed, 19 Jul 2023 09:48:17 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51e56749750so9791853a12.0 for ; Wed, 19 Jul 2023 09:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689785296; x=1692377296; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yixFqSzT/c4E0mvGw1Uo9KfL2QY9NEvmj8leiEc3puY=; b=Y0sBPXTz9dyJZPRwFkzpcMAF8C1+t5QmrsdtFb5qSp1+uPUnaGSzooAFfj2OI2jVWj jXB5pXt+6XqggnKKndNnkx0iufj5VXa70c5mH8xOC0FXX7T++VZIlcySPT14vXHduATU HsQa6hNZPhbnOmZQOUp6D8ajoMITXzwzGD0dRYoCMLmaqb0gN4AQY727/hfxPSuFik16 tK4Bq8uQdo820l+L3JHF5LFE/DaQZvenIfCYOUtOuyHHm+an7aqRO/nV05GUQzCYciPc oqZJPtv4nR8xNP9OXIgVXRJXvQwy4Q9D88KHaHF7OX1QtbdhcOziKcFxEtGUOB9sFZhG jXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689785296; x=1692377296; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yixFqSzT/c4E0mvGw1Uo9KfL2QY9NEvmj8leiEc3puY=; b=PR+p0jnQtJ7yYFxbySgZniG1oTz2b03x5UBGjgK7amDphrhyb6ANyc5kly4ZrLDT1E mRZQL47iFDHPEmydIqy5DK8zQRmSaFmxLi3zlIaQgUtb2APUwl2KZK8m6/mpUL1gnXET XGb3AOcuRgSYYITJv9jmQozIWAG72oDcjFoybfiM9CFJAS5wSw7tZxiz7WWt/8MfBwbv Z3ZDtBeSzPax4G+Yr7s8BlVMCsx1UDQZe6RfiJQWPA1KEqHJ6EkXVfIhALHYn6ZQiDuO czFUWMAOMTYPZZ7IC6bqINPNxUI3cyovpEl+jgXdQs708K0Hquj/x2OV0HH65LREp1ND Reng== X-Gm-Message-State: ABy/qLbD/KWK614/7DaFaXlGgf4WpXplJBAoW0Tlx9RAvTVCqjul++Gt J37yolIryUDxRbgsHDp4Hsc= X-Received: by 2002:a17:907:6d25:b0:982:9daf:9fcf with SMTP id sa37-20020a1709076d2500b009829daf9fcfmr3870702ejc.66.1689785295815; Wed, 19 Jul 2023 09:48:15 -0700 (PDT) Received: from localhost.localdomain ([2a01:c844:242b:b300:215:5dff:fe9c:4c81]) by smtp.gmail.com with ESMTPSA id gl7-20020a170906e0c700b00989027eb30asm2566959ejb.158.2023.07.19.09.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 09:48:15 -0700 (PDT) From: Matus Gajdos To: Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Stephen Warren Cc: Matus Gajdos , Mark Brown , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: fsl_spdif: Silence output on stop Date: Wed, 19 Jul 2023 18:47:29 +0200 Message-Id: <20230719164729.19969-1-matuszpd@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clear TX registers on stop to prevent the SPDIF interface from sending last written word over and over again. Fixes: a2388a498ad2 ("ASoC: fsl: Add S/PDIF CPU DAI driver") Signed-off-by: Matus Gajdos --- sound/soc/fsl/fsl_spdif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 95e639711eba..95bb8b10494a 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -755,6 +755,8 @@ static int fsl_spdif_trigger(struct snd_pcm_substream *substream, case SNDRV_PCM_TRIGGER_PAUSE_PUSH: regmap_update_bits(regmap, REG_SPDIF_SCR, dmaen, 0); regmap_update_bits(regmap, REG_SPDIF_SIE, intr, 0); + regmap_write(regmap, REG_SPDIF_STL, 0x0); + regmap_write(regmap, REG_SPDIF_STR, 0x0); break; default: return -EINVAL; -- 2.25.1