Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 11:05:28 -0700
From:   Chris Leech <cleech@redhat.com>
To:     hanyu001@208suo.com
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Fwd: [PATCH] scsi: be2iscsi: wacom: convert sysfs
 sprintf/snprintf family to sysfs_emit
Message-ID: <ZLgl6EsMeFKCGQ62@rhel-developer-toolbox-latest>
References: <tencent_A27502E2D5B495E4E319441AB4B3B5F7E708@qq.com>
 <a70b030b0e0bdf224d35dec9aecc7371@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a70b030b0e0bdf224d35dec9aecc7371@208suo.com>
Precedence: bulk

On Fri, Jul 14, 2023 at 04:10:43PM +0800, hanyu001@208suo.com wrote:
> Fix the following coccicheck warning:
> 
> ./drivers/hid/wacom_sys.c:1828:8-16: WARNING: use scnprintf or sprintf.
> 
> ./drivers/scsi/be2iscsi/be_mgmt.c:1251:9-17: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/be2iscsi/be_mgmt.c:1145:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/be2iscsi/be_mgmt.c:1164:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/be2iscsi/be_mgmt.c:1280:8-16: WARNING: use scnprintf or
> sprintf
> 
> Signed-off-by: ztt <1549089851@qq.com>
> ---
>  drivers/scsi/be2iscsi/be_mgmt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

The changes here to scnprintf don't match the subject, which mentions
sysfs_emit.  It would be better to convert to sysfs_emit.

- Chris Leech

> 
> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c
> b/drivers/scsi/be2iscsi/be_mgmt.c
> index 4e899ec1477d..4916ce9c36a6 100644
> --- a/drivers/scsi/be2iscsi/be_mgmt.c
> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
> @@ -1142,7 +1142,7 @@ ssize_t
>  beiscsi_drvr_ver_disp(struct device *dev, struct device_attribute *attr,
>                 char *buf)
>  {
> -    return snprintf(buf, PAGE_SIZE, BE_NAME "\n");
> +    return scnprintf(buf, PAGE_SIZE, BE_NAME "\n");
>  }
> 
>  /**
> @@ -1161,7 +1161,7 @@ beiscsi_fw_ver_disp(struct device *dev, struct
> device_attribute *attr,
>      struct Scsi_Host *shost = class_to_shost(dev);
>      struct beiscsi_hba *phba = iscsi_host_priv(shost);
> 
> -    return snprintf(buf, PAGE_SIZE, "%s\n", phba->fw_ver_str);
> +    return scnprintf(buf, PAGE_SIZE, "%s\n", phba->fw_ver_str);
>  }
> 
>  /**
> @@ -1248,7 +1248,7 @@ beiscsi_adap_family_disp(struct device *dev, struct
> device_attribute *attr,
>      case BE_DEVICE_ID1:
>      case OC_DEVICE_ID1:
>      case OC_DEVICE_ID2:
> -        return snprintf(buf, PAGE_SIZE,
> +        return scnprintf(buf, PAGE_SIZE,
>                  "Obsolete/Unsupported BE2 Adapter Family\n");
>      case BE_DEVICE_ID2:
>      case OC_DEVICE_ID3:
> @@ -1277,7 +1277,7 @@ beiscsi_phys_port_disp(struct device *dev, struct
> device_attribute *attr,
>      struct Scsi_Host *shost = class_to_shost(dev);
>      struct beiscsi_hba *phba = iscsi_host_priv(shost);
> 
> -    return snprintf(buf, PAGE_SIZE, "Port Identifier : %u\n",
> +    return scnprintf(buf, PAGE_SIZE, "Port Identifier : %u\n",
>              phba->fw_config.phys_port);
>  }