Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 21:29:30 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Suman Ghosh <sumang@marvell.com>
Cc:     sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
        hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, lcherian@marvell.com,
        jerinj@marvell.com
Subject: Re: [net-next PATCH V3] octeontx2-af: Install TC filter rules in
 hardware based on priority
Message-ID: <ZLhHqn2mNP6L4qNJ@corigine.com>
References: <20230718044049.2546328-1-sumang@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718044049.2546328-1-sumang@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fyQh0KReBH0ci5vURzghhlwx/hzhrPwx+dy79bHfHPaADnS8yDe5j3gYeA9u?=
 =?us-ascii?Q?LJZwmyU+ROsaT1Ug0ufxH8PNmgF6T6swbJIJaoBLrsFbq9yrhjUraWxUouyP?=
 =?us-ascii?Q?JSSEA+s1qRPtwUsmxN053DPS8XoQj2eKUEiuU/WUz5julAzh64QUgwB9na7h?=
 =?us-ascii?Q?HGcEVy5J8krdbw+gNykM1f8qXNlMEBOwE3BbJVc/QmeFfZjakVhXFXrcXfmK?=
 =?us-ascii?Q?VliREJvdkIFS3bA1ppVKSBTrLNIfqcu93W27mau0Eclfdv2XpMs5TXpNRvZ8?=
 =?us-ascii?Q?MND0885IW/HBAN/RJJTWgi7wKaIGxnI8hTZAqBvpbWdOSv1+0XLfyMZI1e3a?=
 =?us-ascii?Q?+VDev6a8mgZanEIfFb75V87e6QuHUpaG9iy932uz9Z7DkvNl99TCHQf7bfUX?=
 =?us-ascii?Q?yco0swAJm1ICotu/0sV+U2ou/PF6UA6UJBwNeEiBakjw17yKgdmz7yTt2jKc?=
 =?us-ascii?Q?MPx6vi303SgrsdLdy/kf1VQiYwXmHI0QTxyS44tgWysJl9UYclS9TAyAGGrq?=
 =?us-ascii?Q?eN0L3LijWezlYeFx0USk3xpjkfh0cd23sGdMYMieHQGby1ifibDb3BRAsIcm?=
 =?us-ascii?Q?b1AKGqaKKRZv5B1KbZT3EsEiuyr1uwo/yRLC58vqfaXWAbHxZvcFdznELglf?=
 =?us-ascii?Q?+q+OfGLSALdlBJPxPaan3CPKENveWWJb/HJpvLYSgNQYfJEl3mI/hRzn9W0j?=
 =?us-ascii?Q?gWELL/L1adk9NdurdaoqcakQuG8wnlOkVaZRXC5Qc0aosivukODAt6KgQk66?=
 =?us-ascii?Q?gVCxlkZB4ib/AZRJTFTtBKDVNCbTBT6wtwQpOM/9ZkIzoFmM1T6bMW1Fz8UA?=
 =?us-ascii?Q?YoxqjmUxIYGVtO+mDzNlDF7qAoVTMQDF17z0O2dqDWTuxxLPaJoBwPUqBoTc?=
 =?us-ascii?Q?f83xvXCkIfRstwOwEcrH1hV4L84eYBU3WBp9aGiGe6czULXaDlsPE3APrlFM?=
 =?us-ascii?Q?PXt9BXLV4bz2JZXygrmU9zPru4MH70srgmfrcpQN0kIBvbwJhgXXbIAzhOg6?=
 =?us-ascii?Q?b5hkYqbv/rfMx5GjqEaFchxQjuaF48f/u54rAojrs0TuVdCmYpxVTS0GvT4t?=
 =?us-ascii?Q?JPcFUwqg1CqtzvTIT3HYYe8iKR/DZij3ohsIAhqo5nH7nCn/Uc4OEkqb1jxG?=
 =?us-ascii?Q?je2Ut9gT3SAGK2/aYH4HVHmT2FazS/gDQRyFFlQ03ZEfwRUFjhUhsicUF6JS?=
 =?us-ascii?Q?N2Ap+fH0SvocNJpnFuYBzHokpjRPSBEq4NyEjUg1CieuFIkmnKjo+PJLnZyQ?=
 =?us-ascii?Q?I4UfPYClCF3uiCJagAM7yfxuFdKBpAOsxo8S3YZpj3q2q1ixnoQAo4abNTBt?=
 =?us-ascii?Q?tSSnpzDYu+lCaqrUkUwzVsKCuvaZiaLCc2KOAL37/NVVo/5dBnOVb4APTzCH?=
 =?us-ascii?Q?6bEbv8xYe585ONcBG9NU8+ly91JEZtTpdQdJqFgCnHq/COJSv41Ci5uw0BgY?=
 =?us-ascii?Q?1iNeqTZWHnRnjlltvIke9GTi3m9oN87WLiJq/GdbOwD4hpLHoNfFFcW7nbgq?=
 =?us-ascii?Q?MraH5p3UtMnN0IR0Ghoj2HlDMn32d9KY1xWlVLac1E2vX93Dyu1iSdStDdIf?=
 =?us-ascii?Q?NPqE0gVcupw6TAgCn3USF4PQ+QS3XBdGUOkLrvcwoZaQ8J46JTzAD1crHGPD?=
 =?us-ascii?Q?4g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33e2a212-042e-42ac-99e5-08db8896dfdf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 20:29:38.7039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8iEiGVR0hfw274C8pb1Hd6qSsQsPBYqMVjxElCrodf3JQg3fwD7T5JqEM9Z8zUKIb/OvF8mMsHKcOnOTVhCfY69+WoXya/5uDOX7JOnnb2A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3698
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 18, 2023 at 10:10:49AM +0530, Suman Ghosh wrote:
> As of today, hardware does not support installing tc filter
> rules based on priority. This patch adds support to install
> the hardware rules based on priority. The final hardware rules
> will not be dependent on rule installation order, it will be strictly
> priority based, same as software.
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>

...

> @@ -729,22 +816,106 @@ static int otx2_del_mcam_flow_entry(struct otx2_nic *nic, u16 entry)
>  		mutex_unlock(&nic->mbox.lock);
>  		return -EFAULT;
>  	}
> +
> +	if (cntr_val) {
> +		rsp = (struct npc_delete_flow_rsp *)otx2_mbox_get_rsp(&nic->mbox.mbox,
> +								      0, &req->hdr);
> +		*cntr_val = rsp->cntr_val;

Hi Suman,

otx2_mbox_get_rsp may return an ERR_PTR.
Is it ok not to check that before dereferencing rsp?

> +	}
> +
>  	mutex_unlock(&nic->mbox.lock);
> +	return 0;
> +}

...