Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8747363rwp; Wed, 19 Jul 2023 14:55:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlEv8eW1nbBWU9qZXJ0SlCgKelsyfr+BFn6CtusCmciFT3ix0F/YOtrU9FRUwBe9uUx5Co5Q X-Received: by 2002:a17:907:720a:b0:98e:23d3:bf47 with SMTP id dr10-20020a170907720a00b0098e23d3bf47mr4151618ejc.36.1689803745988; Wed, 19 Jul 2023 14:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689803745; cv=none; d=google.com; s=arc-20160816; b=sHbPKujjKgMd4CGnCQMJkeZqFj2ErH8v/D/lWfJyW05NxTlavJMiMGe0yjNSSa+g4S 2//348CNxzkgb5HYeQHY8AdKi+dTy7CJP8qaX73Y/BWg8VCOxi4d5XqZMKGeZceltFBY kIBcuWaZN/eOljKoEHel5fBpTDlqKzs932Zk8C/E+LXlLRKUMcR4yUfHznaOJtd4ud9t KsuDraXpdr7NwtlOlhPRkpitE+CdZ59PlLCaiD0XbfVyoHvuhK03U+xXXHl/KuuerCvX f8MMIylDSwfzp03dA4QK1wamHJfTuZVYDVUpUjJRIGqY001qtep3McCA+47tGAfX+OGL hHoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=xGEGGDR6RYdz2AdzUDJ0M3d3D/5BubY8tz2dYva7gYk=; fh=1Csyea/JelIHm5oxq9DJysyfSN8X3Cq1htncgD838ZU=; b=m/7i+TUe1vSeliZnWjmo6oxEHmS77ftMzrvVaZrUU3g5+Enoo9KdPahSPHcDd09NRc xK902AsmhcCj1EvrgbkgiB1/SYQNKBvvc0ceOmIGX/0K2R1MLRCkf0werIBVQ8GopTz6 m2fuPSvnjDKtEztnubZT2Uzh72/tjPwpoeBwv63QJu2lc1wzeAI+Kq5gXbOPGPGGJKMJ nIYZhV/iENoRzavQRARCX4D9eq4z1DK2/da2KACFmit/SeB4P6nyh+qw221PZDbHfzPc ul+cEs39yF+mALBKdWUX8hdQTS/oRmXYWYoz0iF0XoZAx6FivT91DZwJihbMlE3FC6Ux zuog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KDkv3bTY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e25-20020a170906081900b00993692f6b87si3409584ejd.409.2023.07.19.14.55.20; Wed, 19 Jul 2023 14:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KDkv3bTY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbjGSVFl (ORCPT + 99 others); Wed, 19 Jul 2023 17:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjGSVFk (ORCPT ); Wed, 19 Jul 2023 17:05:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBE921BF0; Wed, 19 Jul 2023 14:05:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F3F161821; Wed, 19 Jul 2023 21:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE731C433C7; Wed, 19 Jul 2023 21:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689800738; bh=SFibgF6YkGBeNXjqj/gtZ7x11MqvMBIJdb+ipYc8qH8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=KDkv3bTYk0DnruWqgU/F8mCH3c6RepJL7G//dYoqowEy8uZeThvyQDsyZBGMbFlXz PXh3nFjpoR7aNeOAFMRN+f9A5t6BeRPP/A8CR31g7Hv/GqZmqz4yB9owCSre8nwOH7 et/awEwRpYGq5DSwZrRlJO5JMS1+TvK4lBNlD0kjYJfolTgvcIaYXrUZTvu99kN7fe Rqx/ig760cvAnUVuPHgTpm3bc8Jnwu78zE/SDNc0bN5MN4Cb7feAOJEBpdB6co9uUL agGIPPW8c9CEb55navreOWOBWR0mzr4g8/jQeim2mMFM6negG4VF3+U9Yp2sPBKkys Y/MpPJHrk+plw== Message-ID: <0f12361faf464ea6c6d0313d1dc54f90.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230711150812.3562221-1-geert+renesas@glider.be> References: <20230711150812.3562221-1-geert+renesas@glider.be> Subject: Re: [PATCH] clk: imx93: Propagate correct error in imx93_clocks_probe() From: Stephen Boyd Cc: NXP Linux Team , kernel test robot , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven To: Abel Vesa , Dan Carpenter , Fabio Estevam , Geert Uytterhoeven , Michael Turquette , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Zhanhao Hu Date: Wed, 19 Jul 2023 14:05:35 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Geert Uytterhoeven (2023-07-11 08:08:12) > smatch reports: >=20 > drivers/clk/imx/clk-imx93.c:294 imx93_clocks_probe() error: uninitial= ized symbol 'base'. >=20 > Indeed, in case of an error, the wrong (yet uninitialized) variable is > converted to an error code and returned. > Fix this by propagating the error code in the correct variable. >=20 > Fixes: e02ba11b45764705 ("clk: imx93: fix memory leak and missing unwind = goto in imx93_clocks_probe") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/9c2acd81-3ad8-485d-819e-9e4201277831@= kadam.mountain > Reported-by: kernel test robot > Closes: https://lore.kernel.org/all/202306161533.4YDmL22b-lkp@intel.com/ > Signed-off-by: Geert Uytterhoeven > --- Applied to clk-fixes