Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Jul 2023 21:45:17 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Wei Fang <wei.fang@nxp.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, xiaoning.wang@nxp.com, shenwei.wang@nxp.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: Re: [PATCH net-next 0/3] clean up the FEC driver
Message-ID: <ZLhLXVNm6LVqjg0Z@corigine.com>
References: <20230718090928.2654347-1-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718090928.2654347-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uIUuiAvDNI2DytDYeLwC923WtIw6jHMWZTD867cGZ7cJ0H91Bww2D61Asv4O?=
 =?us-ascii?Q?dG/oeydTgfb+xdkWZ9eGP2c0gxD3V/L15xhr7dx56IC7uYLZ0K5KKGOCW/OD?=
 =?us-ascii?Q?iw1UZGsvevwK1IjrE67hXEFbVxu/qxX+eqrsCla/cFUVQ0aYqu4GvqBRfK/3?=
 =?us-ascii?Q?GKWzzesR3r9q9qcSvH22CwlRcbtqEEvMb7o+akEIVOZTEMprfjnyWmXrx/Oq?=
 =?us-ascii?Q?linf4QeXa6kLaDJhTU29qmdg9NmvwYV4jelLtmN2x3A4//z4dI4fpNaRLNbm?=
 =?us-ascii?Q?uvQsZGVmbkYzCv2kSEKrHbtIXH38ECJNOFifyI8JZa1Ij0lGcaQmaM+R3GUk?=
 =?us-ascii?Q?JpbsagGqPRrOyBEMAe5AfKZPXNjKhPV4pF9q5C+g6PYlWPee0OdVYZht/gcu?=
 =?us-ascii?Q?xLE6T6k3zYLRTJyvDgH8tl2igO4S2Mw3MZm2IhVZJS02VFpGmhgRnvVS06dY?=
 =?us-ascii?Q?3RLAQeERxOXGzHOXnuy/uvfKyXPMHu+HkwTGhBvjxdzzjqL83JHMAdpqxsXU?=
 =?us-ascii?Q?8xkfhmR7X9Q1/y1fiZuJxWPo8Tlkt2lDIjkgfYiwEZ31tnkNuiZdb8/dREc8?=
 =?us-ascii?Q?l7nCLLXNCA/liX5IvKLzTyaNP6P+yQ4D9Nz7QOhvz7nQj033fl4HhE3zpzYy?=
 =?us-ascii?Q?Ew6TCT/XFNTt40/4Kvp4RdTCIS/DLC3xCMeNn3RsxlE6+gg/g2+1HdcFRoMg?=
 =?us-ascii?Q?bkSWzMLK3MCJI2rxvOurCa6YIX7OX2B5pGOVE0Y3XDT1D1/tXud7thnHMo9R?=
 =?us-ascii?Q?aTyoG9FgRGGf0RgLz9d0MgUI3K7Lwc33gmUy4DlDL6N+1tFJrOtsK5B+95Gf?=
 =?us-ascii?Q?tM+FIwThrgjU38C4XY2/XDqqye2jzrDmLKlz0J1u8QrOkZ0fHPnw/pDMTAyu?=
 =?us-ascii?Q?HEBamQXwnkdMqKgHuvdZVr8+/gANv22ZRlF9VLZZxBKxyUVlLHYtI37Hxlcb?=
 =?us-ascii?Q?ctF48hm4cYmf00fdyjXzH9QupH1c9CK3Unae0B7I2TU/fRK8NrhxRVKZPVFO?=
 =?us-ascii?Q?X4ohMTvo6cgp03ZaxWbrnH0mcLYhiuCHlyiqpJk9XLK3BfrdA11RVMpWqX6B?=
 =?us-ascii?Q?EuCCe12szNrHDqUHpsPVtNaD73zVxCOG7G/za31NVjyykjDyAMTnJUuRpo1v?=
 =?us-ascii?Q?e894K37/KZeQTyyQuZceWFFYOjR1YJ4v94hmyXACOXM6URddSmWnsoVAqmp+?=
 =?us-ascii?Q?XkwDGq8aUQS2ksxWssBCc7aPKPtxgOaiZtBGXTkZxARmSS96CRnUiKBZMLa3?=
 =?us-ascii?Q?xirIWmwCe/NVqolRTRBnLGrN5e5RENekA3VCIi5bhrqhXa0qj3f0b5fd6fja?=
 =?us-ascii?Q?NfPb6HIuzlCR4J5J/S8IZNMXc0MAXx5adHoetFP/LX4C0ZOqG2q/R75ca7FG?=
 =?us-ascii?Q?PLZR0SU8z3TlZvlW37Jq+gat8LdJWvfTvOHx/RnC/ULDCUnoQ0GncpkPbu0u?=
 =?us-ascii?Q?AKSmpV5VUKux6FT+QyxatkLoaNgdgbJG4kysaKcdiyD+4FloyIhffOpuZCo9?=
 =?us-ascii?Q?My00p2Iqt8vRaE0eFCeASkGYo/nI/GHlmbTsEqMKlLVG/wAUPzPzCPQd4DIk?=
 =?us-ascii?Q?pwfmuOVHTJyZk05FxTlufaNM2XiIVHZSzhskfBNA9dXTKufnOx/L3s7gUTk/?=
 =?us-ascii?Q?QA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e04c7d3b-a633-4113-123d-08db889913a9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 20:45:24.6446
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ih68FtXiVOfseugB1Q4KnLqa0KK569CcBtSR5tf/haJlAmwBjyAzt5AnJElk0t7ixw93IPr9vtP0Ta1ecNYrdey11FHamE1XcBDJvyxBzM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4721
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 18, 2023 at 05:09:25PM +0800, Wei Fang wrote:
> When reading the codes of the FEC driver recently, I found there are
> some redundant or invalid codes, these codes make the FEC driver a
> bit messy and not concise, so this patch set has cleaned up the FEC
> driver. At present, I only found these, but I believe these are not
> all, I will continue to clean up the FEC driver in the future.
> 
> Wei Fang (3):
>   net: fec: remove the remaining code of rx copybreak
>   net: fec: remove fec_set_mac_address() from fec_enet_init()
>   net: fec: remove unused members from struct fec_enet_private

Reviewed-by: Simon Horman <simon.horman@corigine.com>