Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8775759rwp; Wed, 19 Jul 2023 15:25:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlF1neEmEVnQ9y/vtPcsH4RljRaBTLANQUiaoDJ00juZvM4OxBP6p1kWIiCbYd9+DI+U46gZ X-Received: by 2002:a17:902:cece:b0:1b8:a3a6:df9c with SMTP id d14-20020a170902cece00b001b8a3a6df9cmr4318969plg.60.1689805502874; Wed, 19 Jul 2023 15:25:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689805502; cv=none; d=google.com; s=arc-20160816; b=USnbKObLTaP64tyEeiXyI3I+zFYNeOUrstoWqSY1TGilPmtBuIOS1wJGmceZXRgzMQ uhlcAy4pTwW6iMjmqhpaH2sWqz/j4heKavDy7IZd6GbaJ++VlEo7TzT0+I7i6SkgcfdG QIgYncYd04fg8KMiVrer1AZ0KRBkJGoB0rZDa3cV4JDHjEJpI3kjNexW636pAzJMajyx C9BMEz1pbc5t0R8NAAs1FwTiC8meXePvK4ifab5nt3iJSrgMmIFK4JsD/52cngoquRBt QtXYLUgSmTtNslqFCLZeoZrcPCx5w2yleMxdgqOq0g0hwrSHHbQScgduKaOHOhSu/yT0 zxiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=TaLerVSG9EvBBPGx6SsQ3R1J0acVBnahUF0b+A53yz8=; fh=BwxrnyLjQUUeJh3NAvnPJuYi8V0NDXUH3RZlGaWwM6k=; b=CXoF9BjUXVGvA+mLNvUIW7Uo9KR73dtL4qb4dJN6qOpc3pgSV/4nMEYV3PghEsDpSc o15LCdsdhyfMJLSbMt4CgyWqCF56x4R1ILSkmeEjrATwYFZh+F31WBJ+iYP2ARtW6JKa YNATeqnRzujMKoV2VOcGfWdEoVg7qT6AODVVbPAwtTG5QmRcRnoOTxipS9iEZNgeAaYj RwtLkjOMp5lc05YJkTIbeUMiMGbWSU/SLu7DXb4cSv00ugojKFbtDmkmF+uAAM7H86+4 yiKqre41fN0vvVZy8LF1JrhD3Rfa9YmY70iVykARo405wmUD+ayIBxyf3ZhfOBZJItza Mg3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oqxGijWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a170903404b00b001b9ea40d26fsi3963501pla.295.2023.07.19.15.24.50; Wed, 19 Jul 2023 15:25:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oqxGijWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229639AbjGSVkv (ORCPT + 99 others); Wed, 19 Jul 2023 17:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjGSVku (ORCPT ); Wed, 19 Jul 2023 17:40:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBBFE1FCD; Wed, 19 Jul 2023 14:40:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EEBD61841; Wed, 19 Jul 2023 21:40:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCA20C433C7; Wed, 19 Jul 2023 21:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689802848; bh=TaLerVSG9EvBBPGx6SsQ3R1J0acVBnahUF0b+A53yz8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=oqxGijWDGdJ4wRhwBHYjDBAVISHRzmGigrT79or5dg5v5tWZFV7Jk80KW2atVR1gj RXEbf9aiEHea3KkpxvsAhDSBfNjsRloB3q29awBRqpX1b3aWOUqdaBPyGI2ULgXwtx /G+pc9GiQOIGlSQudHaBiZKAsdR5MGcxO9mJrOTIOQzg5e+SahkpCSCXv6m/rthxaH BL08kEwsVHEk0JhjEO3fcTySrNGENktWM3qGxE4IN6Yqr681l5el8FcFO0U7uuorRA sx7mm0oJCmdVyTpDdXAK4vsmdoau6ybEMT6ud9VChG/GUl2cB/kNVyFlYED3MsIjcl U7mbjR8IOVvtw== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230712102246.10348-1-duminjie@vivo.com> References: <20230712102246.10348-1-duminjie@vivo.com> Subject: Re: [PATCH v1] drivers: clk: keystone: Fix parameter judgment in _of_pll_clk_init() From: Stephen Boyd Cc: opensource.kernel@vivo.com, Minjie Du To: Michael Turquette , Minjie Du , Santosh Shilimkar , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 19 Jul 2023 14:40:45 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Minjie Du (2023-07-12 03:22:46) > The function clk_register_pll() may return NULL(in line 149) or ERR_PTR > (in line 131). > Fix: make IS_ERR_OR_NULL() judge the clk_register_pll() function return. >=20 > Signed-off-by: Minjie Du > --- Applied to clk-next