Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <82c139c6-ab4c-9810-bbc6-84e6d19984a6@amd.com>
Date:   Wed, 19 Jul 2023 15:06:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] PCI, AER: Export and make pcie_aer_is_native() global
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-cxl@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        oohall@gmail.com, Lukas Wunner <lukas@wunner.de>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Robert Richter <rrichter@amd.com>
References: <20230719203600.GA514279@bhelgaas>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <20230719203600.GA514279@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW1BZStGLzNxRUVZbzN2TkwyNnpnSnl2Y1dBbUdCaC9ZUWtXY2VNWlVUTGtq?=
 =?utf-8?B?YzREajhjS2JqdDNVZmNJTVRUYmlYU25FblNHR0NObkQ4RzFNWjU2UTc3eDR5?=
 =?utf-8?B?M1FTM09WSnVld09sTjlzWE5uK2JhTzcwR0NNVFdhTHFlUDdJY2QxejNBWHpE?=
 =?utf-8?B?RDdqUG5lSjRGckJnSVhydFI3RExwcjY1YTFHamQ3ZDVWV1N2K1Y2T0RkMHRv?=
 =?utf-8?B?MFRoQldYNEw1YzZkeDBwMmhJU1RRS1BjTXZHRDBKMXdqTXJYZFJDTC93RHkx?=
 =?utf-8?B?L3ZUaXZyeDZFZmJwUW9hMzNnZG9tdWlRQm9hMHQ4bTRWNng1MlpMZ2R3Z1B2?=
 =?utf-8?B?dUNXeTNKM3ZDTTNteXh0NXM0YjdRcU1KRmVpWWgvK2EzTmxCRm51dDhTbEdu?=
 =?utf-8?B?amc3WFIvWmNlN2IyeVhBamVkME9tb1dFZUJEMkx0T2JTVWtrYjVlamx0M3hO?=
 =?utf-8?B?dUZwQXFzTjI4K2drWW1zUjRpOUpQSDRHS25sQWsxZkh6MllLZTI5N1BubUZU?=
 =?utf-8?B?UFRhcEZXRGNIQjQ3ODNobE1ac2pRdGhBNUJ0cGtEVEcyZ1ZxY2QzNkcxZTRK?=
 =?utf-8?B?d05qN1NSNGVlWmNxV0dyaENPb1BmWkdOa1hHYlhQL0xFazlJbGw4TmF0V1kv?=
 =?utf-8?B?dE9OTk5NNVVhWjY0bHQ0Ym9XWVZGQzBKVVVNNjJoWEgySThzQjY2Mm0zNVNh?=
 =?utf-8?B?MmJFZXNCK1JaenFNUmRrQzJYM0ZBcWJBbVVQNW40Rm5CaUJ4QXdaR1NXc2hL?=
 =?utf-8?B?M21qcUJEYndtOVFUT0hQQ29naU5wVVZjcUpZR3kxYXA0YWF5bTBuS290UTNC?=
 =?utf-8?B?V2U0WXdJTmtrRU9ib1NtNVA0VFRaQjU1ODRTT3VSeDJEMWorck1LdFQ4QTlB?=
 =?utf-8?B?d0g3NjhjTTRhb0JCTk5ndDRqMHVjY1dUSjVCWUZ3OUNNR0kyYjE4U2ZNd1lS?=
 =?utf-8?B?eVVVR2F5dUUweTdncmdhbTkrMGIvZitzKyt3czJGOUJoMUowd3kvdmlyVnN0?=
 =?utf-8?B?akxHVElkMng1YnlHTVhYNUdOYkVrUkd1VDBIVkJzUkw3em9hbVd4cFc3dENX?=
 =?utf-8?B?dTk4dTFHZXFvaFRsUXQvNjlOa2lhYkRaUE9tVE8vcFdQTTdhVHNoWmZjZ0Qz?=
 =?utf-8?B?bjZhZ1pQc25FRkhoNDhrMU42Yjl6ejhEUmt2bWJFTmNmMWlMejViZEdDV2Ew?=
 =?utf-8?B?ZTJiYncvMDRLR0Z0VWkweHRscVNuY2xMazI5TVpYNnVieDl4MEFlWFdabmc4?=
 =?utf-8?B?cGhoNW5WeklmYnArUmc0QkNhM2V2S1ZqdGN2NzhEMTcvVDNpQmtJMEN6ZkYw?=
 =?utf-8?B?MElRWS84S2I0TmlJcVhRMWg1RDhjUjJQb08yejRxNFdyY1g0UG1ldzBIT3BN?=
 =?utf-8?B?RDJ1MzFRd3l0TVNsSVJwVnFsQ0ZVZ1ZmK3VlS3lTNGIvbmNJRnFpUjE3Z3hJ?=
 =?utf-8?B?MHE1YlBLbWRZWjJIWkVKL3F2aVZhNnpNdVVtWlVWZmp1ajZMUm41eDhmcm1k?=
 =?utf-8?B?bjFlQ1pTMFVuaXliYkFPTFMvSy9LdDAwSDZieVZZYndFSjRjcUlmNUhCRzUx?=
 =?utf-8?B?ZjZWS2IyViszeVludW0yTzJRY25uTzJyUURZSVBtN3RwNzV5blNJSEQ4TWtN?=
 =?utf-8?B?SnpHWDdocml6SCtaU3VIRlpyVHR5cms5YUlMdDN1K0lmVEQwR2ZyVko3MmJC?=
 =?utf-8?B?a3p0cnBudHFRMVdPNEtQd1dHSmVGRHZWUmpjcFE5d0RjWFZTRFVaNzhvUU9Y?=
 =?utf-8?B?dVVhejdEODNtWURLSUdDWW9vbldPZ2JidFh4YjNLOWtaMFFzVU9UbFlYaXla?=
 =?utf-8?B?cWlMVzFWWTI1ZGU1eG9GMTE4OTZ6Y09GNHB2ZnR3bFBwOFV0bm5mekpCcWZK?=
 =?utf-8?B?Y0lEOUR0cE9kTXZ4d2hJVkp2QTF4cGpGcWQyS21ObmhEL3Q2WEtMbjZQNmRG?=
 =?utf-8?B?Z0VMcDM5dC9tL2M2bjA2bHZjb0NmM09UMzk0MFRpNGZZWHVsM3RNYU5hZXRh?=
 =?utf-8?B?Vk8rTmVhOVN6Z2xyT2hMM3pvM0ZVQUxndmpaZXl4cWpSNG15SWFqcHB3VnpS?=
 =?utf-8?B?Skwxb2dlekp6b0lSdnl4V2pCQTFCSHI5b3FlNmh4cDVUaUlra016TGE0LzNS?=
 =?utf-8?Q?c1NaF1rN4We3bIUJjFtrOs78t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32c280af-d3d8-4610-9d07-08db88a46c43
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 22:06:37.8217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JdV8ikVjE9WHVLpKnxjs3iAf/UJ3O92cqruT2jsMNF1GxogDGsmpgaX16JgYlGrwcZBAKliiYu2CBe8O4YYOUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5165
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/19/2023 1:36 PM, Bjorn Helgaas wrote:
> On Wed, Jul 19, 2023 at 07:23:12PM +0000, Smita Koralahalli wrote:
>> Export and move the declaration of pcie_aer_is_native() to a common header
>> file to be reused by cxl/pci module.
> 
> Run "git log --oneline drivers/pci/pcie/aer.c" and format your subject
> line to match.
> 
> "Exporting" pretty much means making it global, so "Export
> pcie_aer_is_native()" is probably enough.
> 
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> 
> With the above,

Will make the above two changes in v2. Thanks for the review!

Thanks,
Smita

> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
>> ---
>>   drivers/pci/pcie/aer.c     | 1 +
>>   drivers/pci/pcie/portdrv.h | 2 --
>>   include/linux/aer.h        | 2 ++
>>   3 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
>> index f6c24ded134c..87d90dbda023 100644
>> --- a/drivers/pci/pcie/aer.c
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -229,6 +229,7 @@ int pcie_aer_is_native(struct pci_dev *dev)
>>   
>>   	return pcie_ports_native || host->native_aer;
>>   }
>> +EXPORT_SYMBOL_GPL(pcie_aer_is_native);
>>   
>>   int pci_enable_pcie_error_reporting(struct pci_dev *dev)
>>   {
>> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
>> index 58a2b1a1cae4..1f3803bde7ee 100644
>> --- a/drivers/pci/pcie/portdrv.h
>> +++ b/drivers/pci/pcie/portdrv.h
>> @@ -29,10 +29,8 @@ extern bool pcie_ports_dpc_native;
>>   
>>   #ifdef CONFIG_PCIEAER
>>   int pcie_aer_init(void);
>> -int pcie_aer_is_native(struct pci_dev *dev);
>>   #else
>>   static inline int pcie_aer_init(void) { return 0; }
>> -static inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
>>   #endif
>>   
>>   #ifdef CONFIG_HOTPLUG_PCI_PCIE
>> diff --git a/include/linux/aer.h b/include/linux/aer.h
>> index 3a3ab05e13fd..94ce49a5f8d5 100644
>> --- a/include/linux/aer.h
>> +++ b/include/linux/aer.h
>> @@ -45,6 +45,7 @@ struct aer_capability_regs {
>>   int pci_enable_pcie_error_reporting(struct pci_dev *dev);
>>   int pci_disable_pcie_error_reporting(struct pci_dev *dev);
>>   int pci_aer_clear_nonfatal_status(struct pci_dev *dev);
>> +int pcie_aer_is_native(struct pci_dev *dev);
>>   #else
>>   static inline int pci_enable_pcie_error_reporting(struct pci_dev *dev)
>>   {
>> @@ -58,6 +59,7 @@ static inline int pci_aer_clear_nonfatal_status(struct pci_dev *dev)
>>   {
>>   	return -EINVAL;
>>   }
>> +static inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
>>   #endif
>>   
>>   void cper_print_aer(struct pci_dev *dev, int aer_severity,
>> -- 
>> 2.17.1
>>