Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Subject: [PATCH v6 0/8] x86/resctrl: Miscellaneous resctrl features
From:   Babu Moger <babu.moger@amd.com>
To:     <corbet@lwn.net>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>, <babu.moger@amd.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <pawan.kumar.gupta@linux.intel.com>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>, <babu.moger@amd.com>
Date:   Wed, 19 Jul 2023 18:21:07 -0500
Message-ID: <168980872063.1619861.420806535295905172.stgit@bmoger-ubuntu>
User-Agent: StGit/1.1.dev103+g5369f4c
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 23:21:16.6369
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b6a0d827-45ea-4829-dc08-08db88aeda0e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

These series adds support few minor features.=0A=
1. Support assigning multiple tasks to control/mon groups in one command.=
=0A=
2. Add debug mount option for resctrl interface.=0A=
3. Add RMID and CLOSID in resctrl interface when mounted with debug option.=
=0A=
4. Moves the default control group creation during the mount instead of dur=
ing init.=0A=
5. While doing these above changes, found that rftype flags needed some cle=
anup.=0A=
   They were named inconsistently. Re-arranged them much more cleanly now a=
nd added=0A=
   few comments. Hope it can help future additions.=0A=
---=0A=
v6:=0A=
   Changes since v5:=0A=
   Moved the default group creation during mount instead of kernel init.=0A=
   The rdt_root creation moved to rdt_get_tree as suggested by Reinette.=0A=
   https://lore.kernel.org/lkml/8f68ace7-e05b-ad6d-fa74-5ff8e179aec9@intel.=
com/=0A=
   Needed to modify rdtgroup_setup_root to take care of this.=0A=
   Re-arraged the patches to move the default group creation earlier.=0A=
   Others are mostly text changes and few minor changes.=0A=
   Patches are based on tip/master commit 1a2945f27157825a561be7840023e3664=
111ab2f=0A=
=0A=
v5:=0A=
   Changes since v4:=0A=
   Moved the default group creation during mount instead of kernel init.=0A=
   Tried to address most of the comments on commit log. Added more context =
and details.=0A=
   Addressed feedback about the patch4. Removed the code changes and only k=
ept the comments.=0A=
   I am ok to drop patch4. But I will wait for the comment on that.=0A=
   There were lots of comments. Hope I did not miss anything. Even if I mis=
sed, it is=0A=
   not intentional. =0A=
=0A=
v4: Changes since v3=0A=
    Addressed comments from Reinette and others.=0A=
    Removed newline requirement when adding tasks.=0A=
    Dropped one of the changes on flags. Kept the flag names mostly same.=
=0A=
    Changed the names of closid and rmid to ctrl_hw_id and mon_hw_id respec=
tively.=0A=
    James had some concerns about adding these files. Addressed it by makin=
g these=0A=
    files x86 specific.=0A=
    Tried to address Reinette's comment on patch 7. But due to current code=
 design=0A=
    I could not do it exact way. But changed it little bit to make it easy =
debug=0A=
    file additions in the future.  =0A=
=0A=
v3: Changes since v2=0A=
    Still waiting for more comments. While waiting, addressed few comments =
from Fenghua.=0A=
    Added few more texts in the documentation about multiple tasks assignme=
nt feature.=0A=
    Added pid in last_cmd_status when applicable.=0A=
    Introduced static resctrl_debug to save the debug option.=0A=
    Few minor text changes.=0A=
  =0A=
v2: Changes since v1=0A=
  a. Removed the changes to add the task's threads automatically. It requir=
ed=0A=
     book keeping to handle the failures and gets complicated. Removed that=
 change=0A=
     for now.=0A=
  b. Added -o debug option to mount in debug mode(comment from Fenghua)=0A=
  c. Added debug files rmid and closid. Stephane wanted to rename them more=
=0A=
     generic to accommodate ARM. It kind of loses meaning if is renamed dif=
ferently.=0A=
     Kept it same for now. Will change if he feels strong about it. =0A=
=0A=
v5: https://lore.kernel.org/lkml/168564586603.527584.10518315376465080920.s=
tgit@bmoger-ubuntu/=0A=
v4: https://lore.kernel.org/lkml/168177435378.1758847.8317743523931859131.s=
tgit@bmoger-ubuntu/=0A=
v3: https://lore.kernel.org/lkml/167778850105.1053859.14596357862185564029.=
stgit@bmoger-ubuntu/=0A=
v2: https://lore.kernel.org/lkml/167537433143.647488.9641864719195184123.st=
git@bmoger-ubuntu/=0A=
v1: https://lore.kernel.org/lkml/167278351577.34228.12803395505584557101.st=
git@bmoger-ubuntu/=0A=
=0A=
=0A=
Babu Moger (8):=0A=
      x86/resctrl: Add multiple tasks to the resctrl group at once=0A=
      x86/resctrl: Simplify rftype flag definitions=0A=
      x86/resctrl: Rename rftype flags for consistency=0A=
      x86/resctrl: Add comments on RFTYPE flags hierarchy=0A=
      x86/resctrl: Unwind the errors inside rdt_enable_ctx=0A=
      x86/resctrl: Move default control group creation during mount=0A=
      x86/resctrl: Introduce "-o debug" mount option=0A=
      x86/resctrl: Display hardware ids of resource groups=0A=
=0A=
=0A=
 Documentation/arch/x86/resctrl.rst     |  21 ++-=0A=
 arch/x86/kernel/cpu/resctrl/internal.h |  70 ++++++--=0A=
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 217 ++++++++++++++++++-------=0A=
 3 files changed, 236 insertions(+), 72 deletions(-)=0A=
=0A=
--=0A=