Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 10:35:40 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Steve French <smfrench@gmail.com>,
        CIFS <linux-cifs@vger.kernel.org>
Cc:     Winston Wen <wentao@uniontech.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        linux-modules@vger.kernel.org
Subject: linux-next: build failure after merge of the cifs tree
Message-ID: <20230720103540.0436273d@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/SNLc3YH5=1GospBWQy3z/qr";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/SNLc3YH5=1GospBWQy3z/qr
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the cifs tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/smb/client/connect.c: In function 'cifs_get_smb_ses':
fs/smb/client/connect.c:2293:49: error: passing argument 1 of 'load_nls' di=
scards 'const' qualifier from pointer target type [-Werror=3Ddiscarded-qual=
ifiers]
 2293 |         ses->local_nls =3D load_nls(ctx->local_nls->charset);
      |                                   ~~~~~~~~~~~~~~^~~~~~~~~
In file included from fs/smb/client/cifsproto.h:10,
                 from fs/smb/client/connect.c:37:
include/linux/nls.h:50:35: note: expected 'char *' but argument is of type =
'const char *'
   50 | extern struct nls_table *load_nls(char *);
      |                                   ^~~~~~

Caused by commit

  46055407cd4a ("cifs: fix charset issue in reconnection")

I have used the cifs tree from next-20230719 for today.

It looks as though the parameter to load_nls could be made const safely
as it is just passed to try_then_request_module() passes it to
__request_module() which just passes it to vsnprintf() to construct the
module name.  There does not appear to be any maintainer for fs/nls ...
--=20
Cheers,
Stephen Rothwell

--Sig_/SNLc3YH5=1GospBWQy3z/qr
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmS4gVwACgkQAVBC80lX
0Gy/8ggAoUGb9kyA06ycG74jKmmoNg9T4v+DDRjTyycfFIKih/2MxKXu2VJucbLJ
WYiawBAi8eFUGNLwkYv/bczyT1fjGsN1w7bz48NDiesjgY/rZy8igqZRKCHanpxc
RWCd6R+hvFRJlZZJ2akPqZdjatNzcluRodxiTDcFJ3fFtqmy+dpZHwcuaJXqmuvw
lOtghx7+zlL6POxVkRxbDuV+VdOAxHblSbjp65Nud8lzjZaLOWJhlCjpw0DtWUpv
x6YxApKzH7ua20roGBHef39hxy/9KQUr6pdckMp2YUUGFw2VIxomfrWiRQ+DJ2+C
0CPNnq9jsapNYODYVX8eBjz6o6Xm6g==
=pYt/
-----END PGP SIGNATURE-----

--Sig_/SNLc3YH5=1GospBWQy3z/qr--