Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8925359rwp; Wed, 19 Jul 2023 18:30:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlEU2Rgq89hmu2N9hfBDzkzI7BFc2FlOUYneNE0weTLK04naF8U6upyPXrB3pKcsG7muVL50 X-Received: by 2002:a50:ec97:0:b0:51e:527:3c64 with SMTP id e23-20020a50ec97000000b0051e05273c64mr3900663edr.16.1689816639369; Wed, 19 Jul 2023 18:30:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689816639; cv=none; d=google.com; s=arc-20160816; b=1D6FoZO+1nr+jvE3IMoUJefnP5TGaRiOwaYGWrFThHwZcRCFCBeHTOl5CPphBBPUWd fNAz1W28+195JuFAlOjI7sc8700ScUkkUsqIT9OQ3rAg5XWsluV01w0NqbVWAC0+WuxG LKJ+z5Y20Zao2VHsIDTJ0Yi7ctb8A1vBCGZCHnIHBJ1m345NJg3Tncxpp8GLNrlF47Jz rI5JwHCfIFvLEJDOD+9ofVLEWtBMll47zmf3AzOmdLlrkdA9FK0CC3IzLePWsQw5ADMs 1rIV/gHIVs5WA6PNyx4d5yFCtkbk3kiD4xZvFx0bW2fCPbXNV889dGrFEq9M8ZRQQo9Z FwQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=LfUF9ZhH9pFwsiMhXc+/2cqBqLy7keH0umsg+6P4TXo=; fh=s6jPzSUme9pAUU44m/AMblHVpjo/wHlfze2Ewt6AjGM=; b=xXNINHFfEsVvG7OQjcZX5C5WmI1pAN/31W6hDoWlkrzhzeKWjStCJ+eYLwabOQfelD OgFjgux7sQc6VEjhZIJEiKEogje+qakpND7y+FfhrJh54WehxmRCPJFNih2MS0P22Fug Sy5vgqchUr9wzjkdVgkWe0DdCVgHNpGLtJ4/dPA/gpgdMDsWNT842mQAoXXJ1Tpuw49q r5S1zBOVY25XbHkiJgPmYhomPnBfl8iWzZm2g+2oKjz8JXBdxSIMuiQr8XhjZ+TaYCCu 5cCHmop2b6qhojVfIvXTLEdRaYzzp1t3e2VyhF7qLSpKbSCwhqWw+n73Fk9FzphKHmKP fKHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=T1Bu1+Ov; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba27-20020a0564021adb00b0051ff079dcdfsi10322edb.623.2023.07.19.18.30.15; Wed, 19 Jul 2023 18:30:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=T1Bu1+Ov; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjGTBA1 (ORCPT + 99 others); Wed, 19 Jul 2023 21:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjGTBA0 (ORCPT ); Wed, 19 Jul 2023 21:00:26 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A029692; Wed, 19 Jul 2023 18:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1689814824; bh=LfUF9ZhH9pFwsiMhXc+/2cqBqLy7keH0umsg+6P4TXo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T1Bu1+OvHepCre2l6Kv6kJ9sQaSAGxMsnPqeatADFAnWkScuEMXJoz6L+arMgNj4U R20erCgI1MQ8dTMKL18WuMy37GmWpSFFcDQy0SdhM8hiP2MivEpwaNhgTLq9Xdam+c 0Y+k+I2owNnjrYtAg3ucbM9KTcRfZ40oFT7iB5WuF/Ldsl7e1szfbTJfkbq4rNruJ4 e7o3XKye3H2Issf7OZja1+MtR2u0quguR+Cr/9hW7IasSE4/neVA0WwgBxzwoDETE4 bXl24vYvfF6qQQa3AJ19qk3iDoEWKxc2CEIZqsTake2LzEnhPHBQzGnPzz/8BTwecJ SS9O71NljDTjg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4R5vVv6dLmz4wZn; Thu, 20 Jul 2023 11:00:23 +1000 (AEST) Date: Thu, 20 Jul 2023 11:00:21 +1000 From: Stephen Rothwell To: Steve French Cc: CIFS , Winston Wen , Linux Kernel Mailing List , Linux Next Mailing List , Luis Chamberlain , linux-modules@vger.kernel.org Subject: Re: linux-next: build failure after merge of the cifs tree Message-ID: <20230720110021.3f2f9457@canb.auug.org.au> In-Reply-To: References: <20230720103540.0436273d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/FIrPqV5zDJ.FH04/BPP=TU="; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/FIrPqV5zDJ.FH04/BPP=TU= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Wed, 19 Jul 2023 19:47:42 -0500 Steve French wrote: > > Winston had an updated version of the patch - just replaced it with > his updated one which does a cast to (char *) >=20 > ses->local_nls =3D load_nls((char *)ctx->local_nls->charset); >=20 > But as he noted in an earlier email thread: > > Perhaps I should make a change to load_nls() to take a const char * > > instead of char *? If this make sense, I'll do it soon. =20 >=20 > which is probably cleaner s/probably/definitely/ ;-) --=20 Cheers, Stephen Rothwell --Sig_/FIrPqV5zDJ.FH04/BPP=TU= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmS4hyYACgkQAVBC80lX 0GxH8gf/Tx5aW0j6Mj4Q3aumRfNgl8nFIUfWng73joDDPna1bV9ck4lD2PaTbcgQ FhK9et4v/hkYfhjcmqern74/rlueEjpMa6+k1cf5Zrl8fzsWv8CirTJ7FfcPDJJP GjYf+jEyG6+V63RcOu97DriNKQ4CsIHto3LPvtygG2JCUqJWQ1YvetpiLo91iQFa CDweL6LLEteaUdwctceikPv9vNxcpo3+gR9pMjtxCu/VlIHviyduZ/mHEUZF1X7h Jwj3O+ikbpNZ5r4mxdruWp5C/0OXmSog1Yk04iZjOWzRFzb4jCBBgCFcsQKq6u0A TWL7fn9eL3QgP2vMPXxh2765MK/6wA== =oC+X -----END PGP SIGNATURE----- --Sig_/FIrPqV5zDJ.FH04/BPP=TU=--