Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <694be793-7917-5498-67fb-fd0b57b5a3df@redhat.com>
Date:   Thu, 20 Jul 2023 09:36:23 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] netfs: Fix errors in cache.h The following checkpatch
 errors are removed: ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar"
 should be "foo *bar" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo* bar"
 should be "foo *bar" ERROR: "foo* bar" should be "foo *bar"
Content-Language: en-US
To:     huzhi001@208suo.com, idryomov@gmail.com
Cc:     jlayton@kernel.org, ceph-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <tencent_4A53697595E9D930D4AE5727D5913360DB0A@qq.com>
 <071ee91b1fade5bc4de45f3e33f45f5c@208suo.com>
From:   Xiubo Li <xiubli@redhat.com>
In-Reply-To: <071ee91b1fade5bc4de45f3e33f45f5c@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi ZhiHu

This looks good to me.

Could you restructure the patch title and commit comment ?

Thanks

- Xiubo


On 7/19/23 19:10, huzhi001@208suo.com wrote:
> Signed-off-by: ZhiHu <huzhi001@208suo.com>
> ---
>  fs/ceph/cache.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ceph/cache.h b/fs/ceph/cache.h
> index dc502daac49a..b9fb1d1b21a1 100644
> --- a/fs/ceph/cache.h
> +++ b/fs/ceph/cache.h
> @@ -14,11 +14,11 @@
>  #ifdef CONFIG_CEPH_FSCACHE
>  #include <linux/fscache.h>
>
> -int ceph_fscache_register_fs(struct ceph_fs_client* fsc, struct 
> fs_context *fc);
> -void ceph_fscache_unregister_fs(struct ceph_fs_client* fsc);
> +int ceph_fscache_register_fs(struct ceph_fs_client *fsc, struct 
> fs_context *fc);
> +void ceph_fscache_unregister_fs(struct ceph_fs_client *fsc);
>
>  void ceph_fscache_register_inode_cookie(struct inode *inode);
> -void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci);
> +void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info *ci);
>
>  void ceph_fscache_use_cookie(struct inode *inode, bool will_modify);
>  void ceph_fscache_unuse_cookie(struct inode *inode, bool update);
> @@ -76,13 +76,13 @@ static inline void 
> ceph_fscache_note_page_release(struct inode *inode)
>      fscache_note_page_release(ceph_fscache_cookie(ci));
>  }
>  #else /* CONFIG_CEPH_FSCACHE */
> -static inline int ceph_fscache_register_fs(struct ceph_fs_client* fsc,
> +static inline int ceph_fscache_register_fs(struct ceph_fs_client *fsc,
>                         struct fs_context *fc)
>  {
>      return 0;
>  }
>
> -static inline void ceph_fscache_unregister_fs(struct ceph_fs_client* 
> fsc)
> +static inline void ceph_fscache_unregister_fs(struct ceph_fs_client 
> *fsc)
>  {
>  }
>
> @@ -90,7 +90,7 @@ static inline void 
> ceph_fscache_register_inode_cookie(struct inode *inode)
>  {
>  }
>
> -static inline void ceph_fscache_unregister_inode_cookie(struct 
> ceph_inode_info* ci)
> +static inline void ceph_fscache_unregister_inode_cookie(struct 
> ceph_inode_info *ci)
>  {
>  }
>