Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230718153348.3340811-1-chenhuacai@loongson.cn>
 <261edc6c-e339-faeb-3045-bfe6604d1aef@web.de> <CAAhV-H5nNMmYZQXvoog85cgMUd+gM2QMaG3cUhYk_iGzjB=B4Q@mail.gmail.com>
 <f9e7fb54-a76e-a9b0-1b9c-8c9251f4af20@xen0n.name> <281c5d5e51488ce51497072c1e4304d71af141ec.camel@hotmail.com>
In-Reply-To: <281c5d5e51488ce51497072c1e4304d71af141ec.camel@hotmail.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 20 Jul 2023 09:39:41 +0800
Message-ID: <CAAhV-H6JAsR+1jK6BsEfOqf=uee3kj2=Fj3LSW0oUfhSo-vYiQ@mail.gmail.com>
Subject: Re: [PATCH v5] LoongArch: Fix CONFIG_CMDLINE_EXTEND and
 CONFIG_CMDLINE_BOOTLOADER handling
To:     donmor <donmor3000@hotmail.com>
Cc:     "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
        "kernel@xen0n.name" <kernel@xen0n.name>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "jiaxun.yang@flygoat.com" <jiaxun.yang@flygoat.com>,
        "loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
        "chenhuacai@loongson.cn" <chenhuacai@loongson.cn>,
        "guoren@kernel.org" <guoren@kernel.org>,
        "lixuefeng@loongson.cn" <lixuefeng@loongson.cn>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "loongson-kernel@lists.loongnix.cn" 
        <loongson-kernel@lists.loongnix.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 20, 2023 at 9:35=E2=80=AFAM =E2=80=8E donmor <donmor3000@hotmai=
l.com> wrote:
>
> =E5=9C=A8 2023-07-19=E6=98=9F=E6=9C=9F=E4=B8=89=E7=9A=84 18:29 +0800=EF=
=BC=8CWANG Xuerui=E5=86=99=E9=81=93=EF=BC=9A
> > On 2023/7/19 15:22, Huacai Chen wrote:
> > > Hi, Markus,
> > >
> > > On Wed, Jul 19, 2023 at 2:51=E2=80=AFPM Markus Elfring <Markus.Elfrin=
g@web.de> wrote:
> > > > >                                                    =E2=80=A6, so =
this patch add
> > > > > some code to fix it.
> > > >
> > > > Would you like to avoid a typo here?
> > > >
> > > > Will any other imperative change description variant become more he=
lpful?
> > > Thank you for pointing this out, but since Zhihong is the original
> > > author, I don't want to completely rewrite the commit message, so jus=
t
> > > fix the typo...
> >
> > AFAICT the commit message is totally uninformative even if "an
> > imperative change description" were used. It basically:
> >
> > 1. repeated the patch title,
> > 2. spent one sentence only for mentioning a function name without givin=
g
> > any more information,
> > 3. mentioned why some change was not necessary due to some other
> > existing code, but not explicitly calling that part out, then
> > 4. finished with a sentence that boiled down to "we should do the
> > similar thing".
> >
> > My take:
> >
> >  > Subject: Fix CMDLINE_EXTEND and CMDLINE_BOOTLOADER on non-FDT system=
s
> >  >
> >  > On FDT systems these command line processing are already taken care =
of
> >  > by early_init_dt_scan_chosen(). Add similar handling to the non-FDT
> >  > code path to allow these config options to work for non-FDT boxes to=
o.
> >
> > Would this sound better?
> >
> Xuerui's take is fine. Do I need to make a v6 patch?
OK, if you have time please do that.

Huacai
>
> donmor