Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Yu Kuai <yukuai1@huaweicloud.com>, mhartmay@linux.ibm.com,
        bblock@linux.ibm.com, bvanassche@acm.org, hch@lst.de,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "yukuai (C)" <yukuai3@huawei.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sf9j6ztm.fsf@ca-mkp.ca.oracle.com>
References: <20230705024001.177585-1-yukuai1@huaweicloud.com>
        <d112d30e-d144-4c76-db98-5de4767f5945@huaweicloud.com>
        <ac099071-a16d-46a4-a1b1-2cc786a0a337@kernel.dk>
Date:   Wed, 19 Jul 2023 23:13:44 -0400
In-Reply-To: <ac099071-a16d-46a4-a1b1-2cc786a0a337@kernel.dk> (Jens Axboe's
        message of "Wed, 19 Jul 2023 10:34:11 -0600")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z/+/xcPaKVDtXYgTMnXndJcyJj8MG84WDJ/Ll0xvNQAwm9z4efTZ+IYxQZMP?=
 =?us-ascii?Q?Lhxhdshvm7HCqymAYn3lGPGhFzhYEh3Cyi5GRF5m7Ooala/6SPvaAQ6zm0bV?=
 =?us-ascii?Q?q1eWCiaDIiv0VPbucCBtP8cGZ7KBziyx5LWeBDjKPLY0OtBqwtGPzKQTbXA1?=
 =?us-ascii?Q?265tN+ATbq3I3W5+R1PlE0VjtIDgbsEcu7UhAIbP7xom0Jodgnu1uVbNmC1H?=
 =?us-ascii?Q?nIe6KwC1r4FyE5iFgxe2GPqdnM2kSkgk5qkWYF3z7ITr6ujPt5cUlH84cOAF?=
 =?us-ascii?Q?+HSdiFMBCLCwkYZ0tqHGoXkh+pGf6cOoWvhdDJzQtUuQRV8SQ72XnG0igPr6?=
 =?us-ascii?Q?wYpk/1N4/6AKz3MUJ2NWCpTIbg3YWM8XuX2gQDFJXfIsScOyapeFrl1v290L?=
 =?us-ascii?Q?uFGtp68jlec+VuGSarUVeQrbA/fjGQp5bXeHIxymMhBMeOYkmmLm0nXnO/RA?=
 =?us-ascii?Q?nVPvtFGxCEiOkOOSXRQaEndLj4agRMqxZuMbTkFG9wB9wSaahtLYCDngQIkQ?=
 =?us-ascii?Q?Cdyb9oBwbZGbKyYxVCTud+V7y1Utc6w8G60Bp5zYPHFpR6aeqjYWOaNYFEzr?=
 =?us-ascii?Q?O8KdlqRSYx/37/X3ThdZIPRGVuc7q4rwYbdfNjwhA6/2EltEH66T2pEE19hY?=
 =?us-ascii?Q?1qFViMrvKMg3vot4gz1vHA/WdgTs+fdObdkgDLga0OIikOE3ki/XIcylqvS9?=
 =?us-ascii?Q?iltLBN8E4gZXDWpWeqwWkuU6QF3dw27gPO7qirztaY7dy4avgfbyDC2wHiBo?=
 =?us-ascii?Q?BppohXZ5MM7zxvEZgGLK2y3BkjodtJWFneqB8rQzMfUVRp8HydGKpzpmxkMr?=
 =?us-ascii?Q?wVbuj4so2RNE09XnrJqOO1D0X325V7sp62SOberlS1UhBPiRGXjTtnWZmpdq?=
 =?us-ascii?Q?r/P7p11j0+PYyozJmUh03HFfqdgnSgGlkGB5W+WgeFJH6OE6+R0M3f42t3K7?=
 =?us-ascii?Q?WyvMNg1qSUtFlNMLzJuqKEO/t0sixILwbZC1x47lz6u3q95ycdgJJOU1+zHf?=
 =?us-ascii?Q?kqgY+qZFI9tZ1/vI/PtCrIwy3cqyLz3bdzIZKSn24RriEmDXLmWT2MJYXjOV?=
 =?us-ascii?Q?LQxzaGjiDxXIgeERokGvw0op4b4tX38Ir6Zt9rBfHUaQwufXURH6bSbNLG1w?=
 =?us-ascii?Q?Sxy8OoATNApOup1orEspe8MbYMZAg1YbKsl2oBwcnnXZOjL/E1PON/0O8Fgq?=
 =?us-ascii?Q?zY098DQOMiUVj3wq73ZbQggerS+WfeVBuaXc+ZShhlNlP1wVY7Yrdo3hl6db?=
 =?us-ascii?Q?+Gxr5VLF7UzPStYZGQTNXdyzMjphDY1se7NqdVV0B2/PiPtkWsEOgeKWbH7h?=
 =?us-ascii?Q?mw4ClxwAR4UinYM+Qgk/2N8AQK+oCNv6quRVwF+kqQUGh6WcJ3V9jmA2Xgxn?=
 =?us-ascii?Q?P2lLrBveL7HIMDtRWjMM3bM5DpmeoITFcIcfx2El/8aVGHyeaghQ3B0LRT4p?=
 =?us-ascii?Q?lH8UAepyjwj9MvY2gNOm5TvRw3txYjOOxvsyQExErZm3m594iBfar4LkpgKf?=
 =?us-ascii?Q?LpD1cDrr9o3xqKrHzkxpXnWOBgJQdpMByAvsbccipRoKIX2i5/oA7xaw8UFm?=
 =?us-ascii?Q?NyTVaUNcoamd+fSQ8NjNdjGCRxt5MneZkkVvKRIMCf/YhfW3uGi45omdlI2u?=
 =?us-ascii?Q?Rw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?SUhg2yhuTDLrabB7m03+Gyiovazw4s5K+J87CtdBCIMQxeinPWm/yeaJvG1L?=
 =?us-ascii?Q?2jmQ8m6V6mcQV+dkGmIqc6uo1Hrk+gN8FC1bjQnQkcElLcxIAUwf/IafRncX?=
 =?us-ascii?Q?0XtkMET5LZOydVWV4vX889tmJAU7CvgfgZcBsOiiM6iTmcWzDL+szTv+woqm?=
 =?us-ascii?Q?3YfHwYYxZ+Y7jnZFvz3CbYOaQx5djkuuKOpgvvN3uOtXZ8zI0sYgj3KpIOHG?=
 =?us-ascii?Q?nWr9PIhjlcf1iiLy11LrgFLeO8HgtPVYgPQK6USQFjKONv2rbwc1kJA4DVZc?=
 =?us-ascii?Q?5Bpg/UuT+lZzjZUncmke+SXqP+ejoi8CfgcYhgqxAYV/q9zBAP8hydgQ/+Lg?=
 =?us-ascii?Q?r0cjsbmfjyrUXbznwLxSmKtZeNSen7r/hmjnbBR1DLOlRUoHfF4ZKnEkUk2/?=
 =?us-ascii?Q?RHrXtlE7U5y8cd7JEB5kHOXcvL04FcViaBv0+LGGe8OF2pHsGkVGefc6IV/n?=
 =?us-ascii?Q?j1TyhgajAhAN71gHBsm0KIAknuSehHXBSm+8AByGmS0H66MoE7l0BidY+Mlu?=
 =?us-ascii?Q?tkLrbAApCbXo1efQiOJPNDAbMuduZX9MRnm61lVQE5UBvNcP4Pjt+85Z7BvE?=
 =?us-ascii?Q?zCoAuUNmHNPnfNdxnIf+WAytF2YZU11ub9n6ezJtphSGl1cQEKPPXT5/y2G2?=
 =?us-ascii?Q?ax1aKg/hn5764jAJza0XXPC9PZhrb90hp5BTFzkVJhVjpr5Pt4uwMy9yWGH9?=
 =?us-ascii?Q?XLfLq8OudURgRoDISzXQLf6crMkt68wsDMVKTqObUJV+rUiXJQNBzSs27Gxg?=
 =?us-ascii?Q?z349sy6fss+N90dky26CZxF82s9KsqPf1Ovdq91ZH4FM0sJlotoZtkzoVdjt?=
 =?us-ascii?Q?SqDfHSTHYWQn15ucopr8TBrk0E8AfMcsmshLdWzrLajBjhbJOclswqHwHVDN?=
 =?us-ascii?Q?83gG6SgaNxA/fYeUohM6u4bjti0l0xDmzitoZ0fPaywk8BwcwV6gGQiIQ6WO?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ddcec67-95c6-4ec5-e232-08db88cf56d9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 03:13:50.0633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k27ZVOtVf3Cve50TJgLxJMZVd8RBLk8ltzUKYqqGyNCMh+Nuzpu27rPYz3mhGWhwVsAY+BjCWzUtuUZcfNWEK84RIEJ0/M19FHD89+EIxt4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6615
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-19_16,2023-07-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=764
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307200024
X-Proofpoint-GUID: pS8t8X797ekAYYVZhIfMhFFWAxL5-Xh0
X-Proofpoint-ORIG-GUID: pS8t8X797ekAYYVZhIfMhFFWAxL5-Xh0
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Jens,

>> Sorry about the trouble... Can you apply this patch? I notice that the
>> original patch is applied to stable.
>
> I can, I had assumed that Martin would pick it up on the SCSI side?

Ah, but since the offending commit went through block I didn't have it
in SCSI until I set up the new trees. Now applied to 6.5/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering