Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7bd3ef7b-a4dc-6d0f-6d58-66533de292cf@alu.unizg.hr>
Date:   Thu, 20 Jul 2023 07:03:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PROBLEM] selftests: net/forwarding/bridge_mdb.sh: 'Command
 "replace" is unknown, try "bridge mdb help"'
To:     Ido Schimmel <idosch@idosch.org>
Cc:     netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ido Schimmel <idosch@nvidia.com>,
        Petr Machata <petrm@nvidia.com>, linux-kernel@vger.kernel.org
References: <6b04b2ba-2372-6f6b-3ac8-b7cba1cfae83@alu.unizg.hr>
 <ZLffjNMaJZiGJytj@shredder>
Content-Language: en-US
From:   Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <ZLffjNMaJZiGJytj@shredder>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/19/23 15:05, Ido Schimmel wrote:
> On Tue, Jul 18, 2023 at 09:02:31PM +0200, Mirsad Todorovac wrote:
>> Command "replace" is unknown, try "bridge mdb help".
> 
> You are running the test with an old iproute2 that doesn't support the
> replace command. The following patches [1][2] skip the tests in this
> case. However, you will get better test coverage with iproute2-next [3]
> compared to the version shipped with your distribution.

You are right and though I was using the latest iproute2 from the
Ubuntu 22.04 LTS and 22.10, the iproute2-next had unlocked the test suite.

> [1]
> diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> index ae3f9462a2b6..a1bd4900acb6 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> @@ -1206,6 +1206,12 @@ ctrl_test()
>          ctrl_mldv2_is_in_test
>   }
>   
> +bridge mdb help 2>&1 | grep -q "replace"
> +if [ $? -ne 0 ]; then
> +       echo "SKIP: iproute2 too old, missing bridge mdb replace support"
> +       exit $ksft_skip
> +fi
> +
>   trap cleanup EXIT
>   
>   setup_prepare
> 
> [2]
> diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh b/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh
> index ae255b662ba3..a1c4aec4cbb1 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh
> @@ -1328,6 +1328,12 @@ test_8021qvs()
>          switch_destroy
>   }
>   
> +bridge link help 2>&1 | grep -q "mcast_max_groups"
> +if [ $? -ne 0 ]; then
> +       echo "SKIP: iproute2 too old, missing bridge \"mcast_max_groups\" support"
> +       exit $ksft_skip
> +fi
> +
>   trap cleanup EXIT
>   
>   setup_prepare
> 
> [3] https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git