Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ying Liu <victor.liu@nxp.com>
To:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "lee@kernel.org" <lee@kernel.org>,
        "daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "deller@gmx.de" <deller@gmx.de>
Subject: [PATCH] backlight: gpio_backlight: Drop output gpio direction check
 for initial power state
Thread-Topic: [PATCH] backlight: gpio_backlight: Drop output gpio direction
 check for initial power state
Thread-Index: Adm60FHbZeccRsgE2UutMj3nHgFTFQ==
Date:   Thu, 20 Jul 2023 06:06:27 +0000
Message-ID: <20230720061105.154821-1-victor.liu@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?F+kezKhQvfjE7O7PoVgx2n/HvE+EKRU3/fOUojW7HSSmPBi3fyJn83zM92?=
 =?iso-8859-1?Q?l0+Il9BWRsgV+8zzBq0Q3HJaI+FMpxZZlVHKuf0xcFFwm09daPdJJN487J?=
 =?iso-8859-1?Q?IDnNTDAcGwCMXjGrNciA8FWDhwkeN/pudcxQGW4AECd7xHL/0eAENNbavi?=
 =?iso-8859-1?Q?HFX4rvvmhj/+q3rjbi9Q91jP9jJQeZdHa6CPe5j2O7jPshUo1VlsNHFH5g?=
 =?iso-8859-1?Q?AmDEoQiV7eT7IRj4kCZyICRQHNlY/bvZEw80myOc3c5fUxaiacT3bqdoRo?=
 =?iso-8859-1?Q?C+Yn5CSqmO98YPQRoQ8V9ZOLOq2XtbDpZ79CtUJ9ym52QGkmxZHjCEnkEA?=
 =?iso-8859-1?Q?rzArM1wVV+WcHe44SF9hZKqhcJyzpRETVOo5m60dbmnPRgXgDtcZRUDFXK?=
 =?iso-8859-1?Q?G3GMywdje7JZvJDEmx1MnNw6lYxTXCN9JNS7cVEALSMwAF6W/zEtvWMzwg?=
 =?iso-8859-1?Q?PM9AVUmhzWmffgPiTyVGQxINFR6Dlk6XpRMQqCaydWDq7Vsarw/lfxHysG?=
 =?iso-8859-1?Q?qV5ITwvKxCX+TnzUAhmcejMfcsp5byg5XbGxAd/xz9iuW0M0oNvnezjRoJ?=
 =?iso-8859-1?Q?bnlkgxqD3OCrPnaU9xdBUr/S1Sef8YCSe8Spkac9coyfEfF4/97TwCLClS?=
 =?iso-8859-1?Q?vCCH5SNQcfNSoDkGqQU31HPfU6miRD8cW3UGntInXtyO8+F4EyE9aICl42?=
 =?iso-8859-1?Q?lOfahJPbG9rnPqFT8Xih6SAZ2DUC+OoUoLsZ1lexNYkFEhA6PVfGEn1jw3?=
 =?iso-8859-1?Q?ay5CSS1+ddEtC/4sZRfvYHffFMgKrwM0FJRLvhtdgxCs/3lJJlU4Cy9aly?=
 =?iso-8859-1?Q?U02whpZpPo1XvaLgPxaHgsNoKXjgGVsf14gQayMkDlLgdMNFWP46YWufZp?=
 =?iso-8859-1?Q?rR0fZBc25+SPMAJWf2DvpdsL1UbTCnBhLHSK98hxE0rQGEW0ewqIAUU8tG?=
 =?iso-8859-1?Q?xmvGykq5BEpM2wCymsoQahBXjWEks82X8u81a43m03q+kKDkpJL6J0+nUV?=
 =?iso-8859-1?Q?C9NX0uhy+aqA5OWPsN3S6RTI8awq/WqjJ6Jnfr7f2QcFsJWZavjW8Fdowk?=
 =?iso-8859-1?Q?w3WPrted1xwpdgN7ArB3gGvzvU4txzPgHdhro79T6sKWPyvuy/hpWHNkXP?=
 =?iso-8859-1?Q?TnggMJmyM5+oi9sO/wdnoIgCU/D/xczPdUVR6DqGoX9FDttMPeoeaWTUlo?=
 =?iso-8859-1?Q?+j3TO0ijOvzrNSO5t+2b2FguvZNUu+q2LiQDrCV5Bb1RHWQrbSuOjx5aHy?=
 =?iso-8859-1?Q?pS3DtsjSbbsS55qAEdU06ROsZFcPyb11vOOw4Ml9yK1okvEOlshd7vUaSJ?=
 =?iso-8859-1?Q?2aNy2Dfcr24vCuVz9LbLrDz8LMbw2WDIRxL92GUkdrYXgz1VCFiF1gEjEL?=
 =?iso-8859-1?Q?FlQx0BQVNNkObm+SWo4jfiYB8R4gm9yq2Lxem4UHvrvRNOn2s+IpJ2CMhN?=
 =?iso-8859-1?Q?tSz8DWrILWZVyqE86w6qjHVbIIbMt8JJLB9zL83PbPDsAvkQ25GM1p89ax?=
 =?iso-8859-1?Q?9/VyI2POr/aoHThtJom0HFu1tLyixv1oiEwNOyq3wcsHUPSgiD6t02kVgc?=
 =?iso-8859-1?Q?jHr3Ti2sqJapkdSOz+B9u7w6Moy/ShlHSuk2ZWbCDNTahx0l8DpHoOfYbs?=
 =?iso-8859-1?Q?PtYnBDyqRjaaANmIZ+e30cjDLJ9Q4aDBZy?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: baa8725a-638e-4f07-15f1-08db88e7745d
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2023 06:06:27.4071
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ThPnhan1QMttfz+cGMSJLzZyL0KUWxHxYHQNPabgS6BLIxQRA8MQ+e5Cn9X5HDNq/J9WoT4ebmdgZQJgk6bkXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7923
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Bootloader may leave gpio direction as input and gpio value as logical low.
It hints that initial backlight power state should be FB_BLANK_POWERDOWN
since the gpio value is literally logical low.  So, let's drop output gpio
direction check and only check gpio value to set the initial power state.

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/video/backlight/gpio_backlight.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backl=
ight/gpio_backlight.c
index d3bea42407f1..d28c30b2a35d 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -87,8 +87,7 @@ static int gpio_backlight_probe(struct platform_device *p=
dev)
 		/* Not booted with device tree or no phandle link to the node */
 		bl->props.power =3D def_value ? FB_BLANK_UNBLANK
 					    : FB_BLANK_POWERDOWN;
-	else if (gpiod_get_direction(gbl->gpiod) =3D=3D 0 &&
-		 gpiod_get_value_cansleep(gbl->gpiod) =3D=3D 0)
+	else if (gpiod_get_value_cansleep(gbl->gpiod) =3D=3D 0)
 		bl->props.power =3D FB_BLANK_POWERDOWN;
 	else
 		bl->props.power =3D FB_BLANK_UNBLANK;
--=20
2.37.1