Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d045caf-2d83-047d-654b-03609dd91226@gmx.de>
Date:   Thu, 20 Jul 2023 08:16:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/7] vgacon: switch vgacon_scrolldelta() and
 vgacon_restore_screen()
Content-Language: en-US
To:     "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
        gregkh@linuxfoundation.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20230712085942.5064-1-jirislaby@kernel.org>
 <20230712085942.5064-2-jirislaby@kernel.org>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230712085942.5064-2-jirislaby@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:veCzuI3kDCg=;fnRmKSxZXEjl/taCOx7paUHzly4
 6XIDPwcabiiLuhF8P9PH0QhJ2joy9vduzgs2TBQiObO6tMDmEpeyxoMK+3D0xNJisj9uzOPKy
 nIpe0/ks4u5epwpY/INb08DS3by66ee73PqhUdzjtlX5giddyP8YE8AfvhcCTzGj8N2nwsLm0
 Q34prT4RT9+z0tIVHsR32na/yCLqeFtIqXs4eO5/DBpCz21+FSOxjBlFssyVkTHcPRgKwXYPO
 bd1YBu9PQL9oTrlUUVejFwtNv6TAIt+joOo9ANKe7wsfoq7CHHCu39Qna5whFwStbjCCwj2Ow
 bKh33Vs/e/Va+/hBq8jN31WV7YhCu9vPWnaMdRp9xDTfvdyjwRRBvxkrnEHTlBzhkqOHn2N5A
 41Lm2fM0DbqgFBoeygWj7X2fPzmtNkYzRQuwNbl0q0lbQsYnVgd0GCM6vz8jFcr5egJ9TD0pV
 d36IDEvKmbDcxauweuklHaoZeTPWkYBBpaY2rSpwXPAjFUEg/JZhPDhyY4Hzq1Gxh+g6zpYq9
 BaXIdm1yhhEz/vcr+DAipEITQB6J5NPlpKJtWIAHhnKbr0FonuqZ8P05BsYZYTIQ1j+v8aho9
 cULpRquSsxNDzjbtWvTv7qr9El2WO1qyiFAfrxOSXz5I2aWY9HPgNZJVKRYSpIcNPjxPTagXl
 ZdPwWX5cOwJDBMVEkdsSvBZPSVHhy7MTJpCk3HyoQzTsVkZTBiqUrQR5J6hlOb+yBDViILNvt
 YvgcU3kMNL1wyZIaRpjbKu+cKrOjVJuFUxeJIsssT1SifMuhrCCBAVh0A3ww+pVf5w3wN+iQd
 KkN9/K4qyJZq8Mqfhl+Iol92FIb5qJRdAG2DQu0Mse7eaPKybkMLsXK6YbzOYHcUAIOmzMFMQ
 SREHPu5bhH181wkGmmLEIP/6ZBSdKB4MBgix/EwCT5eAvoT4VfIYulomX40JHvAgKFPiYNx+3
 XHk2ZA==
Precedence: bulk

On 7/12/23 10:59, Jiri Slaby (SUSE) wrote:
> Switch vgacon_scrolldelta() and vgacon_restore_screen() positions, so
> that the former is not needed to be forward-declared.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org

Thanks Jiri !
I've applied this series to the fbdev git tree.

Helge

> ---
>   drivers/video/console/vgacon.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgac=
on.c
> index e25ba523892e..fbed2862c317 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -142,12 +142,6 @@ static inline void vga_set_mem_top(struct vc_data *=
c)
>   	write_vga(12, (c->vc_visible_origin - vga_vram_base) / 2);
>   }
>
> -static void vgacon_restore_screen(struct vc_data *c)
> -{
> -	if (c->vc_origin !=3D c->vc_visible_origin)
> -		vgacon_scrolldelta(c, 0);
> -}
> -
>   static void vgacon_scrolldelta(struct vc_data *c, int lines)
>   {
>   	vc_scrolldelta_helper(c, lines, vga_rolled_over, (void *)vga_vram_bas=
e,
> @@ -155,6 +149,12 @@ static void vgacon_scrolldelta(struct vc_data *c, i=
nt lines)
>   	vga_set_mem_top(c);
>   }
>
> +static void vgacon_restore_screen(struct vc_data *c)
> +{
> +	if (c->vc_origin !=3D c->vc_visible_origin)
> +		vgacon_scrolldelta(c, 0);
> +}
> +
>   static const char *vgacon_startup(void)
>   {
>   	const char *display_desc =3D NULL;