Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9216562rwp; Thu, 20 Jul 2023 01:04:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlEYgTorHKmU/GVjk6P//Eoi6nEFnF0BZ2k/E2oojMiJJT9k5RtT7eEYXnKc+MRhhzVauLjQ X-Received: by 2002:a05:6a21:6811:b0:133:c9d0:75ff with SMTP id wr17-20020a056a21681100b00133c9d075ffmr12505400pzb.42.1689840286931; Thu, 20 Jul 2023 01:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689840286; cv=none; d=google.com; s=arc-20160816; b=OiruJnzrMk0vXwwyBerMZeE9r6Kh+t0dy1kEd1M+YdV2OzdYE4pHruj2ulz/qAhLR6 xUEQg5tC+2MA8uwLCjD1ENO6T2XJukTFLNJsxzNpvLFGEnMPuzWz7o5/bHmoQQUA1RxF IsupkSs78KKGdLJWqChtotNna53xhO/ocI+aotzzibnLQn/B3xthPfnHNyaV+jWDMPZa 7ggn+4qQ/5h4aIwyaMyubc4cuhSd8IqH6Frjf/KHRsAwqed+vnV3cfJYD8HlkxDWcWP0 ZEPwPpcHJ+f11/1QI42CaisDJFOfTPJKdqaTy5Aoybs7pbeB2EVUeQxzd6rWCglWEsmG FMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sEd+sy2amDGgLLugpD3SukQrlvn/3nTuy6vZTRpyND0=; fh=znJ/+xsNiUMsrKcIV4AU88AmxTDq6inGAqNdrhmyYF4=; b=Ul1fr5SGHYR547lKllaZevTgdFTYHh75bYhMQa6c2LvbHosZTaPLd8OeWla0t3Kf6t 30JJY2D8SWZYiWPXSYKrwPJn8JnJctWgox7gtReL9ZQEXrXBvk2PmJtv88AbwBr24euY vUCs5eTwQ3Zi3dU97up48sUtvOQJOaGK8YlAfAQfnkhwbvvmIOjRTa48FAYgV4dBiwCL JULp+TKsGLXrTNdzTFhCPl7RaR41sAM098dNdweVG6n87SFaS3w2YIuHmm4w/3a9r+kt feswe/thXJG6G3kIM4ozgqB95ZolygwoFwXm6PPm0nFx9NRUrNPBNCarS2uZmkIocRXH g7MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=RVHwsLzj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq27-20020a056a00331b00b00682850547afsi443689pfb.193.2023.07.20.01.04.33; Thu, 20 Jul 2023 01:04:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=RVHwsLzj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjGTHGF (ORCPT + 99 others); Thu, 20 Jul 2023 03:06:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjGTHGC (ORCPT ); Thu, 20 Jul 2023 03:06:02 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D72326A5; Thu, 20 Jul 2023 00:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sEd+sy2amDGgLLugpD3SukQrlvn/3nTuy6vZTRpyND0=; b=RVHwsLzjkQi2vE+rIbn74ECoA7 Ti6U29xIQvJhuMHIFPzDXlUg+3Wwrxj5azQwdebGMxo27KyE0CQxM1w6Cq4Y7vr5sHwrq4u+q1Lxd usOQb7MUyHDZSVKTj/PtISXeZvLFrxUbyLH1XBbbzwC6ughDOSRFXAZHA1lwV8s9rl/L6m0MRXxuo TVXOnfcCbgPrF8xS26V/hx6pJyB6768r+yilmfkwjt5n7R2O+jJr3m8S8BDDVTlUG2mddEkCpjX+0 QW79ExSdsXRt5KdsE4Vc1r+JV7czr6tQEZDwbOOF1TJ+e6CE983cqMawwnwQM4gS2RVHSyaBgwoWx PGD3A5Rw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMNiO-00A2qs-00; Thu, 20 Jul 2023 07:04:44 +0000 Date: Thu, 20 Jul 2023 00:04:43 -0700 From: Christoph Hellwig To: Daniel Golle Cc: Jens Axboe , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Dave Chinner , Matthew Wilcox , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Jan Kara , Damien Le Moal , Ming Lei , Min Li , Christian Loehle , Adrian Hunter , Hannes Reinecke , Jack Wang , Florian Fainelli , Yeqi Fu , Avri Altman , Hans de Goede , Ye Bin , Greg Kroah-Hartman , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [RFC PATCH 6/6] block: implement NVMEM provider Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The layering here is exactly the wrong way around. This block device as nvmem provide has not business sitting in the block layer and being keyed ff the gendisk registration. Instead you should create a new nvmem backed that opens the block device as needed if it fits your OF description without any changes to the core block layer.