Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <342d7c94-d04b-342e-7540-4aee6d8b03f5@gmx.de>
Date:   Thu, 20 Jul 2023 08:53:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/3] arm: Fix flush_dcache_page() for usage from irq
 context
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>,
        Dinh Nguyen <dinguyen@kernel.org>,
        linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Cc:     linux-arm-kernel@lists.infradead.org
References: <20230524152633.203927-1-deller@gmx.de>
 <20230524152633.203927-2-deller@gmx.de>
 <3e131821-7665-47f0-a8a6-44b3e4d7a88a@app.fastmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <3e131821-7665-47f0-a8a6-44b3e4d7a88a@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:YlCFrtpXflE=;3hRRdr4s1RIEwyL0Sdqrqev5V6Y
 9zfxiJf7oRMumdIdxCJRcEuPA8ue/2FbUmCAweXtjTI/qmqsT6FyiHUugSiMAtYBzyrWa8fvk
 YS0IK75AlfO1PmzVGBgVFYL0yjH2ZsKWibqMCvXbMvQBwAMsePxggLQZ7pLSsEO66thoS42/1
 oBVol9zsO+ujTYK1AG9BaSgIEeLyUPnblfG4gnOokY0VqLmIyAtM7w6Kfzuen7eZE/uHD13Fs
 zzVDFyUNbeLmNhhDifRA04TYnd/zLdkB0q4oYW5ORp/AczfqSrmx2pPZz3UOy5eIhEqmeEoMg
 dVtXxNXHvPUuaq93fzALxGHzbkAP54ZhWZkul02W8AikceDIhGJWIdLX9ZJr3zHakdy/r9kAc
 jM7hSOnPMq5qjW2ZwQr95ztsaiGlLXrZQZ+ElDcShnJZnrmC+42jzVxjPZ4RsOk5u1Fr+8mNG
 fUeAMEEzXfA9aU3SV2bZP46IDzIoSEveAfOz7FDSfaFn++czSMzmdFA18FQKSLGKKmKB/L2/F
 PZ9YCO+XhLVPWjMhrek7vBK8KfcpwO1jwwEfUH2Y8cSk8LViDK+9rDgWyKTlvMRNIeR5JBb7o
 QEpK4xHiB3r/5vY0ouU9gPP+kR3lrfnSjwt3LrOVBlqro9OQkZ2ABO4F4gZIxMqgSu9P2x4Zv
 LLC2FediH5iyACXuPDLf+b/gDwAqxbnzchvGJCGD5/7uZ6DdieIdad6EYfYXDLpnZLVAmNv0o
 mlmQKMgQmPUU7S9h4T0Bl++zuJo2vAzxLkHd2SOgj6PczyP8gLTClfL1kRt/fF7oZCqiy+nN1
 B6Ezd/yG1eox3/WByg1QQc71CKJDGDPJ2E//1prvMHtg12ivY/ABEKaRgpGgfBo/FGd+X1g4q
 1CTJBylZBC4fXEe7AYd+9e4Zhte8ZmEZqD+1T5TOFYtxg6dvdbuvT4HajEReo03oQ42CZ6iI8
 vU75KaiJIoTQiu2nL+eF/3rxqQE=
Precedence: bulk

On 5/24/23 22:00, Arnd Bergmann wrote:
> On Wed, May 24, 2023, at 17:26, Helge Deller wrote:
>> Since at least kernel 6.1, flush_dcache_page() is called with IRQs
>> disabled, e.g. from aio_complete().
>>
>> But the current implementation for flush_dcache_page() on ARM
>> unintentionally re-enables IRQs, which may lead to deadlocks.
>>
>> Fix it by using xa_lock_irqsave() and xa_unlock_irqrestore()
>> for the flush_dcache_mmap_*lock() macros instead.
>>
>> Cc: Russell King (Oracle) <linux@armlinux.org.uk>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Signed-off-by: Helge Deller <deller@gmx.de>
>
> Cc: stable@vger.kernel.org
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
>  From what I can tell, the behavior in aio_complete has been
> there for over 10 years, since 21b40200cfe96 ("aio: use
> flush_dcache_page()"). Others may have done the same already
> back then.

gentle ping...
I think this patch hasn't been picked up yet for arm.

Helge