Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5603e84b-656b-e0b2-14ef-13f4e1062552@gmx.de>
Date:   Thu, 20 Jul 2023 08:49:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] parisc: math-emu: fcnvxf: Add space after that ','
Content-Language: en-US
To:     hanyu001@208suo.com
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <tencent_86762B5284E20421D8A676F4CC1B205D2F0A@qq.com>
 <a2ae26be540da062ea4912c36962093b@208suo.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <a2ae26be540da062ea4912c36962093b@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:kLAIqU58eDM=;fkyra3ddEZ8kgnJobsX2Y9tFqtd
 LzwKuCLFp2Nx/FtwmnT1rx2cQbrYh2IgzG0MPvjZpO3y2PC4YrQXMhlaXRK2LbtwZU1mKl1/Q
 7rL+mi2XO1BFuupyBPzgA/7GaQ8XVfJ/UaQHYDx1Wa036MiZQjGgi3bxcqaFj5ptzGXBE7MO6
 JBK0ipplLLqNfcHnmkbKeg25OEo50NnBWJiwHrU5qcCd6UXlhaKBDeUywdEBG0GKQCWfSwFCf
 v3KNwHRpKGIRfi/vF8d0ok6iJvQEWXh2L7Mb1MZ+lk8dNzwqct4nEKR7gOLJuEfEKTCI7Vj/q
 XobskLGU17/jXMn1EPaRbrxnzwWkxNybq/XuEcvU7Ub2gHfMPvOtAGxwT97Vftl/sGkAK+mEM
 oE+lqmYY6rSqaXVf7qeaMEEx4X/Emr44dBMWM0bIzBqjYeFF65/GIpgGT2D8T+13OGQbWMhiF
 KA1fo2XZiX+VaYAdCu3ldKs9fD9XZQ641zz+orzzcWmTGrX5yDNiDyHIB6T5xMF81XjtK4qCf
 a0gi/WcuhmssWLptnWt2F17yFJZcxKElpzaOh4swSosd9aTL/qaq1Bnj601uMsRriaS3YUw27
 YvpeioO4AMvQi0QTaG1NvmR7AdV91d/8QKUsv2AGT7T6HY/b5pH5l2l4AWa3qZgGyKo3auffC
 9hIUjsyPWaB2o5RSlbDS4BxUMz1vNFSfDaP73qrTzONKDx62PU9KLQ0ANW86BI7PsSVvspLf9
 NrnaWAye+BmeS+jSFTCxci7SXV7dA5o/0MQJdylSZphg1Hqs6AmI5Y3AdEAutjdYJna+oVUvI
 tQuiga/aJ35p47jkS2AbiyOmkpwxTr4eDBQdLlVr1IXl53l1Kcm35AOX9k2Xq2LKaIIdo2KZ/
 ouK8xs6I0d6ECPQwHEhYjqN0TOwvKmy3wmvlXwmX/90Nm8Lf0n31/DLXSwOsmtpMc+VIkgl6i
 ip3hTNPc8G4jXETLg5pfvPeyxL8=
Precedence: bulk

Hello hanyu001,

On 7/13/23 11:37, hanyu001@208suo.com wrote:
>
> Fix Error reported by checkpatch.pl
>
> arch/parisc/math-emu/fcnvxf.c:99: ERROR: space required after that ',' (=
ctx:VxV
> )
>
> Signed-off-by: maqimei <2433033762@qq.com>

Thanks for that patch!

Your patch is correct and as such it should be applied.
But please notice the arch/parisc/math-emu/README file (in the same
directory), which states:
All files except driver.c are snapshots from the HP-UX kernel.  They've
been modified as little as possible.  Even though they don't fit the
Linux coding style, please leave them in their funny format just in case
someone in the future, with access to HP-UX source code, is generous
enough to update our copies with later changes from HP-UX -- it'll
make their 'diff' job easier if our code is relatively unmodified.

So, I won't apply any patch to that directory, unless it fixes a real bug
or is required to compile the kernel.

Thanks,
Helge

> ---
>  =C2=A0arch/parisc/math-emu/fcnvxf.c | 2 +-
>  =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/parisc/math-emu/fcnvxf.c b/arch/parisc/math-emu/fcnvxf=
.c
> index 6940179..f5f9376 100644
> --- a/arch/parisc/math-emu/fcnvxf.c
> +++ b/arch/parisc/math-emu/fcnvxf.c
> @@ -96,7 +96,7 @@
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Sgl_increment(result);
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 case ROUNDNEAREST:
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 Sgl_roundnearest_from_int(src,result);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 Sgl_roundnearest_from_int(src, result);
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (Is_inexacttrap_ena=
bled()) {
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 *dstptr =3D result;