Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 20 Jul 2023 08:12:54 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Walker Chen <walker.chen@starfivetech.com>
CC:     Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: starfive: Explicitly include correct DT includes
Message-ID: <20230720-captive-wife-8bdd341fa8f5@wendy>
References: <20230714175149.4068174-1-robh@kernel.org>
 <6d503477-82eb-c201-129a-009bcde485d0@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Q61HPjpCze90uyKW"
Content-Disposition: inline
In-Reply-To: <6d503477-82eb-c201-129a-009bcde485d0@starfivetech.com>
Precedence: bulk

--Q61HPjpCze90uyKW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 20, 2023 at 02:12:51PM +0800, Walker Chen wrote:
> On 2023/7/15 1:51, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >=20
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/soc/starfive/jh71xx_pmu.c | 1 -
> >  1 file changed, 1 deletion(-)
> >=20
> > diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/j=
h71xx_pmu.c
> > index 7d5f50d71c0d..d3b78a619d40 100644
> > --- a/drivers/soc/starfive/jh71xx_pmu.c
> > +++ b/drivers/soc/starfive/jh71xx_pmu.c
> > @@ -10,7 +10,6 @@
> >  #include <linux/iopoll.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> > -#include <linux/of_device.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_domain.h>
> >  #include <dt-bindings/power/starfive,jh7110-pmu.h>
>=20
> Nice! Thank you for your careful discovery, this helps simplify the code.

Huh, seems I missed this patch. Now applied, thanks!

--Q61HPjpCze90uyKW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLjedgAKCRB4tDGHoIJi
0vsDAQCuzaEOC//rMky0CIQbHRukRzUFHVoUi5eh/3WIk3BZPwD/f6kXwQ4NNyIS
ZLj28G8IuwKFCpSF6f4Ac2+nAj8e4Qk=
=LdIm
-----END PGP SIGNATURE-----

--Q61HPjpCze90uyKW--