Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9226122rwp; Thu, 20 Jul 2023 01:15:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlEoNyytaPx8bBB/Lfz4qOvs4e6oTRNbKXjFbNe1jIcUIEOrmlAOa9hnGipYovCL09jyY57t X-Received: by 2002:a17:906:5d:b0:993:eed1:8f2 with SMTP id 29-20020a170906005d00b00993eed108f2mr4315404ejg.1.1689840927926; Thu, 20 Jul 2023 01:15:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689840927; cv=none; d=google.com; s=arc-20160816; b=JPdmEnHOJD523nwwH8pS+1MHCV4PY3LPD1NrpNnfxH4ky4s9V48r2Um3qBhQpHLtC+ n+Mf6/vtQj0VkoGLafLJg+Iz0EIahFgxXVhT6SSuEsIkJU+ibNDKXW7PM4mnPsCRHMLp 1WYbt58RQ1K1+pOAAhdZ0tAiXyZU0F8mHqNohsN+Kgmjmkbb8a5H7EttBXTkTOLVbZl4 0kiResMRfe64Z2WZd868Muj+EmrjQ4EeYb0CIpNF5rO8mqt6W/DCm3G6o4yT3B41061X Tlq35mKilNORzgzXf8oEIsQ2OU0pwGG4NfWMON0lDEwul7P0dSdPhMTd0bWDyhLA9upi KUzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=teYxkEgmJw65LaP0VLqbYjRdgqHGntA5XFxi/KG4CoY=; fh=vhIoJ29ohhquC1HqCwNn+IPM05SEcv/tM48DwFvn19U=; b=z9XRJG92+GGuUMEBwiZRS1KUpd3JgCGoZxIaLoJIf94dN5gvcJmpIzfhymJBqud4YG k7PGCQUVLhUJKJoAXzCr3bV89OsMym07PzIZyHHTfBRTQBgNrSdsKedgF3C84r4t1Y3L wnxGeUUlZZgs+pldQiZ3j9SXlNWFfGpt/V9YeXWDuxXqT9MzgLKDqQnBTxqgeBZuiBO5 KNoKfhZEBPFaLTliOSV2uZr9s0q2wMTE/d0YyuqQ+XFI/79J6MMQ8FgUlCJ+A2WVCL+A z2dnuWZbMOG0kFimYIrb9gt9oEOazAoImeD4dLZ6gZZ/hP4JltBYmrknMN5bx0c2VgJ/ Ax0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lt5-20020a170906fa8500b00992ac59b3f2si317354ejb.585.2023.07.20.01.15.03; Thu, 20 Jul 2023 01:15:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231852AbjGTH7E (ORCPT + 99 others); Thu, 20 Jul 2023 03:59:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231866AbjGTH7C (ORCPT ); Thu, 20 Jul 2023 03:59:02 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 083D8135; Thu, 20 Jul 2023 00:58:54 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8E80268B05; Thu, 20 Jul 2023 09:58:50 +0200 (CEST) Date: Thu, 20 Jul 2023 09:58:49 +0200 From: Christoph Hellwig To: Nitesh Shetty Cc: Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, bvanassche@acm.org, ming.lei@redhat.com, dlemoal@kernel.org, nitheshshetty@gmail.com, gost.dev@samsung.com, Kanchan Joshi , Anuj Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v13 1/9] block: Introduce queue limits for copy-offload support Message-ID: <20230720075849.GA6246@lst.de> References: <20230627183629.26571-1-nj.shetty@samsung.com> <20230627183629.26571-2-nj.shetty@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627183629.26571-2-nj.shetty@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h > index b7b56871029c..dff56813f95a 100644 > --- a/include/uapi/linux/fs.h > +++ b/include/uapi/linux/fs.h > @@ -64,6 +64,9 @@ struct fstrim_range { > __u64 minlen; > }; > > +/* maximum copy offload length, this is set to 128MB based on current testing */ > +#define COPY_MAX_BYTES (1 << 27) This should not be in the UAPI. It is a totally arbitrary internal limit.