Date: Fri, 26 Oct 2007 02:50:29 -0700 (PDT)
Message-Id: <20071026.025029.00497274.davem@davemloft.net>
To: rientjes@google.com
Cc: adobriyan@sw.ru, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] De-constify sched.h
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.DEB.0.9999.0710260235130.8261@chino.kir.corp.google.com>
References: <20071026081721.GA6244@localhost.sw.ru>
	<alpine.DEB.0.9999.0710260235130.8261@chino.kir.corp.google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 866
Lines: 21

From: David Rientjes <rientjes@google.com>
Date: Fri, 26 Oct 2007 02:42:30 -0700 (PDT)

> On Fri, 26 Oct 2007, Alexey Dobriyan wrote:
> 
> > 2) There is no such thing as const task_struct. Anyone who think otherwise
> >    deserves compiler warning.
> > 
> 
> A 'const struct task_struct *' can be used as an annotation to mean that 
> no member of the struct is modified through that pointer, so it's 
> perfectly acceptable to qualify formals in that manner.

But in one of the cases he un-const's the code does modify
the object through the pointer.  At least that one should
be reverted since the annotation is wrong.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/