Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9277571rwp; Thu, 20 Jul 2023 02:19:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlERQa18avEm5axlkeMs9gRuQxt0dnPuLI/8l6f4Ill6o0NCTluEWkF/9GIPAlBZm83wWcnn X-Received: by 2002:a17:902:f544:b0:1b8:c6f8:d9b with SMTP id h4-20020a170902f54400b001b8c6f80d9bmr7074638plf.34.1689844767713; Thu, 20 Jul 2023 02:19:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689844767; cv=none; d=google.com; s=arc-20160816; b=GAmaLfx/EXSomjjvJM3EH2sKty/T1n/xu09oyvc3xDJHNa9jf/FdR1MPwX8hrNB0fS 9g08G6thqnB+jFp137chxO58tE+fR+zo0IOk38iv8qakuew2N652pkrgQQ6nf0Fljlcw TEgPmWDJcaHMY4Ij9z+GO6oO5z6slLU1JYNpCQPghsdkt41j/yTSMFz/JEQTi1emJgz6 aplD8v99TkTieOepgQqfvJE9ONuIKcuA4blskYPa13i24YUmCCbhuGWlHIbnfwItDtnH +urNMUYeZpn8sUD1o7IJQpcJZ1bmX2HDtvNFzwlTXG/b2uGgiZ9ED1wQik/dQtFW98tX 1rEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/VSCtrwwP2EAslnY7vkMuCeH41B29zu73FAbLzklgw4=; fh=lqZe17anPS5jAVw4E4knh0WBOTb83GFVDKB2fhEmUOI=; b=CjcaLAB5cCd8ZgvFGft6BEsa86miH8qO8IGSpgDcKuMDKWBpz2OplpkfO31tVFRsaB JR1rXtWJUqzJEdDfm4kk/EFEFi7SF6BvZNL3b99NtDhhdkfnK0CAXn8cpuDiOqt/uGks 0+CBdL9bpxR0nfVVF7EwEV5P291epm728LjxBAnGelrOyLqfEo9nG0mO19stJHk7FKiw P8CPAgMBIXTwhx76+20WOgV9l8HMVMAaAYvFGMsPab+8YXTCxbM01DpBWfQgcLF8kYUc L7bhSw0qDMFlBaR8vGPrwDOVpeJXUTTRDKQ7WbcySXfqi0Y795pSsIXRXsOD/xvijIv5 YVEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a170902f54f00b001b8ae8ed8c3si539945plf.535.2023.07.20.02.19.15; Thu, 20 Jul 2023 02:19:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbjGTI6G (ORCPT + 99 others); Thu, 20 Jul 2023 04:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbjGTIe1 (ORCPT ); Thu, 20 Jul 2023 04:34:27 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8C3268C; Thu, 20 Jul 2023 01:34:27 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3D3A46732D; Thu, 20 Jul 2023 10:34:23 +0200 (CEST) Date: Thu, 20 Jul 2023 10:34:22 +0200 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Huanpeng Xin , minchan@kernel.org, ngupta@vflare.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xinhuanpeng , Christoph Hellwig Subject: Re: [PATCH] zram: set zram bio priority to REQ_PRIO. Message-ID: <20230720083422.GA7112@lst.de> References: <20230718071154.21566-1-xinhuanpeng9@gmail.com> <20230718074929.GD955071@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718074929.GD955071@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org People really need to stop randomly using REQ_PRIO. It was added back then because I did not want to overload REQ_META for WBT priorisation, but it looks other added this somewhat bogus priorisation back anyway. If that is to stay it should probably just go away entirely, but certainly not added for magic boosters for normal data I/O.