Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbXJZKVH (ORCPT ); Fri, 26 Oct 2007 06:21:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750798AbXJZKU4 (ORCPT ); Fri, 26 Oct 2007 06:20:56 -0400 Received: from www.tglx.de ([62.245.132.106]:41786 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbXJZKUz (ORCPT ); Fri, 26 Oct 2007 06:20:55 -0400 Date: Fri, 26 Oct 2007 12:20:35 +0200 (CEST) From: Thomas Gleixner To: "Huang, Ying" cc: Andrew Morton , "H. Peter Anvin" , Ingo Molnar , Andi Kleen , "Eric W. Biederman" , Chandramouli Narayanan , LKML , Arjan van de Ven Subject: Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support In-Reply-To: <1193391002.23935.300.camel@caritas-dev.intel.com> Message-ID: References: <1193295473.23935.202.camel@caritas-dev.intel.com> <1193360591.23935.212.camel@caritas-dev.intel.com> <1193391002.23935.300.camel@caritas-dev.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 23 On Fri, 26 Oct 2007, Huang, Ying wrote: > On Fri, 2007-10-26 at 10:48 +0200, Thomas Gleixner wrote: > > > EFI uses the Windows x86_64 calling convention. The lin2win may be a > > > more general naming convention that can be used for some other code (the > > > NDISwrapper?) in the future. Do you agree? > > > > I agree not at all. I do not care whether the EFI creators smoked the > > Windows-crackpipe or some other hallucinogen when they decided to use > > this calling convention. We definitely do not want to think about > > NDISwrapper or any other Windows related hackery in the kernel. > > OK, I will change the name to something like lin2efi. Can we simply use call_efi_XXX(). lin2efi() sounds like a conversion routine, but it is not. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/