Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <496d7fd1-8d15-7566-f3e0-07a88e477fe2@intel.com>
Date:   Thu, 20 Jul 2023 10:38:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1] ACPI: processor: Refine messages in
 acpi_early_processor_control_setup()
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
References: <2703565.mvXUDI8C0e@kreacher>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <2703565.mvXUDI8C0e@kreacher>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnAyNWl2NUNmZGRSSDZjRkM0QWZFZldJaER1SElTRGVmZ1E1dVN0ZVhLbkRl?=
 =?utf-8?B?YnpIQ0ZJUzV0TlE5T1ZPQ0lzcXZLMGo1N05FUU5yRnNSU3lYOHk3OUZsczVP?=
 =?utf-8?B?bUd3QkZMRm9BM3VCSkc0VnlCUkJDa0JLQVZoRk4zcGMxNlZxb1lOeU9PQmZQ?=
 =?utf-8?B?UVhNTHhnT2wyaE96NUwzMU5TWGlXTzBudjJFeFJCbjFDUm9FajYyMTNRaFRN?=
 =?utf-8?B?UStPNTE0N2s5ZUZMUi9QS1B0amtnZ2loUE1pNm5wempKcVFhZklRaHlRZUhM?=
 =?utf-8?B?Y3JwZVNOVUpRclZHK1ZTbmhvREpPdWV3NjhCV1JtY3AxRWI0Q250dTJ0NFFT?=
 =?utf-8?B?TGJPK1BEWHNpTFRYRDNtb2ExVGlLNmkrRU1mQ0dIY1Bzai9CekVoLzZPdDUz?=
 =?utf-8?B?MXFGanRLRFF0bEQ3RmpyS3ZHL0FOTjdDb2NML1VaOFFhWFZJcTBiQ20wSk0v?=
 =?utf-8?B?b09STG9CR2hVWmg4azRTMzdwenVGcVlsV2VGLzkvNElLTGdSRmR5YThCMC9q?=
 =?utf-8?B?K2dYYzdUcmExRFZwekdUVVJTZFA1UWVpazBFcjYyRzVkVnRmbmRtWW1KWUUv?=
 =?utf-8?B?bVB6SXJ3SE51TGZBcTE2OHFEdnRUcnBITXpxbE9veDFpMGdzRXZ1RHZCUFZa?=
 =?utf-8?B?dUxSQ3hXaVQ3RkZUN1pVNkd5TURwQVRCZ2pUVWZKT2dLNE5mVWRLdVZPZ1Jr?=
 =?utf-8?B?Wi9Ic2QwUzFwRDViM2lDMTM2TjA4dW9lUWMrQ05nb2FBR1BUc2hFZ01OWTlM?=
 =?utf-8?B?SFRFRVRQR0dsTjA2TlNDZHZ3bHJiU2s2TkRJTmFrSkt0bEZ6NjZWbUZidjQw?=
 =?utf-8?B?VTl3U1I2c3k5aWdPMExoaGxlcXdINjgyb0RHQ1daN1JKYzRYc0tNZWtqMmpF?=
 =?utf-8?B?UnpkVGt5U3BxczFlcjJIZjJjbzJqMjYySGs0ME5nUXh3S1o1a2hNT2tNbzNX?=
 =?utf-8?B?TUthZjhLRjFHM1VObGJPYzB3ZXd4aC9aUG1HSWcyUldHRDdBQmRpKzVxVGZF?=
 =?utf-8?B?NkxFTW5zSDlncFcxQ2F4LzBkL095ZHRrU0VXZDFyOEwwWUExU3VCRUErYWFM?=
 =?utf-8?B?QmRJUFh0VE0zS3Erd0gzcXJSSnJNaCt0eERtVDRlemdTZnE4cnZ2cUdaMUdD?=
 =?utf-8?B?RUFhUDhFdjRFZjNBZnE3ZHpyYU9xN3lDRFE4RFlETXRmeDg1VC92UDhyK2Vz?=
 =?utf-8?B?Q2pVZ21CVkNqbU55aDhqOXUrcVBhMGZNb2Q2VEtOandjSjlTSTk2WklRT1R4?=
 =?utf-8?B?djhsaDdYdVRUZ0VnMXAvd0ZtSG1CbzNna3BoWWxQMHd6TVBhM0loNTFBUXdq?=
 =?utf-8?B?cWtnb0dPcVN3VlhvRmdONnFuRStiSUgxQ2pPK1pwdjdHQTVUTzZ4WGc3RVlU?=
 =?utf-8?B?OHRyRDlPaWRoM0tObkM2S0pyQyt1V3MvY1NBV2IyZ05xLytuRjNzU2dpbnhP?=
 =?utf-8?B?WGFoc3R3MWFrTDRUbDlZWjNpT0VQbUo0dEhvVmgvZ1BMMUVlajNtbDlIRHUw?=
 =?utf-8?B?alR5eU5uZTVuMk51ME5ZZFVtRUVVd1UrVVBlUlhqUGs1RXhRMGV5Um9UV1l5?=
 =?utf-8?B?VERoUENOK1laU0F1RVdSL090V084MUl1dFgrNDExNmhoL3pqakhhZmtFQ0xQ?=
 =?utf-8?B?WjhaSzZZaldNYmpmSFhFanY0T1J3eC85LzZwdFF3N0JQQmtzUjd3SHZQdUdw?=
 =?utf-8?B?VzY2eTRqSnpzN1FyNmFDdkxsWjlZQVlDQU9HNUtrdUNXWVVURnBKYUx4OTI0?=
 =?utf-8?B?bU5PQnhLWFB0d0ZyNXFKTU9kay9BRHlpUDJKWnArMXNKMm16dTRhMGFVZFFu?=
 =?utf-8?B?Tk1uOTZ3RXBCSDQ1eVlHbVBVb0lFbjJwK1g1Ny84MW12ZlFOLzVWV0QxY0Z6?=
 =?utf-8?B?dE4zOTlxYkVCeDlMdjFEYTUwaXBUcW1WUjRLQjgzZ0tVNldSZkxWNWQwYlNU?=
 =?utf-8?B?OG5PS0NSeGdVTVcxclpsV2R0L05QdUIxYnVOMFRxRGN2emhOa0t3MHp0bEZC?=
 =?utf-8?B?VFovbGM0K09pa0cyeUE2NjBvdTJuakxZNnprSnV0Yks5WDdDMDh1dWZUTUFU?=
 =?utf-8?B?YWtjMjR2cXJzTkdNUTdSTHBJa0g5d0FkUWxhcVQ2NzFvRkpHSzlMRmRJeVRn?=
 =?utf-8?B?SnJXaVEveld5UXV4aEtvR0t5V3ZZcDNoOEg4ODh4QVdTN0FVSlhZcHp3Zm1h?=
 =?utf-8?B?eUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca728e6c-b798-4def-be9a-08db88fcc4c8
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 08:39:02.0561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lqyHkAUdp5nDHo+m6aioj+EOd/9G3RqKHoBShHatQcSJW5tqMEtW7PYsDACYCBgzp58aZwLgU4C6oxHAHdldchbHYclkdAVumjbPqafl1vs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6666
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/19/2023 6:02 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The source and meaning of the messages printed by
> acpi_early_processor_control_setup() is unclear, so add a pr_fmt()
> definition to acpi_processor.c and expand the messages to make it
> clear that they are about CPUs.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>
> Based on linux-next.
>
> ---
>  drivers/acpi/acpi_processor.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/acpi_processor.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/acpi_processor.c
> +++ linux-pm/drivers/acpi/acpi_processor.c
> @@ -9,6 +9,7 @@
>   * Copyright (C) 2013, Intel Corporation
>   *                     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>   */
> +#define pr_fmt(fmt) "ACPI: " fmt
>  
>  #include <linux/acpi.h>
>  #include <linux/device.h>
> @@ -611,9 +612,9 @@ static bool __init acpi_early_processor_
>  void __init acpi_early_processor_control_setup(void)
>  {
>  	if (acpi_early_processor_osc()) {
> -		pr_info("_OSC evaluated successfully\n");
> +		pr_info("_OSC evaluated successfully for all CPUs\n");
>  	} else {
> -		pr_info("_OSC evaluation failed, trying _PDC\n");
> +		pr_info("_OSC evaluation for CPUs failed, trying _PDC\n");
>  		acpi_early_processor_set_pdc();
>  	}
>  }

Looks good to me,
Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>
>
>
>