Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a706af0-8b19-25c5-1a76-0add28f5d214@suse.com>
Date:   Thu, 20 Jul 2023 10:39:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] r8152: Suspend USB device before shutdown when WoL is
 enabled
To:     Alexandru Gagniuc <alexandru.gagniuc@hp.com>,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, hayeswang@realtek.com, jflf_kernel@gmx.com,
        bjorn@mork.no, svenva@chromium.org, linux-kernel@vger.kernel.org,
        eniac-xw.zhang@hp.com, stable@vger.kernel.org
References: <2c12d7a0-3edb-48b3-abf7-135e1a8838ca@rowland.harvard.edu>
 <20230719173756.380829-1-alexandru.gagniuc@hp.com>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230719173756.380829-1-alexandru.gagniuc@hp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVlBNVYyek12cllpWjJlT0trNTRKV3IrQ0VzeWppVU5SNlkwUGJ5SWhpb1Nv?=
 =?utf-8?B?L0FtYWcvTS8wRVhCUFF0eHdhdUEzR2szYUNoc0lkMHl4RVZvM1laSWU3T2p2?=
 =?utf-8?B?N3ZZc1NjaDlzTW9tNTR4YUQ0OXI3akhFUnJtc3FWbWs4VDI0SEg1eUVVV1pX?=
 =?utf-8?B?VHo3N0hwdnY2enVsZjY1dFR5R2VJcXZqOTZKYy9lRWlqVjZtTWtuMlJKM0V6?=
 =?utf-8?B?Rm9CZWlVdktsNTdpQllGb29wdUU3bkcyOEVZRHM2MEhhNWtRdmRGRWFYb0FD?=
 =?utf-8?B?d2o1TGtrRkpraWRJUXFMdlNYTkZCVnN6SUdyejlsSVlES290L3RQRzdxSk5x?=
 =?utf-8?B?OHhxbXFqZjI4S1V6K0ZwcDNBaUdCaXh5aWxpaHErVTlEZEVXeVluU3Zuampv?=
 =?utf-8?B?QS9vNFo2N0dRYzkxOVRtWEI1MC9NWTFvS2V5eEhMYkJ0TURFSHNpSDZqYm5D?=
 =?utf-8?B?MTFUWU5FWDJWY0dBbkJjeFdpbWNMcnhzcjhYeVFpVGtzUmlXRkNxMWlSbzQy?=
 =?utf-8?B?ZFV5bkMyYXZlQTdsOFpKVTYrVzRuR1psb0xCSGg5ZW10U05PYUdUTDNwZUZz?=
 =?utf-8?B?QkhGdFg1SnpqV0w2OHNMUmpQcTJIdGlNd0ZOTlBOeDBmQ1RJeURhSzk5N0Fy?=
 =?utf-8?B?NFhJTHY4RGdLRE1GcnIwNm5CZmhnei8yczNDc04wRUNDWVJMb0dxS1diRmZy?=
 =?utf-8?B?QTVtUTdUdDg4RzJnY3pkcmVoekRtc3lEdU1MNUU2cUc3TXQzaUpoT1lMcnhV?=
 =?utf-8?B?YkhnV2ZmODFiblpGMGZBTkNVTzJTOGJBTi9zQTVlaU94d2djN3FlSkhUeWg1?=
 =?utf-8?B?YlF2ZjZSMGZtUU1iZzBKV3NKVmh2WXJWbW9ZVmlFVHZiblEvbE9wUmxNVjFS?=
 =?utf-8?B?am90VU5NMVJKbmZ1UGNLZWk0TE10Mi9peTVKbGhzRmZIeG5lMkJzWDhBaWUv?=
 =?utf-8?B?QnE0YU5xU3J2ZXdjcFRMQ0lzOTg4SDdUN3dMcFpyM1JPU3ZIQ2kwRWxhdjFO?=
 =?utf-8?B?b1lXeC9zeXpnZGtUNVNZWkZWbzhxb09xa2ZRQXBidStoenRRTE5QNjJ5bTFu?=
 =?utf-8?B?WnN6Wkp3ZmFYaXFydXl4QkdYejd2YlJTdDNnU3duUEJhRTkxcUVXVzZqTzJQ?=
 =?utf-8?B?V04yVWJmT3dqVGhYV3BsMkFSQzFXMzQxL2dqcWk5TFJ1QlFzNktlTWhMaXJ5?=
 =?utf-8?B?T1A5cmUvNm1GL3FycjJIeTBzaVo0dHIyOWNXNGlueE1VWHlOaVgzd2k0Tmda?=
 =?utf-8?B?RXhsOEdSNVBUTitRbGlWNUdveXBnbTFEQlNsSURoRTByYzl5RVg0RTFhMWZt?=
 =?utf-8?B?Ync0ak9NSnFGdmVScXRBbmlocXJlMjYrdWNnc1ZROUpOcS9ubG9wSW5OL3FU?=
 =?utf-8?B?eFNtV01zcll3aldWcHltRVU1Q2laQ0pvMlN4THhRU2dvU2VsRWlPdWhNU05s?=
 =?utf-8?B?cmpJOC8vbWVsOUlDWEVwRk9ydEFvNmVaNk0rL1hMTzV6NnAxMFlUS3FPd0Zj?=
 =?utf-8?B?NEhPTG51QnVGU2xzc1A5d0I4dXdUeVB6TDZxK05mSWhaQktTT2VUUEUvd1Fi?=
 =?utf-8?B?aU9PcVpzTlU1RDJEdTdjQytHd25DUW9hWTJuRGw5YTFTbHRIdytjWmpSMGdO?=
 =?utf-8?B?TmczTDQxNFFMZk9naDBjN0xTYzNZVzRLMkw1emtINzFiK2JiaTJtbFVCL0VC?=
 =?utf-8?B?NEViOEZmMVlNWjR0NkxRa1pWSlFTQjdmTCtkSHROYWlsR2xaMUo4eEZCMGtH?=
 =?utf-8?B?M2taTUd3K1BUdmhBVkJ3RFVzcnNzQmFvMEVwNEs0TUc1UlV2UDQrZzEvenBo?=
 =?utf-8?B?Rlc5ZzFLaExCb056c3hRZitQUXU3dW1EZUNRZ0U2TURudTMwZjJ1cDRpcC9o?=
 =?utf-8?B?ZnlEdzNPNnFhc283aDBlYml0cE1ac09yYmYxeWgvTVZDKzZVZGZ3cXZ2aXdZ?=
 =?utf-8?B?VFNNWFBUbXF1WGNIYXZSWmdnUVhCQ1h2YzE5dWJvSHMyQzZDQUsyWFpCbTZZ?=
 =?utf-8?B?ZHp4b08xcUN2OWFKdlJwM25NNHY2QjhWVEpNbldmZmhGK05QeEtEdHh1c2pS?=
 =?utf-8?B?dkIzakt0dTlQZmcyNFo4dDYweXlkT2FIaGQ3SGlNczBGeDdmdXd4YytkTE1I?=
 =?utf-8?B?M0xrVnU4UmJCQUluUTY4bXphNG83aENjbk9SVmZNQzFYdTJZZHZQMlVHVUY3?=
 =?utf-8?Q?ZS5q1MUfRclVuiS6DIHP4jo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd687252-275a-4b50-75e5-08db88fcdd22
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 08:39:42.8260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C1tiG1fZoCkWFARd/KpLVAiMukp4Osu/tRiVylHW3Fm/e6XJ/owD7TdPDysdhRzLCYIDLlgUlCK7t9tbJ/G1ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8691
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19.07.23 19:37, Alexandru Gagniuc wrote:
> For Wake-on-LAN to work from S5 (shutdown), the USB link must be put
> in U3 state. If it is not, and the host "disappears", the chip will
> no longer respond to WoL triggers.

First, a question, does this also apply to S4?

> To resolve this, add a notifier block and register it as a reboot
> notifier. When WoL is enabled, work through the usb_device struct to
> get to the suspend function. Calling this function puts the link in
> the correct state for WoL to function.

Second, do we really want this to be done for every driver with this issue
or do we want a flag for core USB code to suspend devices when the system
goes down? UAS at least does something similar.

Third, what happens if the device is already suspended when the notifier runs?

	Regards
		Oliver