Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org>
Date:   Thu, 20 Jul 2023 10:38:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
Content-Language: en-US
To:     Alina Yu <alina_yu@richtek.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com>
 <1689758686-14409-2-git-send-email-alina_yu@richtek.com>
 <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org>
 <20230720080728.GA10433@linuxcarl2.richtek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230720080728.GA10433@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/07/2023 10:07, Alina Yu wrote:
> Hi,
> Krzysztof:
> 
> On Wed, Jul 19, 2023 at 11:44:45AM +0200, Krzysztof Kozlowski wrote:
>> On 19/07/2023 11:24, alina_yu@richtek.com wrote:
>>> From: alinayu <alina_yu@richtek.com>
>>>
>>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>>>
>>> Signed-off-by: Alina Yu <alina_yu@richtek.com>
>>> ---
>>> v4
>>> - Modify filename to "richtek,rtq2208"
>>> - Add more desciptions for "regulator-allowed-modes"
> 
> ...
> 
>>> +
>>> +          regulator-mode:
>>> +            enum: [0, 1]
>>> +            description:
>>> +              describe buck initial operating mode in suspend state.
>>
>> There is no such property on this level. Aren't you mixing initial one?
> 
> It's the initial mode in suspend-mem state, should I modify that like this ?
>         patternProperties:
>           "^regulator-state-(standby|mem|disk)$":
> 	    type: object
> 	    $ref: regulator.yaml#
> 	    properties:
> 	      regulator-mode:
> 	        enum: [0, 1]
> 		description:
>                   describe byck initial operating mode in suspend state.

Please check how other bindings do it.

> ...
> 
>>
>>> +            enum: [ 900000, 1200000, 1800000, 3300000 ]
>>> +            description:
>>> +              the fixed voltage in micro volt which is decided at the factory.
>>
>> I don't understand this property. Why this is different from min/max
> 
> 
> Because ldo has fixed voltage, so I thinks I could use a property to
> represent the fixed voltage directly. Do you suggest me modifying that like this:
> 
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <900000>;
> 
> Using min voltage equals to max voltage to represent fixed voltage, instead of self-defined property ?

Yes.


Best regards,
Krzysztof