Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87c3a3db-d172-bc98-cf83-89b874c9fee7@linaro.org>
Date:   Thu, 20 Jul 2023 10:49:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2
 boards based on IPQ9574 family
Content-Language: en-US
To:     Sridharan S N <quic_sridsn@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230720084534.6461-1-quic_sridsn@quicinc.com>
 <20230720084534.6461-2-quic_sridsn@quicinc.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230720084534.6461-2-quic_sridsn@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/07/2023 10:45, Sridharan S N wrote:
> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
> family of SoCs.
> 
> AL02-C3  - rdp437
> AL02-C7  - rdp433-mht-phy
> AL02-C10 - rdp433-mht-switch
> AL02-C11 - rdp467
> AL02-C12 - rdp455
> AL02-C13 - rdp459
> AL02-C15 - rdp457
> AL02-C16 - rdp456
> AL02-C17 - rdp469
> AL02-C19 - rdp461
> AL03-C2  - rdp458
> 
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
>  .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index dd66fd872c31..d992261da691 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -89,10 +89,20 @@ description: |
>          adp
>          ap-al01-c1
>          ap-al02-c2
> +        ap-al02-c3
>          ap-al02-c6
>          ap-al02-c7
>          ap-al02-c8
>          ap-al02-c9
> +        ap-al02-c10
> +        ap-al02-c11
> +        ap-al02-c12
> +        ap-al02-c13
> +        ap-al02-c15
> +        ap-al02-c16
> +        ap-al02-c17
> +        ap-al02-c19

Why? I asked once, but there was no feedback from Qualcomm.

Why do we need to do this? What's the point?

> +        ap-al03-c2
>          ap-mi01.2
>          ap-mi01.3
>          ap-mi01.6
> @@ -365,10 +375,20 @@ properties:
>            - enum:
>                - qcom,ipq9574-ap-al01-c1
>                - qcom,ipq9574-ap-al02-c2
> +              - qcom,ipq9574-ap-al02-c3
>                - qcom,ipq9574-ap-al02-c6
>                - qcom,ipq9574-ap-al02-c7
>                - qcom,ipq9574-ap-al02-c8
>                - qcom,ipq9574-ap-al02-c9
> +              - qcom,ipq9574-ap-al02-c10
> +              - qcom,ipq9574-ap-al02-c11
> +              - qcom,ipq9574-ap-al02-c12
> +              - qcom,ipq9574-ap-al02-c13
> +              - qcom,ipq9574-ap-al02-c15
> +              - qcom,ipq9574-ap-al02-c16
> +              - qcom,ipq9574-ap-al02-c17
> +              - qcom,ipq9574-ap-al02-c19

This looks fake. Sorry, but these boards have no differences.

Best regards,
Krzysztof